Anton Protopopov 79ea1a12fb bpf: fix a memory leak in the LRU and LRU_PERCPU hash maps ...

[ Upstream commit b34ffb0c6d ]

The LRU and LRU_PERCPU maps allocate a new element on update before locking the
target hash table bucket. Right after that the maps try to lock the bucket.
If this fails, then maps return -EBUSY to the caller without releasing the
allocated element. This makes the element untracked: it doesn't belong to
either of free lists, and it doesn't belong to the hash table, so can't be
re-used; this eventually leads to the permanent -ENOMEM on LRU map updates,
which is unexpected. Fix this by returning the element to the local free list
if bucket locking fails.

Fixes: 20b6cc34ea ("bpf: Avoid hashtab deadlock with map_locked")
Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
Link: https://lore.kernel.org/r/20230522154558.2166815-1-aspsk@isovalent.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-06-05 09:21:14 +02:00

..

preload

libbpf: Move BPF_SEQ_PRINTF and BPF_SNPRINTF to bpf_helpers.h

2021-05-26 10:45:41 -07:00

arraymap.c

bpf: Acquire map uref in .init_seq_private for array map iterator

2022-08-25 11:40:03 +02:00

bpf_inode_storage.c

bpf: Fix spelling mistakes

2021-05-24 21:13:05 -07:00

bpf_iter.c

bpf: Refactor BPF_PROG_RUN into a function

2021-08-17 00:45:07 +02:00

bpf_local_storage.c

bpf: Annotate data races in bpf_local_storage

2023-05-24 17:36:44 +01:00

bpf_lru_list.c

bpf_lru_list: Read double-checked variable once without lock

2021-02-10 15:54:26 -08:00

bpf_lru_list.h

bpf: Fix a typo "inacitve" -> "inactive"

2020-04-06 21:54:10 +02:00

bpf_lsm.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next

2021-06-17 11:54:56 -07:00

bpf_struct_ops_types.h

bpf: tcp: Support tcp_congestion_ops in bpf

2020-01-09 08:46:18 -08:00

bpf_struct_ops.c

bpf: Handle return value of BPF_PROG_TYPE_STRUCT_OPS prog

2021-09-14 11:09:50 -07:00

bpf_task_storage.c

bpf: Use this_cpu_{inc|dec|inc_return} for bpf_task_storage_busy

2022-10-26 12:34:41 +02:00

btf.c

btf: fix resolving BTF_KIND_VAR after ARRAY, STRUCT, UNION, PTR

2023-03-17 08:48:55 +01:00

cgroup.c

bpf: Don't EFAULT for getsockopt with optval=NULL

2023-05-11 23:00:30 +09:00

core.c

bpf: Adjust insufficient default bpf_jit_limit

2023-03-30 12:47:47 +02:00

cpumap.c

bpf: cpumap: Implement generic cpumap

2021-07-07 20:01:45 -07:00

devmap.c

bpf, devmap: Exclude XDP broadcast to master device

2021-08-09 23:25:14 +02:00

disasm.c

bpf: Relicense disassembler as GPL-2.0-only OR BSD-2-Clause

2021-09-02 14:49:23 +02:00

disasm.h

bpf: Relicense disassembler as GPL-2.0-only OR BSD-2-Clause

2021-09-02 14:49:23 +02:00

dispatcher.c

bpf: Remove bpf_image tree

2020-03-13 12:49:52 -07:00

hashtab.c

bpf: fix a memory leak in the LRU and LRU_PERCPU hash maps

2023-06-05 09:21:14 +02:00

helpers.c

bpf: Add MEM_RDONLY for helper args that are pointers to rdonly mem.

2022-05-01 17:22:26 +02:00

inode.c

bpf: Fix mount source show for bpffs

2022-01-27 11:05:26 +01:00

Kconfig

sock_map: Relax config dependency to CONFIG_NET

2021-07-15 18:17:49 -07:00

local_storage.c

bpf: Increase supported cgroup storage value size

2021-07-27 15:59:29 -07:00

lpm_trie.c

bpf: Allow RCU-protected lookups to happen from bh context

2021-06-24 19:41:15 +02:00

Makefile

bpf: Enable task local storage for tracing programs

2021-02-26 11:51:47 -08:00

map_in_map.c

bpf: Remember BTF of inner maps.

2021-07-15 22:31:10 +02:00

map_in_map.h

bpf: Add map_meta_equal map ops

2020-08-28 15:41:30 +02:00

map_iter.c

bpf: Introduce MEM_RDONLY flag

2022-05-01 17:22:24 +02:00

net_namespace.c

bpf: Add support for forced LINK_DETACH command

2020-08-01 20:38:28 -07:00

offload.c

bpf: restore the ebpf program ID for BPF_AUDIT_UNLOAD and PERF_BPF_EVENT_PROG_UNLOAD

2023-01-24 07:22:46 +01:00

percpu_freelist.c

bpf: Initialize same number of free nodes for each pcpu_freelist

2022-11-26 09:24:38 +01:00

percpu_freelist.h

bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI

2020-10-06 00:04:11 +02:00

prog_iter.c

bpf: Refactor bpf_iter_reg to have separate seq_info member

2020-07-25 20:16:32 -07:00

queue_stack_maps.c

bpf: Eliminate rlimit-based memory accounting for queue_stack_maps maps

2020-12-02 18:32:46 -08:00

reuseport_array.c

bpf: Fix spelling mistakes

2021-05-24 21:13:05 -07:00

ringbuf.c

bpf: Add MEM_RDONLY for helper args that are pointers to rdonly mem.

2022-05-01 17:22:26 +02:00

stackmap.c

bpf: Fix excessive memory allocation in stack_map_alloc()

2022-06-06 08:43:42 +02:00

syscall.c

bpf: restore the ebpf program ID for BPF_AUDIT_UNLOAD and PERF_BPF_EVENT_PROG_UNLOAD

2023-01-24 07:22:46 +01:00

sysfs_btf.c

bpf: Load and verify kernel module BTFs

2020-11-10 15:25:53 -08:00

task_iter.c

bpf: Consolidate task_struct BTF_ID declarations

2021-08-25 10:37:05 -07:00

tnum.c

bpf, tnums: Provably sound, faster, and more precise algorithm for tnum_mul

2021-06-01 13:34:15 +02:00

trampoline.c

bpf: Fix potential array overflow in bpf_trampoline_get_progs()

2022-06-06 08:43:42 +02:00

verifier.c

bpf: Fix mask generation for 32-bit narrow loads of 64-bit fields

2023-05-30 13:55:31 +01:00