mirror of
https://github.com/hardkernel/linux.git
synced 2026-04-12 07:58:10 +09:00
9686813f6e
We added a usage of try-run to pmu/ebb/Makefile to detect if the
toolchain supported the -no-pie option.
This fails if we build out-of-tree and the source tree is not
writable, as try-run tries to write its temporary files to the current
directory. That leads to the -no-pie option being silently dropped,
which leads to broken executables with some toolchains.
If we remove the redirect to /dev/null in try-run, we see the error:
make[3]: Entering directory '/linux/tools/testing/selftests/powerpc/pmu/ebb'
/usr/bin/ld: cannot open output file .54.tmp: Read-only file system
collect2: error: ld returned 1 exit status
make[3]: Nothing to be done for 'all'.
And looking with strace we see it's trying to use a file that's in the
source tree:
lstat("/linux/tools/testing/selftests/powerpc/pmu/ebb/.54.tmp", 0x7ffffc0f83c8)
We can fix it by setting TMPOUT to point to the $(OUTPUT) directory,
and we can verify with strace it's now trying to write to the output
directory:
lstat("/output/kselftest/powerpc/pmu/ebb/.54.tmp", 0x7fffd1bf6bf8)
And also see that the -no-pie option is now correctly detected.
Fixes: 0695f8bca9 ("selftests/powerpc: Handle Makefile for unrecognized option")
Cc: stable@vger.kernel.org # v5.5+
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200327095319.2347641-1-mpe@ellerman.id.au
38 lines
1.2 KiB
Makefile
38 lines
1.2 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
include ../../../../../../scripts/Kbuild.include
|
|
|
|
noarg:
|
|
$(MAKE) -C ../../
|
|
|
|
# The EBB handler is 64-bit code and everything links against it
|
|
CFLAGS += -m64
|
|
|
|
TMPOUT = $(OUTPUT)/
|
|
# Toolchains may build PIE by default which breaks the assembly
|
|
no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \
|
|
$(CC) -Werror $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) -no-pie -x c - -o "$$TMP", -no-pie)
|
|
|
|
LDFLAGS += $(no-pie-option)
|
|
|
|
TEST_GEN_PROGS := reg_access_test event_attributes_test cycles_test \
|
|
cycles_with_freeze_test pmc56_overflow_test \
|
|
ebb_vs_cpu_event_test cpu_event_vs_ebb_test \
|
|
cpu_event_pinned_vs_ebb_test task_event_vs_ebb_test \
|
|
task_event_pinned_vs_ebb_test multi_ebb_procs_test \
|
|
multi_counter_test pmae_handling_test \
|
|
close_clears_pmcc_test instruction_count_test \
|
|
fork_cleanup_test ebb_on_child_test \
|
|
ebb_on_willing_child_test back_to_back_ebbs_test \
|
|
lost_exception_test no_handler_test \
|
|
cycles_with_mmcr2_test
|
|
|
|
top_srcdir = ../../../../../..
|
|
include ../../../lib.mk
|
|
|
|
$(TEST_GEN_PROGS): ../../harness.c ../../utils.c ../event.c ../lib.c \
|
|
ebb.c ebb_handler.S trace.c busy_loop.S
|
|
|
|
$(OUTPUT)/instruction_count_test: ../loop.S
|
|
|
|
$(OUTPUT)/lost_exception_test: ../lib.c
|