Fabian Vogt 332c7e52c5 Input: nspire-keypad - enable interrupts only when opened ...

[ Upstream commit 69d5ff3e9e ]

The driver registers an interrupt handler in _probe, but didn't configure
them until later when the _open function is called. In between, the keypad
can fire an IRQ due to touchpad activity, which the handler ignores. This
causes the kernel to disable the interrupt, blocking the keypad from
working.

Fix this by disabling interrupts before registering the handler.
Additionally, disable them in _close, so that they're only enabled while
open.

Fixes: fc4f314618 ("Input: add TI-Nspire keypad support")
Signed-off-by: Fabian Vogt <fabian@ritter-vogt.de>
Link: https://lore.kernel.org/r/3383725.iizBOSrK1V@linux-e202.suse.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-05-16 10:52:35 +09:00

..

adc-keys.c

Input: add ADC resistor ladder driver

2016-08-29 20:00:58 -07:00

adp5520-keys.c

input: keyboard: drop owner assignment from platform_drivers

2014-10-20 16:20:39 +02:00

adp5588-keys.c

input: adp5588-keys: use gpiochip data pointer

2016-04-26 15:33:44 +02:00

adp5589-keys.c

input: adp5589-keys: use gpiochip data pointer

2016-03-30 10:54:33 +02:00

amikbd.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input

2014-12-17 10:06:02 -08:00

atakbd.c

Input: atakbd - fix Atari CapsLock behaviour

2023-05-15 09:06:59 +09:00

atkbd.c

Input: atkbd - document "no new force-release quirks" policy

2015-04-11 00:03:08 -07:00

bcm-keypad.c

Input: add driver for Broadcom keypad controller

2015-03-02 15:16:52 -08:00

bf54x-keys.c

input: keyboard: drop owner assignment from platform_drivers

2014-10-20 16:20:39 +02:00

cap11xx.c

Input: cap11xx - switch to using set_brightness_blocking()

2023-05-15 11:57:53 +09:00

clps711x-keypad.c

input: clps711x-keypad: Changing the compatibility string to match with the smallest supported chip

2016-07-06 17:38:18 +02:00

cros_ec_keyb.c

Input: cros_ec_keyb - send 'scancodes' in addition to key events

2023-05-16 09:58:27 +09:00

davinci_keyscan.c

input: keyboard: drop owner assignment from platform_drivers

2014-10-20 16:20:39 +02:00

ep93xx_keypad.c

Input: ep93xx_keypad - fix handling of platform_get_irq() error

2023-05-16 09:39:06 +09:00

goldfish_events.c

ANDROID: goldfish_events: no extra EV_SYN; register goldfish

2017-01-27 13:55:42 -08:00

gpio_keys_polled.c

Input: gpio_keys_polled - add support for abs/rel axis

2015-10-14 17:15:04 -07:00

gpio_keys.c

Input: gpio_keys - add support for GPIO descriptors

2017-04-12 12:41:19 +02:00

hil_kbd.c

Input: hil_kbd - fix incorrect use of init_completion

2014-12-27 20:43:35 -08:00

hilkbd.c

Input: remove use of __devexit

2012-11-24 00:05:38 -08:00

hpps2atkbd.h

…

imx_keypad.c

Input: imx_keypad - make sure keyboard can always wake up system

2023-05-15 13:58:08 +09:00

ipaq-micro-keys.c

Input: driver for microcontroller keys on the iPaq h3xxx

2015-03-06 11:25:31 -08:00

jornada680_kbd.c

input: keyboard: drop owner assignment from platform_drivers

2014-10-20 16:20:39 +02:00

jornada720_kbd.c

Input: jornada720_kbd - remove unneeded mach/hardware.h include

2016-09-10 10:47:47 -07:00

Kconfig

Input: add ADC resistor ladder driver

2016-08-29 20:00:58 -07:00

lkkbd.c

Input: delete non-required instances of include <linux/init.h>

2014-01-06 23:23:57 -08:00

lm8323.c

Input: lm8323 - missing error check in lm8323_set_disable()

2014-12-03 15:28:26 -08:00

lm8333.c

Input: drop owner assignment from i2c_driver

2015-07-17 16:57:00 -07:00

locomokbd.c

Input: remove use of __devexit

2012-11-24 00:05:38 -08:00

lpc32xx-keys.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input

2014-12-17 10:06:02 -08:00

Makefile

Input: add ADC resistor ladder driver

2016-08-29 20:00:58 -07:00

maple_keyb.c

sh: maple: Support block reads and writes.

2009-02-27 16:07:32 +09:00

matrix_keypad.c

Input: matrix_keypad - use flush_delayed_work()

2023-05-15 12:04:59 +09:00

max7359_keypad.c

Input: max7359_keypad - switch to using matrix_keypad_build_keymap()

2015-05-15 15:58:40 -07:00

mcs_touchkey.c

Input: drop owner assignment from i2c_driver

2015-07-17 16:57:00 -07:00

mpr121_touchkey.c

Input: mpr121 - set missing event capability

2017-11-15 15:53:16 +01:00

newtonkbd.c

Input: delete non-required instances of include <linux/init.h>

2014-01-06 23:23:57 -08:00

nomadik-ske-keypad.c

Input: nomadik-ske-keypad - fix a loop timeout test

2023-05-15 16:42:58 +09:00

nspire-keypad.c

Input: nspire-keypad - enable interrupts only when opened

2023-05-16 10:52:35 +09:00

omap4-keypad.c

Input: omap4-keypad - fix handling of platform_get_irq() error

2023-05-16 09:39:07 +09:00

omap-keypad.c

Input: omap-keypad - remove set_col_gpio_val() and get_row_gpio_val()

2016-04-05 10:17:19 -07:00

opencores-kbd.c

Input: opencores-kbd - fix error handling

2014-10-28 10:32:59 -07:00

pmic8xxx-keypad.c

Input: pmic8xxx-keypad - change name of wakeup property

2015-07-23 15:01:23 -07:00

pxa27x_keypad.c

Input: pxa27x_keypad - remove an unneeded NULL check

2015-02-11 23:07:12 -08:00

pxa930_rotary.c

input: keyboard: drop owner assignment from platform_drivers

2014-10-20 16:20:39 +02:00

qt1070.c

Input: qt1070 - add OF device ID table

2018-03-22 09:17:42 +01:00

qt2160.c

Input: drop owner assignment from i2c_driver

2015-07-17 16:57:00 -07:00

samsung-keypad.c

Input: samsung-keypad - change name of wakeup property

2015-07-23 17:34:02 -07:00

sh_keysc.c

Input: delete non-required instances of include <linux/init.h>

2014-01-06 23:23:57 -08:00

snvs_pwrkey.c

Input: snvs_pwrkey - initialize necessary driver data before enabling IRQ

2023-05-15 12:39:12 +09:00

spear-keyboard.c

Input: spear-keyboard - use __maybe_unused to hide pm functions

2016-03-02 09:40:03 -08:00

st-keyscan.c

Input: st-keyscan - fix potential zalloc NULL dereference

2023-05-15 12:05:23 +09:00

stmpe-keypad.c

Merge branch 'next' into for-linus

2014-12-18 10:02:39 -08:00

stowaway.c

Input: delete non-required instances of include <linux/init.h>

2014-01-06 23:23:57 -08:00

sun4i-lradc-keys.c

Input: add new sun4i-lradc-keys driver

2014-12-21 18:59:21 -08:00

sunkbd.c

Input: sunkbd - avoid use-after-free in teardown paths

2023-05-16 09:48:35 +09:00

tc3589x-keypad.c

Input: tc3589x-keypad - remove stray ')'

2016-05-25 17:37:15 -07:00

tca6416-keypad.c

Input: use dev_get_platdata()

2013-12-06 02:06:29 -08:00

tca8418_keypad.c

Input: tca8418_keypad - remove double read of key event register

2018-03-18 11:18:53 +01:00

tegra-kbc.c

Input: tegra-kbc - fix inverted reset logic

2016-08-22 14:14:45 -07:00

twl4030_keypad.c

Input: twl4030_keypad - fix handling of platform_get_irq() error

2023-05-16 09:39:08 +09:00

w90p910_keypad.c

input: keyboard: drop owner assignment from platform_drivers

2014-10-20 16:20:39 +02:00

xtkbd.c

Input: delete non-required instances of include <linux/init.h>

2014-01-06 23:23:57 -08:00