shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-03-24 19:40:21 +09:00
Code Issues Packages Projects Releases Wiki Activity
Files
d6da19c9cace63290ccfccb1fc35151ffefc0bec
linux/fs
History
Amir Goldstein d6da19c9ca locks: fix TOCTOU race when granting write lease 
Thread A trying to acquire a write lease checks the value of i_readcount
and i_writecount in check_conflicting_open() to verify that its own fd
is the only fd referencing the file.

Thread B trying to open the file for read will call break_lease() in
do_dentry_open() before incrementing i_readcount, which leaves a small
window where thread A can acquire the write lease and then thread B
completes the open of the file for read without breaking the write lease
that was acquired by thread A.

Fix this race by incrementing i_readcount before checking for existing
leases, same as the case with i_writecount.

Use a helper put_file_access() to decrement i_readcount or i_writecount
in do_dentry_open() and __fput().

Fixes: 387e3746d0 ("locks: eliminate false positive conflicts for write lease")
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2022-08-16 10:59:54 -04:00
..
9p
9p: Fix some kernel-doc comments
2022-07-02 18:52:21 +09:00
adfs
fs: Convert block_read_full_page() to block_read_full_folio()
2022-05-09 16:21:44 -04:00
affs
affs: use memcpy_to_page and remove replace kmap_atomic()
2022-08-01 19:53:31 +02:00
afs
afs: Enable multipage folio support
2022-08-13 17:20:51 -07:00
autofs
autofs: remove unused ino field inode
2022-07-17 17:31:42 -07:00
befs
befs: Convert befs_symlink_read_folio() to use a folio
2022-08-02 12:34:03 -04:00
bfs
fs: Convert block_read_full_page() to block_read_full_folio()
2022-05-09 16:21:44 -04:00
btrfs
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
cachefiles
cachefiles: narrow the scope of flushed requests when releasing fd
2022-07-05 16:12:21 +01:00
ceph
Merge tag 'ceph-for-5.20-rc1' of https://github.com/ceph/ceph-client
2022-08-11 12:41:07 -07:00
cifs
Merge tag '5.20-rc-smb3-client-fixes-part2' of git://git.samba.org/sfrench/cifs-2.6
2022-08-13 17:31:18 -07:00
coda
coda: Convert coda_symlink_filler() to use a folio
2022-08-02 12:34:03 -04:00
configfs
configfs: fix a race in configfs_{,un}register_subsystem()
2022-02-22 18:30:28 +01:00
cramfs
cramfs: read_mapping_page() is synchronous
2022-08-02 12:34:02 -04:00
crypto
Merge tag 'ceph-for-5.20-rc1' of https://github.com/ceph/ceph-client
2022-08-11 12:41:07 -07:00
debugfs
debugfs: Document that debugfs_create functions need not be error checked
2022-02-25 11:56:13 +01:00
devpts
fsnotify: fix fsnotify hooks in pseudo filesystems
2022-01-24 14:17:02 +01:00
dlm
fs: dlm: move kref_put assert for lkb structs
2022-08-01 09:31:46 -05:00
ecryptfs
ecryptfs: Convert ecryptfs to read_folio
2022-05-09 16:21:45 -04:00
efivarfs
efi: vars: Move efivar caching layer into efivarfs
2022-06-24 20:40:19 +02:00
efs
efs: Convert efs symlinks to read_folio
2022-05-09 16:21:45 -04:00
erofs
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
exfat
exfat: Drop superfluous new line for error messages
2022-08-01 10:14:07 +09:00
exportfs
exportfs: support idmapped mounts
2022-04-28 16:31:10 +02:00
ext2
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
ext4
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
f2fs
Merge tag 'f2fs-for-6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs
2022-08-08 11:18:31 -07:00
fat
Merge tag 'mm-nonmm-stable-2022-08-06-2' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-07 10:03:24 -07:00
freevxfs
freevxfs: Convert vxfs_immed_read_folio() to use a folio
2022-08-02 12:34:03 -04:00
fscache
fscache: add tracepoint when failing cookie
2022-08-09 14:13:59 +01:00
fuse
Merge tag 'pull-work.iov_iter-rebased' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2022-08-08 20:04:35 -07:00
gfs2
Merge tag 'iomap-6.0-merge-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2022-08-11 13:11:49 -07:00
hfs
hfs: Remove check for PageError
2022-06-29 08:51:06 -04:00
hfsplus
Merge tag 'folio-6.0' of git://git.infradead.org/users/willy/pagecache
2022-08-03 10:35:43 -07:00
hostfs
hostfs: Handle page write errors correctly
2022-08-02 12:34:02 -04:00
hpfs
hpfs: Convert symlinks to read_folio
2022-05-09 16:21:45 -04:00
hugetlbfs
Merge tag 'pull-work.iov_iter-rebased' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2022-08-08 20:04:35 -07:00
iomap
Merge tag 'iomap-6.0-merge-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2022-08-11 13:11:49 -07:00
isofs
fs/buffer: Combine two submit_bh() and ll_rw_block() arguments
2022-07-14 12:14:32 -06:00
jbd2
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
jffs2
Merge tag 'for-linus-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs
2022-06-03 14:42:24 -07:00
jfs
Merge tag 'folio-6.0' of git://git.infradead.org/users/willy/pagecache
2022-08-03 10:35:43 -07:00
kernfs
kernfs: Fix typo 'the the' in comment
2022-07-28 10:57:25 +02:00
ksmbd
Merge tag '5.20-rc-ksmbd-server-fixes' of git://git.samba.org/ksmbd
2022-08-08 20:15:13 -07:00
lockd
lockd: detect and reject lock arguments that overflow
2022-08-04 10:28:48 -04:00
minix
fs: Convert block_read_full_page() to block_read_full_folio()
2022-05-09 16:21:44 -04:00
netfs
netfs: do not unlock and put the folio twice
2022-07-14 10:10:12 +02:00
nfs
Merge tag 'nfs-for-5.20-1' of git://git.linux-nfs.org/projects/trondmy/linux-nfs
2022-08-10 14:04:32 -07:00
nfs_common
nfs: Fix kerneldoc warning shown up by W=1
2021-10-04 22:02:17 +01:00
nfsd
Merge tag 'nfsd-6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux
2022-08-09 14:56:49 -07:00
nilfs2
Merge tag 'folio-6.0' of git://git.infradead.org/users/willy/pagecache
2022-08-03 10:35:43 -07:00
nls
…
notify
fsnotify: Fix comment typo
2022-07-26 13:38:47 +02:00
ntfs
Merge tag 'folio-6.0' of git://git.infradead.org/users/willy/pagecache
2022-08-03 10:35:43 -07:00
ntfs3
Merge tag 'folio-6.0' of git://git.infradead.org/users/willy/pagecache
2022-08-03 10:35:43 -07:00
ocfs2
Merge tag 'fs.setgid.v6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux
2022-08-09 09:52:28 -07:00
omfs
fs: Convert block_read_full_page() to block_read_full_folio()
2022-05-09 16:21:44 -04:00
openpromfs
fs: allocate inode by using alloc_inode_sb()
2022-03-22 15:57:03 -07:00
orangefs
orangefs: Remove test for folio error
2022-06-29 08:51:07 -04:00
overlayfs
Merge tag 'ovl-update-6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
2022-08-08 11:03:11 -07:00
proc
take care to handle NULL ->proc_lseek()
2022-08-14 15:16:18 -04:00
pstore
Merge tag 'efi-next-for-v5.20' of git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi
2022-08-03 14:38:02 -07:00
qnx4
fs: Convert block_read_full_page() to block_read_full_folio()
2022-05-09 16:21:44 -04:00
qnx6
fs: Convert mpage_readpage to mpage_read_folio
2022-05-09 16:21:44 -04:00
quota
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
ramfs
Merge branch 'akpm' (patches from Andrew)
2021-11-09 10:11:53 -08:00
reiserfs
Merge tag 'folio-6.0' of git://git.infradead.org/users/willy/pagecache
2022-08-03 10:35:43 -07:00
romfs
romfs: Convert romfs to read_folio
2022-05-09 16:21:46 -04:00
smbfs_common
Add various fsctl structs
2022-05-23 20:24:12 -05:00
squashfs
Merge tag 'mm-nonmm-stable-2022-08-06-2' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-07 10:03:24 -07:00
sysfs
kobject: kobj_type: remove default_attrs
2022-04-05 15:39:19 +02:00
sysv
Merge tag 'mm-nonmm-stable-2022-05-26' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-05-27 11:22:03 -07:00
tracefs
tracefs: Fix syntax errors in comments
2022-06-17 19:01:28 -04:00
ubifs
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
udf
fs/buffer: Combine two submit_bh() and ll_rw_block() arguments
2022-07-14 12:14:32 -06:00
ufs
Merge tag 'folio-6.0' of git://git.infradead.org/users/willy/pagecache
2022-08-03 10:35:43 -07:00
unicode
kbuild: unify cmd_copy and cmd_shipped
2022-02-14 10:37:32 +09:00
vboxsf
vboxsf: Convert vboxsf to read_folio
2022-05-09 16:21:46 -04:00
verity
fs-verity: mention btrfs support
2022-07-15 23:42:30 -07:00
xfs
Merge tag 'xfs-5.20-merge-8' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2022-08-13 13:50:11 -07:00
zonefs
Merge tag 'iomap-6.0-merge-2' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2022-08-11 13:11:49 -07:00
aio.c
Merge tag 'pull-work.iov_iter-base' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2022-08-03 13:50:22 -07:00
anon_inodes.c
fs: add anon_inode_getfile_secure() similar to anon_inode_getfd_secure()
2021-09-19 22:35:37 -04:00
attr.c
vfs: Check the truncate maximum size in inode_newsize_ok()
2022-08-08 10:39:29 -07:00
bad_inode.c
vfs: add rcu argument to ->get_acl() callback
2021-08-18 22:08:24 +02:00
binfmt_aout.c
binfmt: a.out: Fix bogus semicolon
2021-09-05 10:15:05 -07:00
binfmt_elf_fdpic.c
coredump: Snapshot the vmas in do_coredump
2022-03-08 12:55:29 -06:00
binfmt_elf_test.c
binfmt_elf: Introduce KUnit test
2022-03-03 20:38:56 -08:00
binfmt_elf.c
revert "fs/binfmt_elf: use PT_LOAD p_align values for static PIE"
2022-04-15 14:49:56 -07:00
binfmt_flat.c
binfmt_flat: Remove shared library support
2022-04-22 10:57:18 -07:00
binfmt_misc.c
Fix regression due to "fs: move binfmt_misc sysctl to its own file"
2022-02-09 09:50:02 -08:00
binfmt_script.c
…
buffer.c
Merge tag 'folio-6.0' of git://git.infradead.org/users/willy/pagecache
2022-08-03 10:35:43 -07:00
char_dev.c
…
compat_binfmt_elf.c
binfmt_elf: Introduce KUnit test
2022-03-03 20:38:56 -08:00
coredump.c
fs: do not compare against ->llseek
2022-07-16 09:19:15 -04:00
d_path.c
d_path: fix Kernel doc validator complaining
2021-11-06 13:30:32 -07:00
dax.c
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
dcache.c
Merge tag 'ceph-for-5.20-rc1' of https://github.com/ceph/ceph-client
2022-08-11 12:41:07 -07:00
direct-io.c
iov_iter: advancing variants of iov_iter_get_pages{,_alloc}()
2022-08-08 22:37:22 -04:00
drop_caches.c
fs: drop_caches: fix skipping over shadow cache inodes
2021-09-03 09:58:10 -07:00
eventfd.c
eventfd: Export eventfd_wake_count to modules
2021-09-06 07:20:56 -04:00
eventpoll.c
epoll: autoremove wakers even more aggressively
2022-07-17 17:31:40 -07:00
exec.c
posix-cpu-timers: Cleanup CPU timers before freeing them during exec
2022-08-09 20:02:13 +02:00
fcntl.c
keep iocb_flags() result cached in struct file
2022-06-10 16:10:23 -04:00
fhandle.c
switch file_open_root() to struct path
2021-04-07 13:56:43 -04:00
file_table.c
locks: fix TOCTOU race when granting write lease
2022-08-16 10:59:54 -04:00
file.c
fix the breakage in close_fd_get_file() calling conventions change
2022-06-05 15:03:03 -04:00
filesystems.c
fs: simplify get_filesystem_list / get_all_fs_names
2021-08-23 01:25:40 -04:00
fs_context.c
vfs: fs_context: fix up param length parsing in legacy_parse_param
2022-01-18 09:23:19 +02:00
fs_parser.c
fs_parse: allow parameter value to be empty
2021-12-09 14:09:36 -05:00
fs_pin.c
…
fs_struct.c
…
fs_types.c
…
fs-writeback.c
writeback: Fix inode->i_io_list not be protected by inode->i_lock error
2022-06-06 09:54:30 +02:00
fsopen.c
uninline may_mount() and don't opencode it in fspick(2)/fsopen(2)
2022-05-19 23:25:10 -04:00
init.c
…
inode.c
Merge tag 'ceph-for-5.20-rc1' of https://github.com/ceph/ceph-client
2022-08-11 12:41:07 -07:00
internal.h
locks: fix TOCTOU race when granting write lease
2022-08-16 10:59:54 -04:00
ioctl.c
Merge tag 'vfs-5.18-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2022-04-01 19:35:56 -07:00
Kconfig
mm: hugetlb_vmemmap: introduce the name HVO
2022-08-08 18:06:42 -07:00
Kconfig.binfmt
Merge tag 'm68knommu-for-v5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu
2022-05-30 10:56:18 -07:00
kernel_read_file.c
fs/kernel_read_file: allow to read files up-to ssize_t
2022-06-16 19:58:21 -07:00
libfs.c
fs: Convert simple_readpage to simple_read_folio
2022-05-09 16:21:44 -04:00
locks.c
fs/lock: Rearrange ops in flock syscall.
2022-07-18 10:01:47 -04:00
Makefile
io_uring: move to separate directory
2022-07-24 18:39:10 -06:00
mbcache.c
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
mount.h
switch try_to_unlazy_next() to __legitimize_mnt()
2022-07-05 16:18:21 -04:00
mpage.c
Merge tag 'folio-6.0' of git://git.infradead.org/users/willy/pagecache
2022-08-03 10:35:43 -07:00
namei.c
Merge tag 'fs.setgid.v6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux
2022-08-09 09:52:28 -07:00
namespace.c
switch try_to_unlazy_next() to __legitimize_mnt()
2022-07-05 16:18:21 -04:00
no-block.c
…
nsfs.c
…
open.c
locks: fix TOCTOU race when granting write lease
2022-08-16 10:59:54 -04:00
pipe.c
Merge tag 'mm-nonmm-stable-2022-05-26' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-05-27 11:22:03 -07:00
pnode.c
…
pnode.h
mount: fix mounting of detached mounts onto targets that reside on shared mounts
2021-03-08 15:18:43 +01:00
posix_acl.c
acl: make posix_acl_clone() available to overlayfs
2022-07-15 22:09:57 +02:00
proc_namespace.c
vfs: escape hash as well
2022-06-28 13:58:05 -04:00
read_write.c
switch new_sync_{read,write}() to ITER_UBUF
2022-08-08 22:37:15 -04:00
readdir.c
readdir: make sure to verify directory entry for legacy interfaces too
2021-04-17 11:39:49 -07:00
remap_range.c
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
select.c
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-11 09:03:05 -08:00
seq_file.c
rxrpc: Fix locking issue
2022-05-22 21:03:01 +01:00
signalfd.c
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
splice.c
iter_to_pipe(): switch to advancing variant of iov_iter_get_pages()
2022-08-08 22:37:23 -04:00
stack.c
…
stat.c
Merge tag 'riscv-for-linus-5.19-mw0' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux
2022-05-31 14:10:54 -07:00
statfs.c
s390,alpha: switch to 64-bit ino_t
2021-02-13 17:17:53 +01:00
super.c
Merge tag 'fuse-update-6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse
2022-08-08 11:10:02 -07:00
sync.c
riscv: compat: syscall: Add compat_sys_call_table implementation
2022-04-26 13:36:25 -07:00
sysctls.c
fs: move namespace sysctls and declare fs base directory
2022-01-22 08:33:36 +02:00
timerfd.c
timerfd: Provide timerfd_resume()
2021-08-10 17:57:22 +02:00
userfaultfd.c
Merge tag 'mm-stable-2022-08-03' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2022-08-05 16:32:45 -07:00
utimes.c
…
xattr.c
acl: move idmapped mount fixup into vfs_{g,s}etxattr()
2022-07-15 22:08:59 +02:00