Eric Dumazet
08f4fc4c85
net: silence data-races on sk_backlog.tail
[ Upstream commit 9ed498c628 ]
sk->sk_backlog.tail might be read without holding the socket spinlock,
we need to add proper READ_ONCE()/WRITE_ONCE() to silence the warnings.
KCSAN reported :
BUG: KCSAN: data-race in tcp_add_backlog / tcp_recvmsg
write to 0xffff8881265109f8 of 8 bytes by interrupt on cpu 1:
__sk_add_backlog include/net/sock.h:907 [inline]
sk_add_backlog include/net/sock.h:938 [inline]
tcp_add_backlog+0x476/0xce0 net/ipv4/tcp_ipv4.c:1759
tcp_v4_rcv+0x1a70/0x1bd0 net/ipv4/tcp_ipv4.c:1947
ip_protocol_deliver_rcu+0x4d/0x420 net/ipv4/ip_input.c:204
ip_local_deliver_finish+0x110/0x140 net/ipv4/ip_input.c:231
NF_HOOK include/linux/netfilter.h:305 [inline]
NF_HOOK include/linux/netfilter.h:299 [inline]
ip_local_deliver+0x133/0x210 net/ipv4/ip_input.c:252
dst_input include/net/dst.h:442 [inline]
ip_rcv_finish+0x121/0x160 net/ipv4/ip_input.c:413
NF_HOOK include/linux/netfilter.h:305 [inline]
NF_HOOK include/linux/netfilter.h:299 [inline]
ip_rcv+0x18f/0x1a0 net/ipv4/ip_input.c:523
__netif_receive_skb_one_core+0xa7/0xe0 net/core/dev.c:4929
__netif_receive_skb+0x37/0xf0 net/core/dev.c:5043
netif_receive_skb_internal+0x59/0x190 net/core/dev.c:5133
napi_skb_finish net/core/dev.c:5596 [inline]
napi_gro_receive+0x28f/0x330 net/core/dev.c:5629
receive_buf+0x284/0x30b0 drivers/net/virtio_net.c:1061
virtnet_receive drivers/net/virtio_net.c:1323 [inline]
virtnet_poll+0x436/0x7d0 drivers/net/virtio_net.c:1428
napi_poll net/core/dev.c:6311 [inline]
net_rx_action+0x3ae/0xa90 net/core/dev.c:6379
__do_softirq+0x115/0x33f kernel/softirq.c:292
invoke_softirq kernel/softirq.c:373 [inline]
irq_exit+0xbb/0xe0 kernel/softirq.c:413
exiting_irq arch/x86/include/asm/apic.h:536 [inline]
do_IRQ+0xa6/0x180 arch/x86/kernel/irq.c:263
ret_from_intr+0x0/0x19
native_safe_halt+0xe/0x10 arch/x86/kernel/paravirt.c:71
arch_cpu_idle+0x1f/0x30 arch/x86/kernel/process.c:571
default_idle_call+0x1e/0x40 kernel/sched/idle.c:94
cpuidle_idle_call kernel/sched/idle.c:154 [inline]
do_idle+0x1af/0x280 kernel/sched/idle.c:263
cpu_startup_entry+0x1b/0x20 kernel/sched/idle.c:355
start_secondary+0x208/0x260 arch/x86/kernel/smpboot.c:264
secondary_startup_64+0xa4/0xb0 arch/x86/kernel/head_64.S:241
read to 0xffff8881265109f8 of 8 bytes by task 8057 on cpu 0:
tcp_recvmsg+0x46e/0x1b40 net/ipv4/tcp.c:2050
inet_recvmsg+0xbb/0x250 net/ipv4/af_inet.c:838
sock_recvmsg_nosec net/socket.c:871 [inline]
sock_recvmsg net/socket.c:889 [inline]
sock_recvmsg+0x92/0xb0 net/socket.c:885
sock_read_iter+0x15f/0x1e0 net/socket.c:967
call_read_iter include/linux/fs.h:1889 [inline]
new_sync_read+0x389/0x4f0 fs/read_write.c:414
__vfs_read+0xb1/0xc0 fs/read_write.c:427
vfs_read fs/read_write.c:461 [inline]
vfs_read+0x143/0x2c0 fs/read_write.c:446
ksys_read+0xd5/0x1b0 fs/read_write.c:587
__do_sys_read fs/read_write.c:597 [inline]
__se_sys_read fs/read_write.c:595 [inline]
__x64_sys_read+0x4c/0x60 fs/read_write.c:595
do_syscall_64+0xcc/0x370 arch/x86/entry/common.c:290
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Reported by Kernel Concurrency Sanitizer on:
CPU: 0 PID: 8057 Comm: syz-fuzzer Not tainted 5.4.0-rc6+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-10-01 13:14:26 +02:00
..
2019-07-03 13:14:42 +02:00
2019-06-25 11:36:01 +08:00
2018-01-19 14:02:12 -05:00
2018-06-28 10:40:47 -07:00
2020-09-09 19:04:25 +02:00
2019-06-17 19:51:56 +02:00
2019-05-16 19:41:27 +02:00
2019-03-23 20:09:51 +01:00
2020-06-30 23:17:05 -04:00
2019-05-04 09:20:18 +02:00
2017-04-12 22:02:36 +02:00
2020-06-03 08:19:15 +02:00
2020-08-11 15:32:34 +02:00
2018-07-13 12:18:18 -04:00
2018-08-03 12:46:20 -07:00
2017-11-02 11:10:55 +01:00
2018-08-07 12:39:13 -07:00
2017-11-02 11:10:55 +01:00
2019-06-11 12:20:57 +02:00
2017-11-02 11:10:55 +01:00
2019-02-23 09:07:27 +01:00
2018-04-19 16:11:11 -04:00
2018-08-04 13:23:15 -07:00
2014-11-10 13:27:49 -05:00
2017-05-27 18:51:41 -04:00
2019-11-12 19:20:26 +01:00
2019-11-10 11:27:39 +01:00
2017-07-04 22:35:16 +01:00
2020-02-05 14:43:46 +00:00
2016-07-08 12:20:57 +02:00
2017-01-20 12:12:13 -05:00
2017-07-04 01:29:04 -07:00
2016-04-19 20:09:25 -04:00
2016-04-25 16:44:27 -04:00
2016-06-25 12:19:35 -04:00
2016-04-25 16:44:27 -04:00
2018-04-02 20:16:17 +02:00
2017-11-02 11:10:55 +01:00
2013-12-06 12:37:56 -05:00
2018-07-27 13:17:50 -07:00
2018-10-10 10:19:10 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-18 12:39:36 +01:00
2017-11-30 09:54:25 -05:00
2017-11-04 09:26:51 +09:00
2018-07-18 15:08:31 -07:00
2017-11-02 11:10:55 +01:00
2018-03-05 12:52:45 -05:00
2017-11-04 09:26:51 +09:00
2020-01-04 19:13:37 +01:00
2020-07-22 09:31:59 +02:00
2018-05-20 18:31:42 -04:00
2017-11-02 11:10:55 +01:00
2018-02-28 11:43:28 -05:00
2018-05-28 22:59:54 -04:00
2017-11-01 11:50:43 +09:00
2020-03-18 07:14:14 +01:00
2017-11-02 11:10:55 +01:00
2020-03-05 16:42:16 +01:00
2018-07-20 10:14:41 +02:00
2017-11-02 11:10:55 +01:00
2019-12-05 09:19:45 +01:00
2019-11-10 11:27:54 +01:00
2017-11-02 11:10:55 +01:00
2018-08-11 12:37:10 -07:00
2020-07-22 09:31:58 +02:00
2017-11-02 11:10:55 +01:00
2018-02-27 14:46:26 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-11 14:10:06 -05:00
2017-11-02 11:10:55 +01:00
2019-03-10 07:17:19 +01:00
2018-06-15 14:04:00 +02:00
2016-01-04 20:40:41 +01:00
2018-05-29 10:12:45 -04:00
2018-04-22 21:12:00 -04:00
2015-12-15 23:25:20 -05:00
2017-01-18 13:04:28 -05:00
2017-08-07 11:39:22 -07:00
2018-06-26 11:33:04 +09:00
2020-09-26 18:01:32 +02:00
2020-07-22 09:32:00 +02:00
2019-04-27 09:36:33 +02:00
2020-01-04 19:13:41 +01:00
2018-10-02 15:52:12 -07:00
2018-06-05 10:45:24 -04:00
2019-02-23 09:07:24 +01:00
2016-03-13 23:55:13 -04:00
2019-06-11 12:20:48 +02:00
2020-04-21 09:03:04 +02:00
2019-07-14 08:11:14 +02:00
2019-01-31 08:14:32 +01:00
2019-01-09 17:38:31 +01:00
2020-08-19 08:14:56 +02:00
2019-12-21 10:57:08 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-07-10 09:53:46 +02:00
2020-04-29 16:31:16 +02:00
2020-02-11 04:34:14 -08:00
2018-03-27 09:51:23 +02:00
2016-08-17 19:36:23 -04:00
2019-02-06 17:30:06 +01:00
2018-07-11 23:10:19 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 12:06:25 +09:00
2013-09-21 14:01:38 -04:00
2014-12-10 15:21:24 -05:00
2019-11-06 13:06:23 +01:00
2013-09-21 14:01:38 -04:00
2014-01-01 22:22:43 -05:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2014-12-10 15:21:24 -05:00
2013-09-21 14:01:38 -04:00
2019-11-20 18:46:35 +01:00
2018-02-14 14:43:32 -05:00
2018-06-18 22:40:32 +02:00
2016-07-08 13:23:12 +02:00
2013-12-06 12:37:56 -05:00
2017-11-02 11:10:55 +01:00
2017-04-01 20:21:44 -07:00
2016-10-03 02:00:22 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-01-09 10:19:09 +01:00
2018-05-28 22:59:54 -04:00
2019-11-10 11:27:42 +01:00
2017-11-02 11:10:55 +01:00
2018-08-01 09:52:30 -07:00
2017-07-01 07:39:09 -07:00
2018-09-29 11:48:26 -07:00
2015-12-08 22:02:33 -05:00
2019-05-02 09:58:57 +02:00
2018-04-07 22:32:31 -04:00
2016-07-08 12:20:57 +02:00
2017-11-08 16:12:33 +09:00
2017-11-02 11:10:55 +01:00
2018-05-24 18:36:15 -07:00
2018-05-16 07:23:35 +02:00
2020-02-01 09:37:06 +00:00
2020-07-22 09:32:00 +02:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2019-09-10 10:33:38 +01:00
2017-11-02 11:10:55 +01:00
2018-05-16 07:23:35 +02:00
2017-11-02 11:10:55 +01:00
2017-12-05 14:37:13 -05:00
2018-08-28 11:11:47 +02:00
2020-01-27 14:51:18 +01:00
2018-05-16 07:23:35 +02:00
2018-05-29 10:12:45 -04:00
2018-03-13 18:37:02 +02:00
2018-05-31 22:48:46 -04:00
2020-02-01 09:37:06 +00:00
2018-07-21 10:43:12 -05:00
2017-11-02 11:10:55 +01:00
2018-06-22 13:43:27 +09:00
2018-07-31 09:22:48 +02:00
2018-06-22 13:43:27 +09:00
2018-04-11 10:33:46 -04:00
2018-06-30 20:42:25 +09:00
2016-04-28 11:49:45 -04:00
2019-09-21 07:16:43 +02:00
2020-10-01 13:14:26 +02:00
2018-03-01 21:21:36 -05:00
2017-11-02 11:10:55 +01:00
2018-06-06 14:07:53 -04:00
2018-05-03 13:46:47 -04:00
2018-02-21 15:06:05 -05:00
2020-05-20 08:18:38 +02:00
2015-07-09 15:12:20 -07:00
2018-05-08 00:02:41 -04:00
2019-07-28 08:29:27 +02:00
2018-07-07 10:58:49 +09:00
2017-11-02 11:10:55 +01:00
2017-08-29 15:16:52 -07:00
2018-06-26 11:33:04 +09:00
2018-07-03 10:29:26 +09:00
2018-02-16 15:57:42 -05:00
2013-07-27 22:14:06 -07:00
2018-04-17 13:53:13 -04:00
2018-01-24 19:13:45 -05:00
2014-09-05 17:35:28 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-05-04 09:20:12 +02:00
2018-08-10 16:12:20 +02:00
2020-08-05 10:06:02 +02:00