Files
linux/include/linux
Eric Dumazet 503c0602a0 net: fix crash in build_skb()
[ Upstream commit 2ea2f62c8b ]

When I added pfmemalloc support in build_skb(), I forgot netlink
was using build_skb() with a vmalloc() area.

In this patch I introduce __build_skb() for netlink use,
and build_skb() is a wrapper handling both skb->head_frag and
skb->pfmemalloc

This means netlink no longer has to hack skb->head_frag

[ 1567.700067] kernel BUG at arch/x86/mm/physaddr.c:26!
[ 1567.700067] invalid opcode: 0000 [#1] PREEMPT SMP KASAN
[ 1567.700067] Dumping ftrace buffer:
[ 1567.700067]    (ftrace buffer empty)
[ 1567.700067] Modules linked in:
[ 1567.700067] CPU: 9 PID: 16186 Comm: trinity-c182 Not tainted 4.0.0-next-20150424-sasha-00037-g4796e21 #2167
[ 1567.700067] task: ffff880127efb000 ti: ffff880246770000 task.ti: ffff880246770000
[ 1567.700067] RIP: __phys_addr (arch/x86/mm/physaddr.c:26 (discriminator 3))
[ 1567.700067] RSP: 0018:ffff8802467779d8  EFLAGS: 00010202
[ 1567.700067] RAX: 000041000ed8e000 RBX: ffffc9008ed8e000 RCX: 000000000000002c
[ 1567.700067] RDX: 0000000000000004 RSI: 0000000000000000 RDI: ffffffffb3fd6049
[ 1567.700067] RBP: ffff8802467779f8 R08: 0000000000000019 R09: ffff8801d0168000
[ 1567.700067] R10: ffff8801d01680c7 R11: ffffed003a02d019 R12: ffffc9000ed8e000
[ 1567.700067] R13: 0000000000000f40 R14: 0000000000001180 R15: ffffc9000ed8e000
[ 1567.700067] FS:  00007f2a7da3f700(0000) GS:ffff8801d1000000(0000) knlGS:0000000000000000
[ 1567.700067] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1567.700067] CR2: 0000000000738308 CR3: 000000022e329000 CR4: 00000000000007e0
[ 1567.700067] Stack:
[ 1567.700067]  ffffc9000ed8e000 ffff8801d0168000 ffffc9000ed8e000 ffff8801d0168000
[ 1567.700067]  ffff880246777a28 ffffffffad7c0a21 0000000000001080 ffff880246777c08
[ 1567.700067]  ffff88060d302e68 ffff880246777b58 ffff880246777b88 ffffffffad9a6821
[ 1567.700067] Call Trace:
[ 1567.700067] build_skb (include/linux/mm.h:508 net/core/skbuff.c:316)
[ 1567.700067] netlink_sendmsg (net/netlink/af_netlink.c:1633 net/netlink/af_netlink.c:2329)
[ 1567.774369] ? sched_clock_cpu (kernel/sched/clock.c:311)
[ 1567.774369] ? netlink_unicast (net/netlink/af_netlink.c:2273)
[ 1567.774369] ? netlink_unicast (net/netlink/af_netlink.c:2273)
[ 1567.774369] sock_sendmsg (net/socket.c:614 net/socket.c:623)
[ 1567.774369] sock_write_iter (net/socket.c:823)
[ 1567.774369] ? sock_sendmsg (net/socket.c:806)
[ 1567.774369] __vfs_write (fs/read_write.c:479 fs/read_write.c:491)
[ 1567.774369] ? get_lock_stats (kernel/locking/lockdep.c:249)
[ 1567.774369] ? default_llseek (fs/read_write.c:487)
[ 1567.774369] ? vtime_account_user (kernel/sched/cputime.c:701)
[ 1567.774369] ? rw_verify_area (fs/read_write.c:406 (discriminator 4))
[ 1567.774369] vfs_write (fs/read_write.c:539)
[ 1567.774369] SyS_write (fs/read_write.c:586 fs/read_write.c:577)
[ 1567.774369] ? SyS_read (fs/read_write.c:577)
[ 1567.774369] ? __this_cpu_preempt_check (lib/smp_processor_id.c:63)
[ 1567.774369] ? trace_hardirqs_on_caller (kernel/locking/lockdep.c:2594 kernel/locking/lockdep.c:2636)
[ 1567.774369] ? trace_hardirqs_on_thunk (arch/x86/lib/thunk_64.S:42)
[ 1567.774369] system_call_fastpath (arch/x86/kernel/entry_64.S:261)

Fixes: 79930f5892 ("net: do not deplete pfmemalloc reserve")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-05-06 21:59:07 +02:00
..
2013-08-14 13:55:15 +05:30
2013-03-01 13:39:00 -08:00
2014-01-20 11:55:23 -08:00
2014-01-24 22:39:54 +01:00
2014-06-30 20:11:58 -07:00
2013-07-30 11:53:12 -04:00
2013-05-29 15:50:34 -04:00
2012-10-08 13:50:20 +10:30
2012-12-02 00:05:12 +00:00
2014-05-06 07:59:36 -07:00
2013-12-22 23:14:27 -08:00
2014-10-30 09:38:24 -07:00
2013-11-15 09:32:21 +09:00
2013-11-09 00:16:29 -05:00
2013-03-12 11:30:04 -07:00
2014-02-13 10:08:52 +05:30
2012-09-30 18:02:20 -07:00
2012-10-16 18:49:15 -07:00
2013-07-15 11:25:00 +09:30
2013-05-07 18:38:27 -07:00
2014-01-16 10:23:02 +10:30
2013-04-29 18:28:40 -07:00
2014-03-10 11:44:42 -04:00
2013-06-17 16:38:57 -07:00
2013-08-22 22:13:54 -07:00
2014-03-10 11:44:42 -04:00
2014-11-14 09:00:06 -08:00
2015-01-29 17:40:52 -08:00
2014-01-16 11:15:50 +01:00
2014-01-26 22:48:35 +01:00
2013-06-13 17:51:04 -07:00
2014-06-26 15:15:39 -04:00
2013-12-29 16:34:25 -05:00
2013-12-10 22:58:13 -08:00
2013-06-17 16:38:57 -07:00
2013-09-13 15:09:52 +02:00
2013-08-09 10:49:00 +02:00
2013-07-26 16:19:48 -07:00
2014-02-25 07:37:52 -08:00
2013-11-15 09:32:23 +09:00
2013-04-30 17:04:06 -07:00
2013-08-28 21:35:14 -07:00
2014-01-08 19:03:00 -02:00
2013-04-01 11:04:50 -07:00
2013-05-31 00:48:22 -07:00
2013-12-11 15:52:34 +01:00
2013-12-26 13:29:35 -05:00
2013-12-19 10:17:11 -07:00
2014-10-09 12:21:29 -07:00
2015-04-29 10:31:55 +02:00
2014-01-16 10:23:03 +10:30
2014-01-27 21:02:39 -08:00
2013-11-09 00:16:19 -05:00
2013-07-03 16:08:05 -07:00
2013-10-14 17:15:48 +02:00
2014-01-25 03:14:05 -05:00
2012-12-11 17:22:27 -08:00
2013-05-04 14:47:26 -04:00
2014-01-27 19:27:53 -05:00
2014-01-13 14:29:49 -08:00
2014-01-03 11:22:21 -08:00
2013-06-12 12:37:30 +01:00
2014-01-22 19:36:57 +01:00
2014-10-09 12:21:27 -07:00
2013-10-17 00:36:06 +02:00
2014-05-31 13:20:28 -07:00
2013-06-21 11:32:51 +02:00
2013-12-18 19:04:50 -08:00
2013-04-12 10:26:23 +02:00
2013-07-03 16:08:05 -07:00
2012-10-06 03:05:01 +09:00
2014-01-28 13:20:09 -08:00
2015-04-29 10:31:54 +02:00
2013-06-17 16:38:57 -07:00
2013-12-19 19:09:38 -05:00
2014-01-27 21:02:39 -08:00
2013-09-10 18:56:32 -04:00
2015-05-06 21:59:07 +02:00
2013-04-30 15:50:12 +05:30
2012-10-09 16:22:32 +09:00
2013-12-08 16:56:05 -08:00
2014-04-26 17:19:04 -07:00
2013-03-20 12:10:38 -04:00
2013-08-05 10:52:36 -06:00
2014-10-09 12:21:29 -07:00
2013-05-27 10:57:53 +09:00
2013-10-17 15:53:09 -04:00
2013-07-10 18:11:34 -07:00
2014-01-30 16:56:55 -08:00