Neil Horman
dd0c46bb0f
bonding: Ensure that we unshare skbs prior to calling pskb_may_pull
commit b30532515f upstream.
Recently reported oops:
kernel BUG at net/core/skbuff.c:813!
invalid opcode: 0000 [#1] SMP
last sysfs file: /sys/devices/virtual/net/bond0/broadcast
CPU 8
Modules linked in: sit tunnel4 cpufreq_ondemand acpi_cpufreq freq_table bonding
ipv6 dm_mirror dm_region_hash dm_log cdc_ether usbnet mii serio_raw i2c_i801
i2c_core iTCO_wdt iTCO_vendor_support shpchp ioatdma i7core_edac edac_core bnx2
ixgbe dca mdio sg ext4 mbcache jbd2 sd_mod crc_t10dif mptsas mptscsih mptbase
scsi_transport_sas dm_mod [last unloaded: microcode]
Modules linked in: sit tunnel4 cpufreq_ondemand acpi_cpufreq freq_table bonding
ipv6 dm_mirror dm_region_hash dm_log cdc_ether usbnet mii serio_raw i2c_i801
i2c_core iTCO_wdt iTCO_vendor_support shpchp ioatdma i7core_edac edac_core bnx2
ixgbe dca mdio sg ext4 mbcache jbd2 sd_mod crc_t10dif mptsas mptscsih mptbase
scsi_transport_sas dm_mod [last unloaded: microcode]
Pid: 0, comm: swapper Not tainted 2.6.32-71.el6.x86_64 #1 BladeCenter HS22
-[7870AC1]-
RIP: 0010:[<ffffffff81405b16>] [<ffffffff81405b16>]
pskb_expand_head+0x36/0x1e0
RSP: 0018:ffff880028303b70 EFLAGS: 00010202
RAX: 0000000000000002 RBX: ffff880c6458ec80 RCX: 0000000000000020
RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff880c6458ec80
RBP: ffff880028303bc0 R08: ffffffff818a6180 R09: ffff880c6458ed64
R10: ffff880c622b36c0 R11: 0000000000000400 R12: 0000000000000000
R13: 0000000000000180 R14: ffff880c622b3000 R15: 0000000000000000
FS: 0000000000000000(0000) GS:ffff880028300000(0000) knlGS:0000000000000000
CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b
CR2: 00000038653452a4 CR3: 0000000001001000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process swapper (pid: 0, threadinfo ffff8806649c2000, task ffff880c64f16ab0)
Stack:
ffff880028303bc0 ffffffff8104fff9 000000000000001c 0000000100000000
<0> ffff880000047d80 ffff880c6458ec80 000000000000001c ffff880c6223da00
<0> ffff880c622b3000 0000000000000000 ffff880028303c10 ffffffff81407f7a
Call Trace:
<IRQ>
[<ffffffff8104fff9>] ? __wake_up_common+0x59/0x90
[<ffffffff81407f7a>] __pskb_pull_tail+0x2aa/0x360
[<ffffffffa0244530>] bond_arp_rcv+0x2c0/0x2e0 [bonding]
[<ffffffff814a0857>] ? packet_rcv+0x377/0x440
[<ffffffff8140f21b>] netif_receive_skb+0x2db/0x670
[<ffffffff8140f788>] napi_skb_finish+0x58/0x70
[<ffffffff8140fc89>] napi_gro_receive+0x39/0x50
[<ffffffffa01286eb>] ixgbe_clean_rx_irq+0x35b/0x900 [ixgbe]
[<ffffffffa01290f6>] ixgbe_clean_rxtx_many+0x136/0x240 [ixgbe]
[<ffffffff8140fe53>] net_rx_action+0x103/0x210
[<ffffffff81073bd7>] __do_softirq+0xb7/0x1e0
[<ffffffff810d8740>] ? handle_IRQ_event+0x60/0x170
[<ffffffff810142cc>] call_softirq+0x1c/0x30
[<ffffffff81015f35>] do_softirq+0x65/0xa0
[<ffffffff810739d5>] irq_exit+0x85/0x90
[<ffffffff814cf915>] do_IRQ+0x75/0xf0
[<ffffffff81013ad3>] ret_from_intr+0x0/0x11
<EOI>
[<ffffffff8101bc01>] ? mwait_idle+0x71/0xd0
[<ffffffff814cd80a>] ? atomic_notifier_call_chain+0x1a/0x20
[<ffffffff81011e96>] cpu_idle+0xb6/0x110
[<ffffffff814c17c8>] start_secondary+0x1fc/0x23f
Resulted from bonding driver registering packet handlers via dev_add_pack and
then trying to call pskb_may_pull. If another packet handler (like for AF_PACKET
sockets) gets called first, the delivered skb will have a user count > 1, which
causes pskb_may_pull to BUG halt when it does its skb_shared check. Fix this by
calling skb_share_check prior to the may_pull call sites in the bonding driver
to clone the skb when needed. Tested by myself and the reported successfully.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Andy Gospodarek <andy@greyhouse.net>
CC: Jay Vosburgh <fubar@us.ibm.com>
CC: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-05-09 15:55:37 -07:00
..
2009-09-11 12:54:23 -07:00
2010-07-05 11:10:28 -07:00
2009-11-29 23:50:32 -08:00
2011-05-09 15:54:51 -07:00
2010-07-05 11:11:09 -07:00
2010-10-28 21:44:03 -07:00
2011-03-02 09:46:45 -05:00
2011-05-09 15:55:37 -07:00
2010-07-05 11:10:40 -07:00
2009-09-01 01:14:07 -07:00
2009-09-24 17:08:56 -07:00
2011-05-09 15:55:02 -07:00
2011-05-09 15:55:35 -07:00
2011-05-09 15:55:35 -07:00
2009-09-24 15:13:11 -07:00
2009-09-03 20:19:25 -07:00
2009-10-14 14:54:52 -07:00
2009-10-11 11:20:58 -07:00
2009-11-18 05:11:09 -08:00
2011-01-07 14:43:13 -08:00
2011-05-09 15:54:50 -07:00
2009-10-15 15:03:17 -07:00
2009-09-01 01:13:52 -07:00
2011-03-14 14:29:54 -07:00
2009-10-13 00:03:11 -07:00
2010-07-05 11:10:51 -07:00
2011-05-09 15:55:02 -07:00
2011-05-09 15:55:01 -07:00
2011-05-09 15:55:03 -07:00
2009-11-17 04:04:40 -08:00
2010-01-28 15:01:48 -08:00
2010-01-28 15:00:31 -08:00
2009-10-11 11:20:58 -07:00
2009-11-23 10:37:52 -08:00
2011-05-09 15:55:04 -07:00
2011-05-09 15:55:14 -07:00
2011-04-22 08:44:13 -07:00
2009-10-16 17:54:34 -07:00
2009-09-21 15:14:58 +02:00
2009-11-30 00:06:51 -08:00
2009-09-11 12:54:55 -07:00
2011-05-09 15:55:32 -07:00
2009-09-30 20:11:11 -07:00
2009-09-01 01:13:50 -07:00
2009-09-01 01:13:50 -07:00
2010-09-26 17:21:36 -07:00
2009-09-01 01:13:50 -07:00
2009-09-01 01:13:50 -07:00
2009-09-01 01:13:50 -07:00
2009-09-01 01:13:50 -07:00
2009-09-01 01:13:50 -07:00
2009-09-01 01:13:50 -07:00
2009-07-05 19:23:38 -07:00
2009-09-22 14:00:15 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-03-27 00:46:54 -07:00
2009-10-12 04:18:48 -07:00
2009-09-01 01:14:07 -07:00
2009-09-03 20:02:11 -07:00
2008-11-25 18:25:32 -08:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-07-05 19:16:04 -07:00
2009-09-01 01:14:07 -07:00
2009-11-22 20:40:52 -08:00
2008-10-08 16:29:57 -07:00
2009-03-24 23:32:03 -07:00
2010-10-28 21:44:13 -07:00
2009-06-15 03:02:23 -07:00
2009-12-18 14:05:43 -08:00
2009-09-17 20:07:53 +02:00
2009-09-02 01:03:33 -07:00
2008-10-08 16:29:57 -07:00
2009-08-12 17:44:53 -07:00
2009-04-04 16:51:14 -07:00
2010-09-26 17:21:32 -07:00
2009-10-28 03:41:59 -07:00
2009-08-12 23:03:00 -07:00
2009-08-12 22:53:28 -07:00
2009-04-27 03:27:43 -07:00
2009-08-12 23:02:12 -07:00
2009-08-12 23:02:59 -07:00
2009-08-12 23:02:59 -07:00
2009-08-12 23:03:01 -07:00
2009-08-12 23:02:57 -07:00
2011-05-09 15:55:01 -07:00
2009-09-21 15:14:54 +02:00
2009-08-12 23:03:01 -07:00
2009-11-06 20:26:09 -08:00
2008-09-22 19:27:10 -07:00
2009-06-09 10:22:42 -05:00
2009-10-02 11:03:28 -07:00
2009-10-28 03:41:59 -07:00
2009-08-15 18:50:44 -07:00
2010-08-02 10:20:44 -07:00
2009-09-01 01:14:07 -07:00
2009-11-20 13:57:54 -08:00
2009-07-05 19:16:04 -07:00
2009-07-05 19:16:04 -07:00
2009-07-05 19:16:04 -07:00
2009-09-01 01:14:07 -07:00
2009-10-11 11:20:58 -07:00
2009-09-01 01:14:07 -07:00
2010-08-02 10:21:25 -07:00
2009-10-24 06:53:07 -07:00
2009-09-01 01:14:07 -07:00
2009-03-11 23:26:02 -07:00
2009-09-01 01:13:40 -07:00
2010-01-06 15:04:38 -08:00
2009-02-17 17:21:08 -08:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2008-12-29 18:42:33 -08:00
2009-09-23 07:39:43 -07:00
2009-09-01 01:14:07 -07:00
2010-09-26 17:21:23 -07:00
2008-11-25 18:23:59 -08:00
2009-09-01 01:14:07 -07:00
2009-10-23 07:34:23 +09:00
2009-10-11 11:20:58 -07:00
2009-09-01 01:14:07 -07:00
2009-10-14 14:54:52 -07:00
2009-10-14 15:10:19 -07:00
2009-10-20 18:51:37 -07:00
2009-07-06 18:56:11 -07:00
2010-08-02 10:21:27 -07:00
2009-11-08 00:49:04 -08:00
2009-02-04 16:42:35 -08:00
2009-09-21 15:14:58 +02:00
2009-02-04 16:43:44 -08:00
2010-12-09 13:27:05 -08:00
2009-06-03 02:43:41 -07:00
2009-10-11 11:20:58 -07:00
2009-10-11 11:20:58 -07:00
2009-02-26 21:02:19 -08:00
2008-11-25 18:24:57 -08:00
2009-04-16 02:20:08 -07:00
2009-09-07 01:56:52 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-01-06 10:47:44 -08:00
2009-10-22 21:54:19 -07:00
2009-07-05 19:16:04 -07:00
2009-09-02 01:03:33 -07:00
2009-06-12 18:01:46 +02:00
2009-07-16 20:21:24 -07:00
2009-10-02 09:55:19 -07:00
2009-08-12 21:54:57 -07:00
2010-12-09 13:26:31 -08:00
2009-07-06 13:05:13 -07:00
2009-11-20 13:53:33 -08:00
2009-09-02 01:03:33 -07:00
2009-09-02 01:03:33 -07:00
2010-03-15 08:49:39 -07:00
2009-10-20 19:11:07 -07:00
2009-10-20 19:11:06 -07:00
2009-09-01 01:14:07 -07:00
2009-05-05 12:29:47 -07:00
2009-09-01 01:14:07 -07:00
2009-07-05 19:16:04 -07:00
2009-09-21 15:14:58 +02:00
2009-04-27 02:53:52 -07:00
2009-04-27 02:53:52 -07:00
2008-11-25 18:24:38 -08:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-07-05 19:16:04 -07:00
2009-06-03 02:43:41 -07:00
2009-09-21 15:14:56 +02:00
2008-10-08 16:29:57 -07:00
2009-07-05 19:16:04 -07:00
2009-04-16 02:20:16 -07:00
2009-11-06 20:26:10 -08:00
2009-11-23 14:18:53 -08:00
2009-10-14 15:13:45 -07:00
2009-09-03 20:02:11 -07:00
2009-10-01 14:34:40 -07:00
2009-09-03 20:02:11 -07:00
2009-07-05 19:16:04 -07:00
2009-09-11 12:54:49 -07:00
2009-04-16 02:20:21 -07:00
2009-07-05 19:16:04 -07:00
2008-08-29 02:13:32 -07:00
2009-09-03 20:02:11 -07:00
2008-11-28 15:55:00 -08:00
2009-05-03 14:19:23 -07:00
2009-05-01 15:21:55 -07:00
2009-01-11 00:06:36 -08:00
2009-07-08 10:30:03 -07:00
2009-05-01 15:24:18 -07:00
2011-05-09 15:55:03 -07:00
2009-09-21 15:14:58 +02:00
2009-09-01 01:14:07 -07:00
2009-07-05 19:16:04 -07:00
2009-10-21 17:21:10 -07:00
2009-06-12 18:01:45 +02:00
2009-10-11 11:20:58 -07:00
2009-10-07 03:37:43 -07:00
2009-04-27 03:20:17 -07:00
2009-04-27 02:53:49 -07:00
2009-09-03 20:02:11 -07:00
2009-10-11 11:20:58 -07:00
2009-07-16 20:21:24 -07:00
2009-07-16 09:14:23 -07:00
2009-11-16 23:51:34 -08:00
2008-08-14 04:26:38 -04:00
2009-07-16 09:14:23 -07:00
2009-10-26 16:23:20 -07:00
2010-07-05 11:11:15 -07:00
2009-01-21 15:55:15 -08:00
2009-09-02 01:03:33 -07:00
2009-09-02 01:03:33 -07:00
2008-11-10 15:11:56 -05:00
2009-09-01 01:14:07 -07:00
2008-08-07 02:11:14 -04:00
2010-10-28 21:44:12 -07:00
2011-03-14 14:29:59 -07:00
2009-09-21 15:14:54 +02:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-04-29 17:32:34 -07:00
2009-11-13 19:56:53 -08:00
2009-08-30 22:35:11 -07:00
2009-08-02 12:20:40 -07:00
2009-10-11 11:20:58 -07:00
2009-07-23 18:01:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-10-01 14:34:43 -07:00
2009-10-26 17:19:44 -07:00
2009-08-29 00:19:35 -07:00
2009-09-01 01:14:07 -07:00
2009-10-11 11:20:58 -07:00
2010-10-28 21:44:11 -07:00
2009-10-01 15:14:54 -07:00
2010-08-02 10:20:44 -07:00
2009-10-01 15:14:55 -07:00
2009-10-11 11:20:58 -07:00
2009-01-06 11:28:06 +01:00
2009-11-29 23:47:14 -08:00
2009-09-17 20:53:52 -07:00
2009-07-05 19:16:04 -07:00
2009-08-12 22:13:16 -07:00
2009-09-01 01:14:07 -07:00
2009-05-01 15:21:55 -07:00
2009-03-27 00:46:47 -07:00
2009-03-27 00:46:48 -07:00
2010-08-13 13:19:39 -07:00
2009-03-19 23:59:27 -07:00
2009-11-29 23:14:45 -08:00
2009-02-20 00:38:51 -08:00
2009-07-05 19:23:38 -07:00
2008-11-12 23:38:36 -08:00
2008-11-12 23:38:36 -08:00
2011-05-09 15:55:04 -07:00
2010-02-09 04:51:00 -08:00
2008-11-25 18:25:49 -08:00
2009-07-05 19:16:04 -07:00
2009-07-05 19:16:04 -07:00
2009-07-05 19:16:04 -07:00
2008-08-29 02:13:33 -07:00
2009-09-01 01:14:07 -07:00
2009-02-02 23:19:50 -08:00
2009-11-18 14:54:45 -08:00
2009-09-01 01:14:07 -07:00
2008-08-29 02:14:29 -07:00
2009-07-05 19:16:04 -07:00
2009-07-05 19:16:04 -07:00
2008-08-29 02:14:43 -07:00
2009-09-22 14:00:09 -07:00
2009-08-06 13:14:25 -07:00
2009-09-02 01:03:33 -07:00
2009-04-07 08:31:11 -07:00
2010-05-12 14:57:13 -07:00
2010-04-01 15:58:05 -07:00
2009-09-03 20:02:11 -07:00
2009-07-08 10:30:03 -07:00
2010-09-20 13:17:50 -07:00
2009-10-11 11:20:58 -07:00
2009-01-21 14:34:08 -08:00
2009-08-30 21:51:47 -07:00
2010-07-05 11:11:16 -07:00
2009-08-30 21:51:47 -07:00
2009-11-19 13:16:22 -08:00
2010-03-15 08:49:43 -07:00
2010-07-05 11:11:09 -07:00
2009-07-23 18:11:28 -07:00
2011-05-09 15:55:21 -07:00
2009-01-11 00:06:36 -08:00
2010-08-13 13:19:49 -07:00
2009-09-22 14:00:04 -07:00
2009-07-23 18:01:08 -07:00
2009-09-03 20:02:11 -07:00
2009-10-07 22:15:23 -07:00
2009-08-09 21:46:53 -07:00