Paul E. McKenney
abfa9c47ec
mm/mmap.c: Add cond_resched() for exit_mmap() CPU stalls
[ Upstream commit 0a3b3c253a ]
A large process running on a heavily loaded system can encounter the
following RCU CPU stall warning:
rcu: INFO: rcu_sched self-detected stall on CPU
rcu: 3-....: (20998 ticks this GP) idle=4ea/1/0x4000000000000002 softirq=556558/556558 fqs=5190
(t=21013 jiffies g=1005461 q=132576)
NMI backtrace for cpu 3
CPU: 3 PID: 501900 Comm: aio-free-ring-w Kdump: loaded Not tainted 5.2.9-108_fbk12_rc3_3858_gb83b75af7909 #1
Hardware name: Wiwynn HoneyBadger/PantherPlus, BIOS HBM6.71 02/03/2016
Call Trace:
<IRQ>
dump_stack+0x46/0x60
nmi_cpu_backtrace.cold.3+0x13/0x50
? lapic_can_unplug_cpu.cold.27+0x34/0x34
nmi_trigger_cpumask_backtrace+0xba/0xca
rcu_dump_cpu_stacks+0x99/0xc7
rcu_sched_clock_irq.cold.87+0x1aa/0x397
? tick_sched_do_timer+0x60/0x60
update_process_times+0x28/0x60
tick_sched_timer+0x37/0x70
__hrtimer_run_queues+0xfe/0x270
hrtimer_interrupt+0xf4/0x210
smp_apic_timer_interrupt+0x5e/0x120
apic_timer_interrupt+0xf/0x20
</IRQ>
RIP: 0010:kmem_cache_free+0x223/0x300
Code: 88 00 00 00 0f 85 ca 00 00 00 41 8b 55 18 31 f6 f7 da 41 f6 45 0a 02 40 0f 94 c6 83 c6 05 9c 41 5e fa e8 a0 a7 01 00 41 56 9d <49> 8b 47 08 a8 03 0f 85 87 00 00 00 65 48 ff 08 e9 3d fe ff ff 65
RSP: 0018:ffffc9000e8e3da8 EFLAGS: 00000206 ORIG_RAX: ffffffffffffff13
RAX: 0000000000020000 RBX: ffff88861b9de960 RCX: 0000000000000030
RDX: fffffffffffe41e8 RSI: 000060777fe3a100 RDI: 000000000001be18
RBP: ffffea00186e7780 R08: ffffffffffffffff R09: ffffffffffffffff
R10: ffff88861b9dea28 R11: ffff88887ffde000 R12: ffffffff81230a1f
R13: ffff888854684dc0 R14: 0000000000000206 R15: ffff8888547dbc00
? remove_vma+0x4f/0x60
remove_vma+0x4f/0x60
exit_mmap+0xd6/0x160
mmput+0x4a/0x110
do_exit+0x278/0xae0
? syscall_trace_enter+0x1d3/0x2b0
? handle_mm_fault+0xaa/0x1c0
do_group_exit+0x3a/0xa0
__x64_sys_exit_group+0x14/0x20
do_syscall_64+0x42/0x100
entry_SYSCALL_64_after_hwframe+0x44/0xa9
And on a PREEMPT=n kernel, the "while (vma)" loop in exit_mmap() can run
for a very long time given a large process. This commit therefore adds
a cond_resched() to this loop, providing RCU any needed quiescent states.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-08-19 08:14:52 +02:00
..
2018-08-17 16:20:30 -07:00
2019-03-05 17:58:50 +01:00
2017-11-14 23:57:38 +02:00
2018-08-02 12:17:27 -06:00
2018-06-15 07:55:25 +09:00
2019-06-15 11:54:01 +02:00
2019-08-06 19:06:51 +02:00
2017-11-02 11:10:55 +01:00
2019-10-05 13:10:13 +02:00
2017-11-02 11:10:55 +01:00
2018-09-13 15:18:04 -10:00
2018-06-15 07:55:25 +09:00
2017-12-11 14:54:44 +01:00
2018-08-30 20:01:32 +02:00
2018-06-15 07:55:25 +09:00
2019-11-12 19:21:20 +01:00
2017-12-14 16:00:48 -08:00
2018-06-15 07:55:25 +09:00
2019-12-01 09:17:07 +01:00
2019-07-31 07:27:08 +02:00
2017-11-02 11:10:55 +01:00
2020-01-29 16:43:27 +01:00
2020-06-22 09:05:21 +02:00
2019-11-20 18:45:20 +01:00
2020-04-29 16:31:27 +02:00
2018-01-23 12:17:42 -06:00
2018-07-17 09:35:30 +02:00
2019-12-05 09:20:57 +01:00
2018-01-31 17:18:37 -08:00
2019-06-15 11:54:00 +02:00
2018-08-22 10:52:44 -07:00
2019-06-22 08:15:21 +02:00
2016-03-17 15:09:34 -07:00
2019-08-25 10:47:58 +02:00
2020-04-29 16:31:28 +02:00
2019-06-19 08:17:59 +02:00
2018-02-06 18:32:48 -08:00
2018-10-05 16:32:05 -07:00
2018-08-30 20:01:32 +02:00
2019-12-05 09:20:58 +01:00
2020-07-29 10:16:57 +02:00
2019-11-20 18:47:53 +01:00
2020-02-11 04:33:56 -08:00
2019-10-29 09:19:59 +01:00
2019-12-17 20:35:45 +01:00
2020-04-13 10:45:06 +02:00
2018-08-22 10:52:44 -07:00
2017-11-02 11:10:55 +01:00
2020-02-11 04:33:56 -08:00
2019-05-22 07:37:40 +02:00
2019-07-10 09:53:40 +02:00
2018-08-22 10:52:45 -07:00
2020-08-19 08:14:52 +02:00
2017-03-02 08:42:38 +01:00
2019-07-31 07:27:08 +02:00
2017-11-02 11:10:55 +01:00
2020-03-11 14:15:00 +01:00
2020-06-07 13:17:53 +02:00
2017-11-02 11:10:55 +01:00
2018-08-02 12:17:27 -06:00
2020-03-25 08:06:13 +01:00
2019-10-05 13:10:07 +02:00
2020-06-22 09:05:21 +02:00
2018-06-07 17:34:36 -07:00
2019-04-05 22:32:58 +02:00
2019-07-03 13:14:45 +02:00
2019-12-01 09:17:35 +01:00
2018-04-11 10:28:32 -07:00
2019-10-29 09:19:58 +01:00
2019-04-05 22:32:59 +02:00
2018-11-13 11:08:46 -08:00
2020-01-23 08:21:31 +01:00
2018-04-05 21:36:27 -07:00
2017-11-02 11:10:55 +01:00
2019-02-12 19:47:12 +01:00
2018-06-12 16:19:22 -07:00
2018-02-18 05:33:01 -08:00
2019-06-15 11:54:11 +02:00
2018-01-31 17:18:38 -08:00
2018-02-06 18:32:48 -08:00
2017-11-02 11:10:55 +01:00
2018-08-30 20:01:32 +02:00
2019-08-25 10:47:43 +02:00
2017-10-03 17:54:24 -07:00
2020-05-20 08:18:32 +02:00
2020-07-29 10:16:57 +02:00
2019-06-15 11:54:01 +02:00
2019-04-03 06:26:28 +02:00
2018-06-07 17:34:34 -07:00
2020-07-09 09:37:09 +02:00
2018-08-17 16:20:32 -07:00
2020-01-29 16:43:26 +01:00
2017-11-02 11:10:55 +01:00
2018-08-22 10:52:44 -07:00
2020-07-09 09:37:09 +02:00
2019-07-31 07:27:03 +02:00
2019-04-05 22:32:58 +02:00
2018-12-05 19:32:13 +01:00
2019-10-11 18:20:58 +02:00
2019-05-22 07:37:40 +02:00
2020-06-22 09:05:01 +02:00
2018-09-13 15:18:04 -10:00
2020-06-03 08:19:49 +02:00
2019-10-17 13:45:19 -07:00
2020-02-28 16:38:50 +01:00
2019-12-13 08:51:27 +01:00
2018-08-17 16:20:32 -07:00
2018-12-01 09:37:33 +01:00
2018-02-06 18:32:48 -08:00
2018-02-21 15:35:43 -08:00
2020-01-09 10:19:00 +01:00
2018-07-26 19:38:03 -07:00