Files
linux/include/linux
Jens Wiklander 492eb7afe8 tee: handle lookup of shm with reference count 0
commit dfd0743f1d upstream.

Since the tee subsystem does not keep a strong reference to its idle
shared memory buffers, it races with other threads that try to destroy a
shared memory through a close of its dma-buf fd or by unmapping the
memory.

In tee_shm_get_from_id() when a lookup in teedev->idr has been
successful, it is possible that the tee_shm is in the dma-buf teardown
path, but that path is blocked by the teedev mutex. Since we don't have
an API to tell if the tee_shm is in the dma-buf teardown path or not we
must find another way of detecting this condition.

Fix this by doing the reference counting directly on the tee_shm using a
new refcount_t refcount field. dma-buf is replaced by using
anon_inode_getfd() instead, this separates the life-cycle of the
underlying file from the tee_shm. tee_shm_put() is updated to hold the
mutex when decreasing the refcount to 0 and then remove the tee_shm from
teedev->idr before releasing the mutex. This means that the tee_shm can
never be found unless it has a refcount larger than 0.

Fixes: 967c9cca2c ("tee: generic TEE subsystem")
Cc: stable@vger.kernel.org
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Lars Persson <larper@axis.com>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Reported-by: Patrik Lantz <patrik.lantz@axis.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-12-29 12:28:54 +01:00
..
2021-09-02 22:49:16 +02:00
2021-07-21 19:54:21 -07:00
2021-02-02 00:16:57 +01:00
2021-09-20 12:43:34 +01:00
2021-06-03 14:04:18 -07:00
2020-06-16 14:19:57 +02:00
2021-01-23 14:57:21 +01:00
2021-08-29 14:47:42 +03:00
2021-05-06 19:24:11 -07:00
2021-10-07 16:51:57 +02:00
2021-04-14 16:30:30 +03:00
2021-05-24 21:13:05 -07:00
2021-08-16 10:50:32 -06:00
2021-01-24 14:27:17 +01:00
2021-02-26 09:41:03 -08:00
2021-04-08 16:04:20 -07:00
2021-09-08 15:32:35 -07:00
2021-01-21 14:06:00 -07:00
2021-08-26 16:52:03 -07:00
2021-12-14 10:57:11 +01:00
2021-11-25 09:48:41 +01:00
2021-07-20 09:20:49 -07:00
2021-09-07 21:17:28 +02:00
2021-03-22 03:57:39 +01:00
2021-08-26 15:32:28 -04:00
2020-12-10 12:42:59 -06:00
2021-07-27 11:00:36 +02:00
2021-09-06 07:20:56 -04:00
2021-04-12 15:04:23 +02:00
2020-11-16 16:31:41 +01:00
2021-11-25 09:49:08 +01:00
2021-06-25 19:57:01 -04:00
2021-07-26 15:09:44 +02:00
2021-07-27 20:11:45 +01:00
2021-07-27 20:11:44 +01:00
2021-09-03 09:58:13 -07:00
2020-07-24 17:12:41 -07:00
2021-02-11 13:24:44 -08:00
2021-08-05 11:46:42 +01:00
2020-08-04 21:02:38 -04:00
2020-12-02 22:10:35 -08:00
2021-04-30 11:20:40 -07:00
2020-11-23 14:16:55 +00:00
2021-08-16 21:26:33 -07:00
2020-09-16 08:54:53 -05:00
2020-11-24 16:47:48 +01:00
2021-07-15 10:13:49 -07:00
2021-07-27 17:05:06 +01:00
2021-08-19 09:02:55 +09:00
2021-07-27 09:29:15 +02:00
2021-01-21 16:16:10 +00:00
2021-06-01 10:29:21 +01:00
2021-02-26 09:41:03 -08:00
2020-09-04 09:25:20 -07:00
2021-09-23 11:01:12 -04:00
2021-11-18 19:15:51 +01:00
2021-05-12 20:11:17 +02:00
2021-06-17 13:09:27 -04:00
2021-06-15 17:46:57 +02:00
2021-07-01 11:06:02 -07:00
2021-06-29 10:53:53 -07:00
2021-07-01 11:06:05 -07:00
2021-08-23 13:19:12 +02:00
2021-11-18 19:17:02 +01:00
2020-07-01 10:49:02 +02:00
2021-09-17 13:52:17 +01:00
2021-02-26 09:40:59 -08:00
2021-02-03 19:05:50 +01:00
2021-06-16 17:20:40 -05:00
2021-07-06 10:37:46 -05:00
2020-08-31 12:52:33 -07:00
2021-07-20 06:55:20 -07:00
2021-06-07 14:11:47 -07:00
2021-01-24 14:27:17 +01:00
2021-08-18 22:08:24 +02:00
2021-03-06 12:40:22 +01:00
2021-02-26 09:41:03 -08:00
2021-09-02 21:38:56 +02:00
2021-10-07 16:51:57 +02:00
2020-12-03 11:20:52 +01:00
2021-01-16 23:19:26 +01:00
2021-08-17 17:50:51 +02:00
2021-03-18 12:58:27 -04:00
2020-12-10 16:17:15 +01:00
2020-12-10 10:45:36 +01:00
2021-05-10 16:03:35 -07:00
2021-08-06 13:41:48 -07:00
2021-08-19 09:02:55 +09:00
2021-06-24 15:49:32 +02:00
2021-11-21 13:44:12 +01:00
2021-07-01 11:06:03 -07:00
2020-10-30 21:57:04 +01:00
2021-07-27 12:17:21 +02:00
2021-07-27 12:12:08 +02:00
2021-02-13 17:17:53 +01:00
2021-09-08 15:32:35 -07:00
2021-03-30 17:06:49 -07:00
2020-11-09 18:39:36 +01:00
2021-09-15 09:22:35 -06:00
2020-07-04 09:35:36 -05:00
2020-09-10 14:03:31 -07:00
2020-08-19 14:13:20 +02:00
2021-01-21 16:16:10 +00:00
2021-08-10 11:50:55 -04:00
2021-02-09 12:15:07 +01:00
2021-08-11 06:44:24 -04:00
2021-01-21 14:06:00 -07:00
2021-12-14 10:57:15 +01:00
2021-03-30 13:42:33 -04:00
2021-01-24 14:27:17 +01:00
2021-02-08 22:58:55 +01:00