Files
linux/kernel
Alexei Starovoitov c9eae09f78 bpf: convert htab map to hlist_nulls
commit 4fe8435909 upstream.

when all map elements are pre-allocated one cpu can delete and reuse htab_elem
while another cpu is still walking the hlist. In such case the lookup may
miss the element. Convert hlist to hlist_nulls to avoid such scenario.
When bucket lock is taken there is no need to take such precautions,
so only convert map_lookup and map_get_next to nulls.
The race window is extremely small and only reproducible with explicit
udelay() inside lookup_nulls_elem_raw()

Similar to hlist add hlist_nulls_for_each_entry_safe() and
hlist_nulls_entry_safe() helpers.

Fixes: 6c90598174 ("bpf: pre-allocate hash map elements")
Reported-by: Jonathan Perry <jonperry@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chenbo Feng <fengc@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-05-15 12:49:02 +09:00
..
2023-05-15 12:49:02 +09:00
2017-09-02 07:07:53 +02:00
2023-05-15 12:47:12 +09:00
2016-01-22 18:04:28 -05:00
2016-04-04 09:46:47 -04:00
2018-05-01 16:49:34 +00:00
2017-10-12 22:31:24 +02:00
2015-04-12 21:03:31 +02:00
2023-05-15 10:54:38 +09:00
2015-11-23 09:44:58 +01:00
2023-05-12 16:39:07 +09:00
2016-02-16 13:04:58 -05:00
2017-05-20 14:28:40 +02:00
2016-03-01 20:36:56 +01:00
2023-05-12 16:43:35 +09:00
2018-05-09 09:50:20 +02:00
2018-04-03 11:15:30 -07:00
2016-09-22 20:00:36 -05:00
2018-05-09 19:39:28 -07:00
2018-05-09 19:39:28 -07:00