Files
linux/kernel
Marco Elver 0c78dc6cbd perf: Fix data race between pin_count increment/decrement
commit 6c605f8371 upstream.

KCSAN reports a data race between increment and decrement of pin_count:

  write to 0xffff888237c2d4e0 of 4 bytes by task 15740 on cpu 1:
   find_get_context		kernel/events/core.c:4617
   __do_sys_perf_event_open	kernel/events/core.c:12097 [inline]
   __se_sys_perf_event_open	kernel/events/core.c:11933
   ...
  read to 0xffff888237c2d4e0 of 4 bytes by task 15743 on cpu 0:
   perf_unpin_context		kernel/events/core.c:1525 [inline]
   __do_sys_perf_event_open	kernel/events/core.c:12328 [inline]
   __se_sys_perf_event_open	kernel/events/core.c:11933
   ...

Because neither read-modify-write here is atomic, this can lead to one
of the operations being lost, resulting in an inconsistent pin_count.
Fix it by adding the missing locking in the CPU-event case.

Fixes: fe4b04fa31 ("perf: Cure task_oncpu_function_call() races")
Reported-by: syzbot+142c9018f5962db69c7e@syzkaller.appspotmail.com
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20210527104711.2671610-1-elver@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-06-16 11:36:35 +02:00
..
2020-09-23 08:46:14 +02:00
2016-01-22 18:04:28 -05:00
2016-04-04 09:46:47 -04:00
2019-11-28 18:28:55 +01:00
2021-06-16 11:36:34 +02:00
2015-04-12 21:03:31 +02:00
2015-11-23 09:44:58 +01:00
2018-08-03 07:55:12 +02:00
2021-02-10 09:09:25 +01:00
2020-04-02 17:20:26 +02:00
2016-02-16 13:04:58 -05:00
2020-04-24 07:58:54 +02:00
2016-03-01 20:36:56 +01:00
2018-08-03 07:55:24 +02:00
2020-01-12 11:24:12 +01:00
2016-09-22 20:00:36 -05:00