Alexey Kodanev
35d889d10b
sch_netem: fix skb leak in netem_enqueue()
...
When we exceed current packets limit and we have more than one
segment in the list returned by skb_gso_segment(), netem drops
only the first one, skipping the rest, hence kmemleak reports:
unreferenced object 0xffff880b5d23b600 (size 1024):
comm "softirq", pid 0, jiffies 4384527763 (age 2770.629s)
hex dump (first 32 bytes):
00 80 23 5d 0b 88 ff ff 00 00 00 00 00 00 00 00 ..#]............
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<00000000d8a19b9d>] __alloc_skb+0xc9/0x520
[<000000001709b32f>] skb_segment+0x8c8/0x3710
[<00000000c7b9bb88>] tcp_gso_segment+0x331/0x1830
[<00000000c921cba1>] inet_gso_segment+0x476/0x1370
[<000000008b762dd4>] skb_mac_gso_segment+0x1f9/0x510
[<000000002182660a>] __skb_gso_segment+0x1dd/0x620
[<00000000412651b9>] netem_enqueue+0x1536/0x2590 [sch_netem]
[<0000000005d3b2a9>] __dev_queue_xmit+0x1167/0x2120
[<00000000fc5f7327>] ip_finish_output2+0x998/0xf00
[<00000000d309e9d3>] ip_output+0x1aa/0x2c0
[<000000007ecbd3a4>] tcp_transmit_skb+0x18db/0x3670
[<0000000042d2a45f>] tcp_write_xmit+0x4d4/0x58c0
[<0000000056a44199>] tcp_tasklet_func+0x3d9/0x540
[<0000000013d06d02>] tasklet_action+0x1ca/0x250
[<00000000fcde0b8b>] __do_softirq+0x1b4/0x5a3
[<00000000e7ed027c>] irq_exit+0x1e2/0x210
Fix it by adding the rest of the segments, if any, to skb 'to_free'
list. Add new __qdisc_drop_all() and qdisc_drop_all() functions
because they can be useful in the future if we need to drop segmented
GSO packets in other places.
Fixes: 6071bd1aa1 ("netem: Segment GSO packets on enqueue")
Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com >
Acked-by: Neil Horman <nhorman@tuxdriver.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2018-03-07 11:18:14 -05:00
..
2017-07-11 06:08:58 -04:00
2017-11-27 16:20:04 -05:00
2018-01-19 14:02:12 -05:00
2017-11-27 16:20:04 -05:00
2018-02-07 11:55:52 +01:00
2018-01-21 11:35:34 -05:00
2017-04-05 10:15:20 +02:00
2017-10-07 23:15:08 +01:00
2018-02-03 16:25:42 -08:00
2018-01-23 19:51:46 -05:00
2017-04-12 22:02:36 +02:00
2017-12-13 13:58:41 -05:00
2017-12-04 13:35:36 -05:00
2015-09-17 13:20:05 +02:00
2017-10-18 11:42:48 +01:00
2017-11-02 11:10:55 +01:00
2017-10-05 18:44:17 -07:00
2017-11-02 11:10:55 +01:00
2018-01-15 14:53:43 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-02-09 04:45:49 -05:00
2014-11-10 13:27:49 -05:00
2017-05-27 18:51:41 -04:00
2017-10-25 10:54:39 +09:00
2017-08-11 14:59:24 -07:00
2017-07-04 22:35:16 +01:00
2011-08-08 14:26:29 -04:00
2018-01-17 00:10:42 -05:00
2016-07-08 12:20:57 +02:00
2017-01-20 12:12:13 -05:00
2017-07-04 01:29:04 -07:00
2016-04-19 20:09:25 -04:00
2016-04-25 16:44:27 -04:00
2016-06-25 12:19:35 -04:00
2016-04-25 16:44:27 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2013-12-06 12:37:56 -05:00
2015-03-06 21:50:02 -05:00
2018-02-28 12:32:36 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-18 12:39:36 +01:00
2017-11-30 09:54:25 -05:00
2017-11-04 09:26:51 +09:00
2017-12-07 14:14:54 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-04 09:26:51 +09:00
2017-11-02 11:10:55 +01:00
2018-01-29 10:15:51 -05:00
2018-02-06 11:32:48 -05:00
2017-11-02 11:10:55 +01:00
2015-09-23 15:33:15 -07:00
2017-11-01 11:50:43 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-11 15:36:05 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-30 21:09:24 +09:00
2017-10-11 09:49:34 +02:00
2017-11-02 11:10:55 +01:00
2017-12-08 13:32:26 -05:00
2017-11-16 10:49:00 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-11 14:10:06 -05:00
2017-11-02 11:10:55 +01:00
2016-04-27 22:48:25 -04:00
2017-01-25 16:00:33 +01:00
2016-01-04 20:40:41 +01:00
2017-07-04 01:29:04 -07:00
2017-11-02 11:10:55 +01:00
2015-12-15 23:25:20 -05:00
2017-01-18 13:04:28 -05:00
2017-08-07 11:39:22 -07:00
2017-11-02 11:10:55 +01:00
2018-02-11 14:34:03 -08:00
2017-11-04 09:26:51 +09:00
2017-11-04 09:26:51 +09:00
2017-12-03 10:18:28 -05:00
2017-12-20 14:00:25 -05:00
2017-12-13 14:33:10 -05:00
2017-11-02 11:10:55 +01:00
2016-03-13 23:55:13 -04:00
2018-01-10 15:14:44 -05:00
2018-01-10 15:14:44 -05:00
2017-12-15 12:34:00 -05:00
2017-09-29 06:19:32 +01:00
2017-12-15 12:34:00 -05:00
2018-01-08 18:01:02 +01:00
2017-12-16 22:11:55 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-01-24 23:44:15 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-08-17 19:36:23 -04:00
2016-10-13 12:05:26 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 12:06:25 +09:00
2013-09-21 14:01:38 -04:00
2014-12-10 15:21:24 -05:00
2015-05-11 10:50:17 -04:00
2013-09-21 14:01:38 -04:00
2014-01-01 22:22:43 -05:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2014-12-10 15:21:24 -05:00
2013-09-21 14:01:38 -04:00
2017-07-04 22:35:15 +01:00
2017-11-02 11:10:55 +01:00
2018-02-22 15:17:01 -05:00
2016-07-08 13:23:12 +02:00
2013-12-06 12:37:56 -05:00
2017-11-02 11:10:55 +01:00
2017-04-01 20:21:44 -07:00
2016-10-03 02:00:22 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-04 09:26:51 +09:00
2018-01-29 10:15:51 -05:00
2017-11-02 11:10:55 +01:00
2017-11-04 09:26:51 +09:00
2017-07-01 07:39:09 -07:00
2017-11-02 11:10:55 +01:00
2015-12-08 22:02:33 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-07-08 12:20:57 +02:00
2017-11-08 16:12:33 +09:00
2017-11-02 11:10:55 +01:00
2016-03-23 22:09:58 -04:00
2018-01-25 21:23:07 -05:00
2018-01-16 14:56:54 -05:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-07 11:39:21 -07:00
2017-11-02 11:10:55 +01:00
2017-12-05 14:37:13 -05:00
2018-02-22 20:57:48 +01:00
2017-10-20 13:21:36 +01:00
2017-11-02 11:10:55 +01:00
2018-01-24 19:13:45 -05:00
2017-12-04 11:32:53 -05:00
2018-03-07 11:18:14 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-11-09 20:40:06 -05:00
2017-08-25 17:10:23 -07:00
2017-11-02 11:10:55 +01:00
2016-04-28 11:49:45 -04:00
2017-11-02 11:10:55 +01:00
2018-02-03 16:25:42 -08:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 10:37:11 +09:00
2017-11-10 13:41:40 +09:00
2015-03-12 22:58:12 -04:00
2018-02-06 11:39:32 +01:00
2015-07-09 15:12:20 -07:00
2017-11-11 15:36:05 +09:00
2018-01-31 10:26:30 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-29 15:16:52 -07:00
2017-11-02 11:10:55 +01:00
2017-11-27 16:20:04 -05:00
2018-02-16 15:57:42 -05:00
2013-07-27 22:14:06 -07:00
2018-01-17 16:07:24 -05:00
2018-01-24 19:13:45 -05:00
2014-09-05 17:35:28 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-01-05 15:21:21 -08:00
2018-01-18 10:42:59 +01:00