Chao Yu
f0145860c2
f2fs: fix to avoid dirent corruption
...
[ Upstream commit 53edb549565f55ccd0bdf43be3d66ce4c2d48b28 ]
As Al reported in link[1]:
f2fs_rename()
...
if (old_dir != new_dir && !whiteout)
f2fs_set_link(old_inode, old_dir_entry,
old_dir_page, new_dir);
else
f2fs_put_page(old_dir_page, 0);
You want correct inumber in the ".." link. And cross-directory
rename does move the source to new parent, even if you'd been asked
to leave a whiteout in the old place.
[1] https://lore.kernel.org/all/20231017055040.GN800259@ZenIV/
With below testcase, it may cause dirent corruption, due to it missed
to call f2fs_set_link() to update ".." link to new directory.
- mkdir -p dir/foo
- renameat2 -w dir/foo bar
[ASSERT] (__chk_dots_dentries:1421) --> Bad inode number[0x4] for '..', parent parent ino is [0x3]
[FSCK] other corrupted bugs [Fail]
Fixes: 7e01e7ad74 ("f2fs: support RENAME_WHITEOUT")
Cc: Jan Kara <jack@suse.cz >
Reported-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: Chao Yu <chao@kernel.org >
Reviewed-by: Jan Kara <jack@suse.cz >
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2024-01-25 15:27:32 -08:00
..
2024-01-10 17:10:31 +01:00
2022-05-09 16:21:44 -04:00
2023-02-01 08:34:08 +01:00
2024-01-10 17:10:31 +01:00
2023-09-23 11:10:59 +02:00
2022-08-02 12:34:03 -04:00
2022-05-09 16:21:44 -04:00
2024-01-10 17:10:35 +01:00
2024-01-10 17:10:31 +01:00
2024-01-10 17:10:31 +01:00
2023-03-10 09:33:52 +01:00
2022-12-31 13:32:22 +01:00
2023-03-10 09:34:09 +01:00
2023-05-11 23:03:00 +09:00
2024-01-20 11:50:04 +01:00
2023-09-13 09:43:02 +02:00
2022-10-06 17:31:02 -07:00
2024-01-25 15:27:20 -08:00
2022-05-09 16:21:45 -04:00
2024-01-25 15:27:22 -08:00
2023-11-28 17:07:00 +00:00
2022-08-17 17:25:04 -04:00
2023-09-23 11:11:05 +02:00
2024-01-10 17:10:31 +01:00
2024-01-25 15:27:32 -08:00
2022-10-11 17:42:58 -06:00
2022-08-02 12:34:03 -04:00
2023-02-22 12:59:43 +01:00
2024-01-01 12:39:08 +00:00
2024-01-25 15:27:22 -08:00
2023-03-10 09:34:07 +01:00
2023-05-24 17:32:34 +01:00
2022-09-19 22:46:25 +02:00
2022-05-09 16:21:45 -04:00
2022-12-31 13:33:05 +01:00
2023-12-08 08:51:20 +01:00
2022-10-12 11:00:22 -07:00
2024-01-20 11:50:07 +01:00
2023-07-19 16:22:11 +02:00
2023-11-28 17:06:59 +00:00
2023-07-19 16:21:53 +02:00
2023-09-13 09:42:49 +02:00
2022-09-24 07:00:00 +02:00
2023-10-06 14:56:32 +02:00
2024-01-25 15:27:23 -08:00
2024-01-15 18:54:50 +01:00
2023-12-13 18:39:19 +01:00
2023-09-13 09:42:22 +02:00
2023-07-19 16:22:05 +02:00
2022-10-12 11:00:22 -07:00
2023-11-08 14:10:59 +01:00
2023-09-13 09:42:33 +02:00
2022-05-09 16:21:44 -04:00
2023-02-09 11:28:04 +01:00
2023-11-28 17:07:12 +00:00
2023-11-28 17:07:09 +00:00
2024-01-25 15:27:22 -08:00
2022-05-09 16:21:44 -04:00
2022-09-11 21:55:07 -07:00
2023-11-28 17:07:13 +00:00
2023-07-19 16:22:11 +02:00
2023-09-13 09:42:27 +02:00
2022-05-09 16:21:46 -04:00
2024-01-20 11:50:10 +01:00
2023-02-22 12:59:50 +01:00
2023-08-11 12:08:23 +02:00
2023-09-23 11:11:12 +02:00
2024-01-01 12:39:06 +00:00
2023-09-13 09:43:05 +02:00
2022-09-11 20:26:07 -07:00
2022-05-09 16:21:46 -04:00
2023-09-13 09:43:03 +02:00
2023-11-28 17:07:15 +00:00
2023-04-06 12:10:52 +02:00
2023-02-22 12:59:46 +01:00
2022-08-20 11:34:04 -04:00
2023-09-23 11:11:10 +02:00
2022-09-24 07:00:00 +02:00
2023-10-06 14:57:06 +02:00
2023-07-01 13:16:25 +02:00
2022-04-22 10:57:18 -07:00
2022-12-31 13:32:57 +01:00
2022-10-12 11:00:22 -07:00
2022-12-31 13:32:41 +01:00
2023-02-22 12:59:50 +01:00
2022-08-20 11:34:33 -04:00
2022-09-24 18:14:12 -07:00
2022-10-10 19:45:17 -07:00
2022-09-20 08:24:38 -06:00
2023-09-13 09:42:27 +02:00
2023-06-21 16:00:54 +02:00
2023-07-01 13:16:25 +02:00
2022-06-10 16:10:23 -04:00
2022-09-01 17:36:39 -04:00
2022-08-16 10:59:54 -04:00
2023-08-11 12:08:23 +02:00
2023-09-13 09:42:28 +02:00
2023-01-07 11:11:59 +01:00
2023-11-20 11:51:50 +01:00
2022-05-19 23:25:10 -04:00
2024-01-10 17:10:32 +01:00
2023-08-30 16:11:10 +02:00
2023-06-28 11:12:40 +02:00
2022-10-10 14:21:11 -07:00
2022-06-16 19:58:21 -07:00
2022-12-31 13:31:58 +01:00
2023-09-23 11:11:00 +02:00
2023-06-28 11:12:40 +02:00
2023-01-07 11:12:02 +01:00
2022-07-05 16:18:21 -04:00
2022-08-03 10:35:43 -07:00
2024-01-05 15:18:29 +01:00
2024-01-25 15:27:22 -08:00
2022-08-20 11:34:04 -04:00
2023-08-11 12:08:22 +02:00
2022-08-20 11:34:04 -04:00
2023-01-04 11:29:01 +01:00
2022-10-10 17:53:04 -07:00
2022-06-28 13:58:05 -04:00
2023-02-09 11:28:04 +01:00
2022-08-17 17:25:04 -04:00
2022-08-05 16:32:45 -07:00
2023-02-09 11:28:04 +01:00
2024-01-10 17:10:31 +01:00
2022-09-11 19:47:12 -05:00
2023-05-24 17:32:51 +01:00
2023-08-11 12:08:24 +02:00
2022-04-26 13:36:25 -07:00
2023-04-26 14:28:37 +02:00
2022-12-31 13:31:55 +01:00