Files
linux/fs
Al Viro ddb595dfe4 cachefiles: fix the race between cachefiles_bury_object() and rmdir(2)
commit 169b803397 upstream.

the victim might've been rmdir'ed just before the lock_rename();
unlike the normal callers, we do not look the source up after the
parents are locked - we know it beforehand and just recheck that it's
still the child of what used to be its parent.  Unfortunately,
the check is too weak - we don't spot a dead directory since its
->d_parent is unchanged, dentry is positive, etc.  So we sail all
the way to ->rename(), with hosting filesystems _not_ expecting
to be asked renaming an rmdir'ed subdirectory.

The fix is easy, fortunately - the lock on parent is sufficient for
making IS_DEADDIR() on child safe.

Cc: stable@vger.kernel.org
Fixes: 9ae326a690 (CacheFiles: A cache that backs onto a mounted filesystem)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-11-10 07:48:34 -08:00
..
2018-07-08 15:30:51 +02:00
2018-07-17 11:39:26 +02:00
2018-10-13 09:27:29 +02:00
2018-09-26 08:38:09 +02:00
2018-07-03 11:25:03 +02:00
2018-06-05 11:41:54 +02:00
2017-09-04 19:05:15 -04:00
2017-04-17 12:52:27 -04:00
2018-05-16 10:10:25 +02:00