Files
linux/include/linux
Shakeel Butt f689054aac percpu_counter: add percpu_counter_sum_all interface
The percpu_counter is used for scenarios where performance is more
important than the accuracy.  For percpu_counter users, who want more
accurate information in their slowpath, percpu_counter_sum is provided
which traverses all the online CPUs to accumulate the data.  The reason it
only needs to traverse online CPUs is because percpu_counter does
implement CPU offline callback which syncs the local data of the offlined
CPU.

However there is a small race window between the online CPUs traversal of
percpu_counter_sum and the CPU offline callback.  The offline callback has
to traverse all the percpu_counters on the system to flush the CPU local
data which can be a lot.  During that time, the CPU which is going offline
has already been published as offline to all the readers.  So, as the
offline callback is running, percpu_counter_sum can be called for one
counter which has some state on the CPU going offline.  Since
percpu_counter_sum only traverses online CPUs, it will skip that specific
CPU and the offline callback might not have flushed the state for that
specific percpu_counter on that offlined CPU.

Normally this is not an issue because percpu_counter users can deal with
some inaccuracy for small time window.  However a new user i.e.  mm_struct
on the cleanup path wants to check the exact state of the percpu_counter
through check_mm().  For such users, this patch introduces
percpu_counter_sum_all() which traverses all possible CPUs and it is used
in fork.c:check_mm() to avoid the potential race.

This issue is exposed by the later patch "mm: convert mm's rss stats into
percpu_counter".

Link: https://lkml.kernel.org/r/20221109012011.881058-1-shakeelb@google.com
Signed-off-by: Shakeel Butt <shakeelb@google.com>
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2022-11-30 15:58:40 -08:00
..
2022-05-22 20:44:29 +01:00
2022-03-23 19:58:38 +01:00
2022-02-01 14:25:50 +02:00
2022-07-05 20:25:39 +02:00
2022-01-22 08:33:34 +02:00
2022-09-21 11:18:28 +09:00
2022-09-26 12:19:12 -07:00
2022-09-26 19:46:29 -07:00
2022-09-26 10:13:13 -07:00
2022-09-26 10:13:13 -07:00
2022-09-15 09:32:06 -07:00
2022-09-26 10:13:14 -07:00
2022-03-15 10:32:44 +01:00
2021-12-10 17:10:55 -08:00
2022-06-28 10:37:25 -03:00
2021-08-26 15:32:28 -04:00
2022-07-01 14:53:01 +02:00
2022-10-17 13:49:45 +02:00
2021-07-27 11:00:36 +02:00
2022-08-31 14:57:28 +01:00
2021-06-25 19:57:01 -04:00
2022-01-20 08:52:54 +02:00
2021-07-27 20:11:45 +01:00
2021-07-27 20:11:44 +01:00
2022-10-03 14:02:45 -07:00
2022-08-16 12:46:26 +02:00
2022-06-09 21:53:09 -07:00
2022-06-09 21:53:12 -07:00
2022-06-09 21:53:09 -07:00
2022-02-28 23:26:27 -08:00
2022-09-01 18:04:43 +02:00
2022-06-27 06:29:12 -06:00
2022-09-08 12:59:00 -06:00
2022-09-26 13:31:20 +02:00
2022-09-01 18:08:44 +02:00
2022-07-17 17:31:38 -07:00
2022-10-03 14:03:19 -07:00
2022-05-02 14:06:20 -06:00
2022-01-27 13:53:26 +00:00
2022-05-03 16:09:03 -04:00
2021-06-15 17:46:57 +02:00
2022-06-19 10:38:26 +01:00
2022-07-27 14:04:52 +02:00
2022-04-28 23:16:14 -07:00
2022-09-26 10:13:13 -07:00
2022-08-02 12:34:04 -04:00
2021-07-01 11:06:05 -07:00
2021-12-16 22:22:20 +01:00
2022-09-01 17:39:49 -04:00
2022-08-22 14:26:30 +01:00
2022-05-17 13:32:46 -04:00
2022-08-09 14:11:34 -04:00
2022-07-29 20:16:58 -04:00
2022-02-09 09:24:40 -05:00
2022-01-12 10:14:09 -06:00
2022-10-03 17:34:32 -07:00
2022-09-26 19:46:27 -07:00
2021-09-17 13:52:17 +01:00
2021-09-27 09:27:29 -04:00
2022-09-26 19:46:09 -07:00
2022-11-08 17:37:18 -08:00
2022-07-01 16:38:35 -06:00
2022-02-02 07:49:59 -07:00
2021-09-27 17:00:21 +02:00
2021-07-06 10:37:46 -05:00
2022-02-09 08:04:44 +01:00
2022-02-09 08:04:44 +01:00
2022-10-17 16:32:05 +02:00
2021-10-14 13:29:18 +02:00
2022-10-04 20:52:38 +02:00
2022-10-11 17:42:58 -06:00
2022-01-22 08:33:37 +02:00
2022-01-08 12:43:57 -06:00
2022-09-19 06:17:05 -07:00
2022-01-24 14:45:02 +01:00
2022-10-11 17:42:58 -06:00
2022-03-08 14:33:36 -06:00
2022-03-17 20:16:29 -07:00
2022-03-23 19:58:41 +01:00
2022-05-22 21:03:01 +01:00
2022-04-07 12:53:54 +02:00
2022-06-27 14:41:31 +02:00
2022-02-24 15:04:51 +00:00
2022-05-08 01:33:08 -07:00
2021-08-19 09:02:55 +09:00
2021-06-24 15:49:32 +02:00
2022-09-07 12:42:25 +01:00
2022-02-25 09:36:06 +01:00
2022-09-29 15:20:29 +02:00
2022-04-11 19:18:27 -06:00
2022-03-22 15:57:11 -07:00
2022-09-22 16:12:34 +02:00
2021-11-25 18:35:23 +01:00
2022-09-22 16:12:34 +02:00
2022-08-31 13:37:32 +02:00
2022-09-01 11:42:12 +01:00
2022-09-16 10:56:08 +01:00
2021-10-12 11:41:39 -03:00
2022-08-28 16:52:28 +01:00
2022-10-07 09:32:40 -04:00
2022-10-07 08:10:52 -06:00
2022-09-26 19:46:18 -07:00
2022-06-13 09:54:52 -07:00
2022-09-26 19:46:18 -07:00
2021-08-11 06:44:24 -04:00
2022-09-28 10:00:16 +02:00
2022-07-10 21:17:30 -04:00
2021-10-19 23:44:30 +08:00