Files
linux/include/linux
Dan Williams 50f44ee724 mm/devm_memremap_pages: fix final page put race
Logan noticed that devm_memremap_pages_release() kills the percpu_ref
drops all the page references that were acquired at init and then
immediately proceeds to unplug, arch_remove_memory(), the backing pages
for the pagemap.  If for some reason device shutdown actually collides
with a busy / elevated-ref-count page then arch_remove_memory() should
be deferred until after that reference is dropped.

As it stands the "wait for last page ref drop" happens *after*
devm_memremap_pages_release() returns, which is obviously too late and
can lead to crashes.

Fix this situation by assigning the responsibility to wait for the
percpu_ref to go idle to devm_memremap_pages() with a new ->cleanup()
callback.  Implement the new cleanup callback for all
devm_memremap_pages() users: pmem, devdax, hmm, and p2pdma.

Link: http://lkml.kernel.org/r/155727339156.292046.5432007428235387859.stgit@dwillia2-desk3.amr.corp.intel.com
Fixes: 41e94a8513 ("add devm_memremap_pages")
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reported-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Jérôme Glisse" <jglisse@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-06-13 17:34:56 -10:00
..
2018-10-16 11:13:50 +02:00
2018-11-12 10:33:49 +01:00
2018-05-26 09:16:44 +02:00
2019-05-14 19:52:50 -07:00
2018-11-07 13:44:59 -07:00
2018-11-07 13:44:59 -07:00
2019-04-09 17:05:46 -07:00
2019-05-07 08:39:02 -06:00
2018-06-15 18:10:01 -03:00
2019-05-09 15:25:13 -04:00
2018-03-26 15:09:38 +02:00
2018-08-22 10:52:48 -07:00
2018-11-13 21:55:24 +01:00
2019-02-28 03:28:53 -05:00
2019-02-28 08:24:23 -07:00
2018-12-19 10:42:08 +01:00
2019-04-22 09:48:12 -06:00
2019-02-15 16:54:38 +01:00
2018-11-07 13:42:32 -07:00
2019-03-22 14:36:02 +01:00
2019-05-01 07:47:37 -07:00
2018-11-19 19:03:46 -07:00
2018-06-22 13:43:27 +09:00
2019-04-08 22:56:14 +02:00
2018-07-12 21:35:28 +02:00
2018-11-30 13:29:04 +00:00
2018-04-12 09:41:19 -07:00
2019-03-07 18:32:03 -08:00
2018-06-07 17:34:35 -07:00
2018-03-26 13:14:43 -04:00
2018-03-26 13:14:43 -04:00
2019-01-30 20:51:47 -05:00
2018-10-17 13:56:58 -07:00
2019-02-20 07:22:17 -07:00
2019-02-20 07:22:10 -07:00
2018-12-06 15:45:46 +01:00
2019-02-08 15:02:49 -08:00
2018-01-08 08:22:45 -06:00
2018-07-10 17:22:35 +02:00
2018-06-07 17:34:36 -07:00
2019-03-05 21:07:19 -08:00
2019-05-14 09:47:51 -07:00
2018-10-21 10:46:39 -04:00
2018-10-26 16:26:35 -07:00
2019-05-07 14:31:03 +02:00
2018-10-08 22:53:10 +11:00
2019-03-12 10:04:03 -07:00
2019-05-14 19:52:51 -07:00
2019-05-14 19:52:48 -07:00
2018-07-20 01:11:45 +02:00
2018-05-11 17:28:45 -07:00
2019-04-02 17:57:35 +02:00
2019-05-08 22:14:36 +02:00
2018-09-25 20:17:35 -07:00
2019-05-16 15:51:55 -07:00
2018-07-07 17:25:23 +02:00
2019-03-15 15:29:47 -07:00
2019-02-07 16:38:35 +01:00
2018-01-15 12:07:46 -08:00
2018-06-20 11:35:56 +02:00
2018-09-29 22:47:49 -04:00
2018-02-06 18:32:47 -08:00
2018-10-11 09:16:44 -07:00
2019-02-07 00:13:27 +01:00
2018-12-10 10:17:45 +01:00
2019-04-06 10:48:35 -06:00
2019-01-11 18:05:40 -08:00
2018-09-11 14:11:51 +02:00
2019-05-15 17:35:54 +01:00
2019-04-09 15:14:49 -06:00
2018-12-22 12:15:29 +01:00
2018-05-14 09:51:34 -04:00