Files
linux/include/linux
Masami Hiramatsu fc800a10be tracing: Lock event_mutex before synth_event_mutex
synthetic event is using synth_event_mutex for protecting
synth_event_list, and event_trigger_write() path acquires
locks as below order.

event_trigger_write(event_mutex)
  ->trigger_process_regex(trigger_cmd_mutex)
    ->event_hist_trigger_func(synth_event_mutex)

On the other hand, synthetic event creation and deletion paths
call trace_add_event_call() and trace_remove_event_call()
which acquires event_mutex. In that case, if we keep the
synth_event_mutex locked while registering/unregistering synthetic
events, its dependency will be inversed.

To avoid this issue, current synthetic event is using a 2 phase
process to create/delete events. For example, it searches existing
events under synth_event_mutex to check for event-name conflicts, and
unlocks synth_event_mutex, then registers a new event under event_mutex
locked. Finally, it locks synth_event_mutex and tries to add the
new event to the list. But it can introduce complexity and a chance
for name conflicts.

To solve this simpler, this introduces trace_add_event_call_nolock()
and trace_remove_event_call_nolock() which don't acquire
event_mutex inside. synthetic event can lock event_mutex before
synth_event_mutex to solve the lock dependency issue simpler.

Link: http://lkml.kernel.org/r/154140844377.17322.13781091165954002713.stgit@devbox

Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Tested-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
2018-12-08 20:54:09 -05:00
..
2018-10-31 10:57:43 -07:00
2018-10-18 15:41:21 -07:00
2018-10-16 11:13:50 +02:00
2018-10-31 19:24:21 +01:00
2018-05-26 09:16:44 +02:00
2018-06-15 18:10:01 -03:00
2017-06-08 18:52:36 -07:00
2018-11-01 19:59:53 -06:00
2018-10-19 13:24:31 -07:00
2018-10-19 13:24:31 -07:00
2018-05-09 17:25:13 +02:00
2018-09-06 15:12:24 -06:00
2017-11-15 18:21:04 -08:00
2018-10-26 16:26:32 -07:00
2018-06-15 18:10:01 -03:00
2018-03-26 15:09:38 +02:00
2018-08-22 10:52:48 -07:00
2017-08-24 13:23:03 -07:00
2018-01-01 12:40:27 -07:00
2018-09-11 14:11:54 +02:00
2017-08-07 17:22:14 +02:00
2018-07-12 10:04:29 -04:00
2017-11-13 01:41:20 +01:00
2018-07-27 09:57:23 +10:00
2018-06-28 20:32:51 +09:00
2018-11-06 13:59:08 +01:00
2018-10-21 10:46:33 -04:00
2018-03-26 08:53:43 -06:00
2018-10-09 07:50:41 +02:00
2018-06-22 13:43:27 +09:00
2018-04-11 10:28:38 -07:00
2017-11-15 18:21:01 -08:00
2018-06-21 12:33:21 +02:00
2018-07-12 21:35:28 +02:00
2017-12-01 13:09:40 -08:00
2018-04-12 09:41:19 -07:00
2017-08-28 20:51:22 +02:00
2018-06-05 08:50:16 -04:00
2018-06-07 17:34:35 -07:00
2018-04-11 10:28:32 -07:00
2018-10-31 08:54:14 -07:00
2018-06-07 17:34:39 -07:00
2018-03-26 13:14:43 -04:00
2018-03-26 13:14:43 -04:00
2018-10-17 13:56:58 -07:00
2018-08-22 10:52:45 -07:00
2018-01-28 22:17:24 -05:00
2017-07-25 18:05:25 +02:00
2018-01-08 08:22:45 -06:00
2018-07-10 17:22:35 +02:00
2018-01-08 08:22:45 -06:00
2018-06-07 17:34:36 -07:00
2018-10-21 10:46:39 -04:00
2017-11-09 10:23:28 +01:00
2018-09-18 17:52:15 -05:00
2018-07-19 11:34:23 +01:00
2018-10-26 16:26:35 -07:00
2018-10-01 23:14:10 -07:00
2017-11-17 16:10:04 -08:00
2018-07-21 10:43:12 -05:00
2017-11-13 01:33:48 +01:00
2017-12-16 02:05:48 +01:00
2018-10-08 22:53:10 +11:00
2018-08-22 10:52:46 -07:00
2018-10-26 16:26:32 -07:00
2018-05-31 00:13:56 +08:00
2018-07-20 01:11:45 +02:00
2018-08-02 17:33:06 -04:00
2018-05-11 17:28:45 -07:00
2018-09-28 14:20:59 +02:00
2018-09-25 20:17:35 -07:00
2018-03-01 08:33:05 -07:00
2017-11-07 12:22:21 +01:00
2018-06-29 08:48:06 -06:00
2018-06-07 17:34:35 -07:00
2018-07-07 17:25:23 +02:00
2018-07-03 09:20:44 +02:00
2018-08-16 12:14:42 -07:00
2018-01-15 12:07:46 -08:00
2018-06-20 11:35:56 +02:00
2018-09-29 22:47:49 -04:00
2018-02-06 18:32:47 -08:00
2018-10-11 09:16:44 -07:00
2018-09-25 20:33:24 +02:00
2018-10-24 00:41:07 +01:00
2018-02-06 18:32:44 -08:00
2017-12-20 09:53:54 -07:00
2018-09-11 14:11:51 +02:00
2018-10-21 10:46:46 -04:00
2018-05-14 09:51:34 -04:00
2017-08-15 09:02:07 -07:00
2017-08-15 09:02:08 -07:00