Jason Lunz
fc0e01974c
[JFFS2] fix write deadlock regression
...
I've bisected the deadlock when many small appends are done on jffs2 down to
this commit:
commit 6fe6900e1e
Author: Nick Piggin <npiggin@suse.de >
Date: Sun May 6 14:49:04 2007 -0700
mm: make read_cache_page synchronous
Ensure pages are uptodate after returning from read_cache_page, which allows
us to cut out most of the filesystem-internal PageUptodate calls.
I didn't have a great look down the call chains, but this appears to fixes 7
possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in
ecryptfs, 1 in jffs2, and a possible cleared data overwritten with readpage in
block2mtd. All depending on whether the filler is async and/or can return
with a !uptodate page.
It introduced a wait to read_cache_page, as well as a
read_cache_page_async function equivalent to the old read_cache_page
without any callers.
Switching jffs2_gc_fetch_page to read_cache_page_async for the old
behavior makes the deadlocks go away, but maybe reintroduces the
use-before-uptodate problem? I don't understand the mm/fs interaction
well enough to say.
[It's fine. dwmw2.]
Signed-off-by: Jason Lunz <lunz@falooley.org >
Signed-off-by: David Woodhouse <dwmw2@infradead.org >
2007-09-02 18:18:38 +01:00
..
2007-08-23 10:13:45 -05:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-07-31 15:39:40 -07:00
2007-05-11 08:29:36 -07:00
2007-08-22 19:52:46 -07:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-08-18 00:15:20 +00:00
2007-07-21 17:49:14 -07:00
2007-07-20 10:11:58 +09:00
2007-05-07 12:12:51 -07:00
2007-07-18 15:49:48 -07:00
2007-05-08 11:14:59 -07:00
2007-08-14 10:31:02 +01:00
2007-08-31 01:42:23 -07:00
2007-07-20 10:11:58 +09:00
2007-07-17 10:23:06 -07:00
2007-07-26 11:35:17 -07:00
2007-07-26 11:35:17 -07:00
2007-07-31 15:39:37 -07:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-08-14 10:34:40 +01:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-07-10 08:04:13 +02:00
2007-07-20 10:11:58 +09:00
2007-02-12 09:48:47 -08:00
2007-08-31 01:42:23 -07:00
2007-07-31 15:39:41 -07:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-09-02 18:18:38 +01:00
2007-07-20 10:11:58 +09:00
2007-07-26 11:11:56 -07:00
2007-07-20 10:11:58 +09:00
2007-02-12 09:48:46 -08:00
2007-07-31 15:39:41 -07:00
2007-08-31 20:26:45 -07:00
2006-10-20 10:26:41 -07:00
2007-07-31 15:39:38 -07:00
2007-07-16 09:05:52 -07:00
2007-07-20 10:11:58 +09:00
2007-08-09 17:27:58 -07:00
2007-07-20 10:11:58 +09:00
2007-07-30 00:27:31 -07:00
2007-08-23 15:18:02 +02:00
2007-07-20 10:11:58 +09:00
2007-07-31 15:39:36 -07:00
2007-07-26 11:11:58 -07:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-08-22 14:35:36 -07:00
2007-07-20 10:11:58 +09:00
2007-08-31 01:42:22 -07:00
2007-07-20 10:11:58 +09:00
2007-02-12 09:48:46 -08:00
2007-07-26 11:11:57 -07:00
2007-05-11 08:29:37 -07:00
2007-07-17 11:50:26 -07:00
2007-07-17 12:00:03 -07:00
2007-07-10 08:04:15 +02:00
2006-12-08 08:28:41 -08:00
2007-07-19 10:04:47 -07:00
2007-07-21 17:49:14 -07:00
2007-05-08 11:15:07 -07:00
2007-06-08 17:23:32 -07:00
2007-07-19 10:04:45 -07:00
2007-07-19 10:04:45 -07:00
2006-10-04 06:51:26 -06:00
2007-07-24 09:28:11 +02:00
2007-07-20 10:11:58 +09:00
2007-07-20 08:44:19 -07:00
2007-07-19 10:04:43 -07:00
2007-08-06 15:06:03 -04:00
2007-07-19 10:04:45 -07:00
2007-07-20 10:11:58 +09:00
2007-07-29 17:09:29 -07:00
2007-08-20 22:50:25 -07:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-07-16 09:05:36 -07:00
2007-05-18 13:09:34 -07:00
2007-07-20 10:11:58 +09:00
2007-08-22 19:52:47 -07:00
2007-07-20 10:11:58 +09:00
2007-05-21 09:18:19 -07:00
2007-05-08 11:15:07 -07:00
2006-12-22 08:55:50 -08:00
2007-05-08 11:15:01 -07:00
2007-01-26 12:53:20 -08:00
2007-07-17 12:00:03 -07:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-05-08 11:15:11 -07:00
2007-05-08 11:15:09 -07:00
2007-07-16 09:05:48 -07:00
2007-02-12 09:48:32 -08:00
2007-07-19 15:09:02 -04:00
2007-05-21 14:34:00 +09:00
2007-05-09 06:44:57 +02:00
2007-07-31 15:39:43 -07:00
2007-05-11 08:29:36 -07:00
2007-07-20 10:11:58 +09:00
2007-05-11 08:29:35 -07:00
2007-07-19 10:04:45 -07:00
2007-07-20 10:11:58 +09:00
2007-07-19 10:04:45 -07:00
2006-09-30 20:52:31 +02:00
2007-07-31 15:39:42 -07:00
2007-07-27 08:08:51 +02:00
2007-05-08 11:15:11 -07:00
2006-12-08 08:28:51 -08:00
2006-10-01 00:39:19 -07:00
2005-04-16 15:20:36 -07:00
2006-03-23 07:38:11 -08:00
2007-07-27 15:40:13 -07:00
2007-07-10 08:04:15 +02:00
2006-10-01 00:39:28 -07:00
2007-05-08 11:15:09 -07:00
2007-05-09 07:10:02 +02:00
2007-07-16 09:05:45 -07:00
2007-08-22 19:52:46 -07:00
2007-07-27 08:08:51 +02:00
2007-02-19 14:21:50 -08:00
2007-05-08 11:15:07 -07:00
2007-07-16 09:05:46 -07:00
2007-06-28 11:38:30 -07:00
2007-07-26 11:35:17 -07:00
2007-07-17 12:00:03 -07:00
2007-02-14 08:09:54 -08:00
2007-07-17 12:00:03 -07:00