Darrick J. Wong b1a15c0551 xfs: revert "xfs: fix rmap key and record comparison functions" ...

[ Upstream commit eb8409071a ]

This reverts commit 6ff646b2ce.

Your maintainer committed a major braino in the rmap code by adding the
attr fork, bmbt, and unwritten extent usage bits into rmap record key
comparisons.  While XFS uses the usage bits *in the rmap records* for
cross-referencing metadata in xfs_scrub and xfs_repair, it only needs
the owner and offset information to distinguish between reverse mappings
of the same physical extent into the data fork of a file at multiple
offsets.  The other bits are not important for key comparisons for index
lookups, and never have been.

Eric Sandeen reports that this causes regressions in generic/299, so
undo this patch before it does more damage.

Reported-by: Eric Sandeen <sandeen@sandeen.net>
Fixes: 6ff646b2ce ("xfs: fix rmap key and record comparison functions")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-05-16 09:49:20 +09:00

..

libxfs

xfs: revert "xfs: fix rmap key and record comparison functions"

2023-05-16 09:49:20 +09:00

Kconfig

xfs: implement iomap based buffered write path

2016-06-21 09:53:44 +10:00

kmem.c

xfs: remove kmem_zalloc_greedy

2017-10-08 10:26:11 +02:00

kmem.h

xfs: remove kmem_zalloc_greedy

2017-10-08 10:26:11 +02:00

Makefile

xfs: introduce the CoW fork

2016-10-04 18:06:40 -07:00

mrlock.h

xfs: introduce CONFIG_XFS_WARN

2013-05-07 18:45:36 -05:00

uuid.c

xfs: remove subdirectories

2011-08-12 16:21:35 -05:00

uuid.h

xfs: add CRC infrastructure

2012-11-19 20:11:24 -06:00

xfs_acl.c

xfs: don't change inode mode if ACL update fails

2017-10-27 10:38:10 +02:00

xfs_acl.h

xfs: Don't clear SGID when inheriting ACLs

2017-07-27 15:08:03 -07:00

xfs_aops.c

xfs: ubsan fixes

2018-02-03 17:05:40 +01:00

xfs_aops.h

xfs: allocate delayed extents in CoW fork

2016-10-04 18:06:41 -07:00

xfs_attr_inactive.c

xfs: reinit btree pointer on attr tree inactivation walk

2017-10-27 10:38:10 +02:00

xfs_attr_list.c

xfs: make several functions static

2016-06-01 17:38:15 +10:00

xfs_attr.h

xfs: remove put_value from attr ->put_listent context

2016-04-06 07:57:45 +10:00

xfs_bmap_item.c

xfs: try to avoid blowing out the transaction reservation when bunmaping a shared extent

2017-09-20 08:19:57 +02:00

xfs_bmap_item.h

xfs: log bmap intent items

2016-10-04 11:05:44 -07:00

xfs_bmap_util.c

xfs: move more RT specific code under CONFIG_XFS_RT

2017-10-27 10:38:10 +02:00

xfs_bmap_util.h

xfs: move more RT specific code under CONFIG_XFS_RT

2017-10-27 10:38:10 +02:00

xfs_buf_item.c

xfs: fix compiler warnings

2017-09-20 08:20:02 +02:00

xfs_buf_item.h

xfs: remove unnecessary dirty bli format check for ordered bufs

2017-09-20 08:20:01 +02:00

xfs_buf.c

xfs: fix use-after-free race in xfs_buf_rele

2023-05-15 15:17:41 +09:00

xfs_buf.h

xfs: push buffer of flush locked dquot to avoid quotacheck deadlock

2017-09-20 08:19:57 +02:00

xfs_dir2_readdir.c

xfs: prevent multi-fsb dir readahead from reading random blocks

2017-06-07 12:07:51 +02:00

xfs_discard.c

Force log to disk before reading the AGF during a fstrim

2018-05-30 07:50:40 +02:00

xfs_discard.h

xfs: remove subdirectories

2011-08-12 16:21:35 -05:00

xfs_dquot_item.c

xfs: Properly retry failed dquot items in case of error during buffer writeback

2018-02-03 17:05:40 +01:00

xfs_dquot_item.h

xfs: remove the quotaoff log format from the quotaoff log item

2013-12-13 11:34:08 +11:00

xfs_dquot.c

xfs: Properly retry failed dquot items in case of error during buffer writeback

2018-02-03 17:05:40 +01:00

xfs_dquot.h

xfs: fix implicit bool to int conversion

2015-01-09 10:48:58 +11:00

xfs_error.c

fs/xfs: Use %pS printk format for direct addresses

2017-10-27 10:38:09 +02:00

xfs_error.h

xfs: simulate per-AG reservations being critically low

2016-10-05 16:26:31 -07:00

xfs_export.c

xfs: abstract block export operations from nfsd layouts

2016-07-15 15:31:29 -04:00

xfs_export.h

xfs: remove subdirectories

2011-08-12 16:21:35 -05:00

xfs_extent_busy.c

xfs: don't fail xfs_extent_busy allocation

2017-04-08 09:30:31 +02:00

xfs_extent_busy.h

xfs: decouple inode and bmap btree header files

2013-10-23 16:28:49 -05:00

xfs_extfree_item.c

xfs: remove unnecessary parentheses from log redo item recovery functions

2016-08-03 12:29:32 +10:00

xfs_extfree_item.h

xfs: refactor redo intent item processing

2016-08-03 11:23:49 +10:00

xfs_file.c

xfs: prevent creating negative-sized file via INSERT_RANGE

2018-05-09 09:50:21 +02:00

xfs_filestream.c

Merge branch 'xfs-4.9-log-recovery-fixes' into for-next

2016-10-03 09:56:28 +11:00

xfs_filestream.h

xfs: add filestream allocator tracepoints

2014-04-23 07:11:52 +10:00

xfs_fsops.c

xfs: use the actual AG length when reserving blocks

2017-01-12 11:39:44 +01:00

xfs_fsops.h

xfs: preallocate blocks for worst-case btree expansion

2016-10-05 16:26:27 -07:00

xfs_globals.c

xfs: garbage collect old cowextsz reservations

2016-10-05 16:26:28 -07:00

xfs_icache.c

xfs: validate cached inodes are free when allocated

2023-05-16 08:39:50 +09:00

xfs_icache.h

xfs: update ag iterator to support wait on new inodes

2017-06-07 12:07:52 +02:00

xfs_icreate_item.c

xfs: move most of xfs_sb.h to xfs_format.h

2014-11-28 14:27:09 +11:00

xfs_icreate_item.h

xfs: separate icreate log format definitions from xfs_icreate_item.h

2013-08-12 16:10:35 -05:00

xfs_inode_item.c

xfs: Don't log uninitialised fields in inode structures

2017-10-27 10:38:09 +02:00

xfs_inode_item.h

xfs: remove timestamps from incore inode

2016-02-09 16:54:58 +11:00

xfs_inode.c

xfs: always free inline data before resetting inode fork during ifree

2018-02-03 17:05:38 +01:00

xfs_inode.h

xfs: support ability to wait on new inodes

2017-06-07 12:07:51 +02:00

xfs_ioctl32.c

xfs: Fix bulkstat compat ioctls on x32 userspace.

2023-05-15 16:06:50 +09:00

xfs_ioctl32.h

xfs: compat_xfs_bstat does not have forkoff

2014-10-02 09:17:58 +10:00

xfs_ioctl.c

xfs: validate bdev support for DAX inode flag

2017-10-05 09:44:03 +02:00

xfs_ioctl.h

xfs: don't pass ioflags around in the ioctl path

2016-07-20 11:29:35 +10:00

xfs_iomap.c

xfs: update i_size after unwritten conversion in dio completion

2017-10-27 10:38:09 +02:00

xfs_iomap.h

xfs: update i_size after unwritten conversion in dio completion

2017-10-27 10:38:09 +02:00

xfs_iops.c

xfs: flush new eof page on truncate to avoid post-eof corruption

2023-05-16 09:47:03 +09:00

xfs_iops.h

xfs: Propagate dentry down to inode_change_ok()

2016-09-22 10:56:19 +02:00

xfs_itable.c

xfs: remove kmem_zalloc_greedy

2017-10-08 10:26:11 +02:00

xfs_itable.h

xfs: bulkstat chunk formatting cursor is broken

2014-11-07 08:30:30 +11:00

xfs_linux.h

xfs: XFS_IS_REALTIME_INODE() should be false if no rt device present

2017-09-13 14:13:37 -07:00

xfs_log_cil.c

xfs: allocate log vector buffers outside CIL context lock

2016-07-22 09:52:35 +10:00

xfs_log_priv.h

xfs: rework log recovery to submit buffers on LSN boundaries

2016-09-26 08:22:16 +10:00

xfs_log_recover.c

xfs: fix log block underflow during recovery cycle verification

2017-12-20 10:07:31 +01:00

xfs_log.c

xfs: fix missed wakeup on l_flush_wait

2023-05-16 08:44:07 +09:00

xfs_log.h

xfs: make several functions static

2016-06-01 17:38:15 +10:00

xfs_message.c

xfs: more info from kmem deadlocks and high-level error msgs

2015-10-12 16:04:45 +11:00

xfs_message.h

xfs: introduce CONFIG_XFS_WARN

2013-05-07 18:45:36 -05:00

xfs_mount.c

xfs: don't leak quotacheck dquots when cow recovery

2017-09-20 08:19:59 +02:00

xfs_mount.h

xfs: detect agfl count corruption and reset agfl

2018-06-06 16:44:32 +02:00

xfs_mru_cache.c

xfs: xfs_mru_cache_insert() should use GFP_NOFS

2015-03-25 14:57:53 +11:00

xfs_mru_cache.h

xfs: embedd mru_elem into parent structure

2014-04-23 07:11:51 +10:00

xfs_ondisk.h

xfs: Don't log uninitialised fields in inode structures

2017-10-27 10:38:09 +02:00

xfs_pnfs.c

xfs: fix a missing unlock on error in xfs_fs_map_blocks

2023-05-16 09:47:29 +09:00

xfs_pnfs.h

xfs: abstract block export operations from nfsd layouts

2016-07-15 15:31:29 -04:00

xfs_qm_bhv.c

xfs: move most of xfs_sb.h to xfs_format.h

2014-11-28 14:27:09 +11:00

xfs_qm_syscalls.c

xfs: wait on new inodes during quotaoff dquot release

2017-06-07 12:07:52 +02:00

xfs_qm.c

xfs: quota: check result of register_shrinker()

2018-03-03 10:23:25 +01:00

xfs_qm.h

xfs: Split default quota limits by quota type

2016-02-08 11:27:55 +11:00

xfs_quota.h

xfs: fix quota block reservation leak when tp allocates and frees blocks

2015-06-01 07:15:37 +10:00

xfs_quotaops.c

xfs: Sanity check flags of Q_XQUOTARM call

2023-05-15 16:42:28 +09:00

xfs_refcount_item.c

xfs: fix double-cleanup when CUI recovery fails

2017-01-12 11:39:44 +01:00

xfs_refcount_item.h

xfs: log refcount intent items

2016-10-03 09:11:21 -07:00

xfs_reflink.c

xfs: fix reflink quota reservation accounting error

2023-05-16 08:46:32 +09:00

xfs_reflink.h

xfs: only reclaim unwritten COW extents periodically

2017-04-08 09:30:32 +02:00

xfs_rmap_item.c

xfs: convert unwritten status of reverse mappings for shared files

2016-10-05 16:26:29 -07:00

xfs_rmap_item.h

xfs: convert RUI log formats to use variable length arrays

2016-09-19 10:24:27 +10:00

xfs_rtalloc.c

xfs: fix realtime bitmap/summary file truncation when growing rt volume

2023-05-16 09:44:37 +09:00

xfs_rtalloc.h

xfs: make several functions static

2016-06-01 17:38:15 +10:00

xfs_stats.c

xfs: introduce refcount btree definitions

2016-10-03 09:11:16 -07:00

xfs_stats.h

xfs: introduce refcount btree definitions

2016-10-03 09:11:16 -07:00

xfs_super.c

xfs: clear sb->s_fs_info on mount failure

2023-05-15 14:49:53 +09:00

xfs_super.h

xfs: quiesce the filesystem after recovery on readonly mount

2016-09-26 08:21:44 +10:00

xfs_symlink.c

xfs: rename flist/free_list to dfops

2016-08-03 11:19:29 +10:00

xfs_symlink.h

xfs: push down inactive transaction mgmt for remote symlinks

2013-10-08 14:53:02 -05:00

xfs_sysctl.c

xfs: garbage collect old cowextsz reservations

2016-10-05 16:26:28 -07:00

xfs_sysctl.h

xfs: garbage collect old cowextsz reservations

2016-10-05 16:26:28 -07:00

xfs_sysfs.c

xfs: fix max_retries _show and _store functions

2017-01-12 11:39:45 +01:00

xfs_sysfs.h

xfs: Fix UBSAN null-ptr-deref in xfs_sysfs_init

2023-05-16 08:54:58 +09:00

xfs_trace.c

xfs: rework xfs_bmap_free callers to use xfs_defer_ops

2016-08-03 11:15:38 +10:00

xfs_trace.h

xfs: detect agfl count corruption and reset agfl

2018-06-06 16:44:32 +02:00

xfs_trans_ail.c

xfs: Properly retry failed inode items in case of error during buffer writeback

2017-09-20 08:20:00 +02:00

xfs_trans_bmap.c

xfs: try to avoid blowing out the transaction reservation when bunmaping a shared extent

2017-09-20 08:19:57 +02:00

xfs_trans_buf.c

xfs: disallow marking previously dirty buffers as ordered

2017-09-20 08:20:02 +02:00

xfs_trans_dquot.c

xfs: fix inode quota reservation checks

2023-05-16 08:54:53 +09:00

xfs_trans_extfree.c

xfs: set up per-AG free space reservations

2016-09-19 10:30:52 +10:00

xfs_trans_inode.c

fs: Replace current_fs_time() with current_time()

2016-09-27 21:06:22 -04:00

xfs_trans_priv.h

xfs: Properly retry failed inode items in case of error during buffer writeback

2017-09-20 08:20:00 +02:00

xfs_trans_refcount.c

xfs: connect refcount adjust functions to upper layers

2016-10-03 09:11:22 -07:00

xfs_trans_rmap.c

xfs: add shared rmap map/unmap/convert log item types

2016-10-05 16:26:29 -07:00

xfs_trans.c

xfs: xfs_trans_alloc_empty

2017-06-07 12:07:52 +02:00

xfs_trans.h

xfs: disallow marking previously dirty buffers as ordered

2017-09-20 08:20:02 +02:00

xfs_xattr.c

Make __xfs_xattr_put_listen preperly report errors.

2016-09-14 07:40:35 +10:00

xfs.h

xfs: introduce CONFIG_XFS_WARN

2013-05-07 18:45:36 -05:00