shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-05-18 09:58:55 +09:00
Code Issues Packages Projects Releases Wiki Activity
Files
fd07f5e19c6fcdfa318944764248cf44eb06e532
linux/drivers
History
Sergei Shtylyov fd07f5e19c PCI: designware: Fix I/O space page leak 
When testing the R-Car PCIe driver on the Condor board, if the PCIe PHY
driver is left disabled, the kernel crashed with this BUG:

  kernel BUG at lib/ioremap.c:72!
  Internal error: Oops - BUG: 0 [#1] PREEMPT SMP
  Modules linked in:
  CPU: 0 PID: 39 Comm: kworker/0:1 Not tainted 4.17.0-dirty #1092
  Hardware name: Renesas Condor board based on r8a77980 (DT)
  Workqueue: events deferred_probe_work_func
  pstate: 80000005 (Nzcv daif -PAN -UAO)
  pc : ioremap_page_range+0x370/0x3c8
  lr : ioremap_page_range+0x40/0x3c8
  sp : ffff000008da39e0
  x29: ffff000008da39e0 x28: 00e8000000000f07
  x27: ffff7dfffee00000 x26: 0140000000000000
  x25: ffff7dfffef00000 x24: 00000000000fe100
  x23: ffff80007b906000 x22: ffff000008ab8000
  x21: ffff000008bb1d58 x20: ffff7dfffef00000
  x19: ffff800009c30fb8 x18: 0000000000000001
  x17: 00000000000152d0 x16: 00000000014012d0
  x15: 0000000000000000 x14: 0720072007200720
  x13: 0720072007200720 x12: 0720072007200720
  x11: 0720072007300730 x10: 00000000000000ae
  x9 : 0000000000000000 x8 : ffff7dffff000000
  x7 : 0000000000000000 x6 : 0000000000000100
  x5 : 0000000000000000 x4 : 000000007b906000
  x3 : ffff80007c61a880 x2 : ffff7dfffeefffff
  x1 : 0000000040000000 x0 : 00e80000fe100f07
  Process kworker/0:1 (pid: 39, stack limit = 0x        (ptrval))
  Call trace:
   ioremap_page_range+0x370/0x3c8
   pci_remap_iospace+0x7c/0xac
   pci_parse_request_of_pci_ranges+0x13c/0x190
   rcar_pcie_probe+0x4c/0xb04
   platform_drv_probe+0x50/0xbc
   driver_probe_device+0x21c/0x308
   __device_attach_driver+0x98/0xc8
   bus_for_each_drv+0x54/0x94
   __device_attach+0xc4/0x12c
   device_initial_probe+0x10/0x18
   bus_probe_device+0x90/0x98
   deferred_probe_work_func+0xb0/0x150
   process_one_work+0x12c/0x29c
   worker_thread+0x200/0x3fc
   kthread+0x108/0x134
   ret_from_fork+0x10/0x18
  Code: f9004ba2 54000080 aa0003fb 17ffff48 (d4210000)

It turned out that pci_remap_iospace() wasn't undone when the driver's
probe failed, and since devm_phy_optional_get() returned -EPROBE_DEFER,
the probe was retried, finally causing the BUG due to trying to remap
already remapped pages.

The DesignWare PCIe controller driver has the same issue.

Replace devm_pci_remap_iospace() with a devm_ managed version to fix the
bug.

Fixes: cbce790059 ("PCI: designware: Make driver arch-agnostic")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[lorenzo.pieralisi@arm.com: updated the commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
2018-07-18 17:00:29 -05:00
..
accessibility
…
acpi
Merge tag 'pwm/for-4.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm
2018-06-14 16:25:43 +09:00
amba
Merge branch 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm
2018-06-06 13:49:25 -07:00
android
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
ata
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
atm
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
auxdisplay
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
base
Merge tag 'pm-4.18-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
2018-06-13 07:24:18 -07:00
bcma
Merge tag 'dma-mapping-4.18' of git://git.infradead.org/users/hch/dma-mapping
2018-06-04 10:58:12 -07:00
block
Merge tag 'ceph-for-4.18-rc1' of git://github.com/ceph/ceph-client
2018-06-15 07:24:58 +09:00
bluetooth
Bluetooth: btusb: Add additional device ID for RTL8822BE
2018-05-30 15:45:01 +02:00
bus
Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-06-12 18:28:00 -07:00
cdrom
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
char
docs: Fix some broken references
2018-06-15 18:10:01 -03:00
clk
docs: Fix some broken references
2018-06-15 18:10:01 -03:00
clocksource
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
connector
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2018-06-06 18:39:49 -07:00
cpufreq
Merge tag 'pm-4.18-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
2018-06-13 07:24:18 -07:00
cpuidle
Merge tag 'powerpc-4.18-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
2018-06-07 10:23:33 -07:00
crypto
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
dax
Merge tag 'libnvdimm-for-4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm
2018-06-08 17:21:52 -07:00
dca
…
devfreq
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
dio
…
dma
fix a series of Documentation/ broken file name references
2018-06-15 18:10:01 -03:00
dma-buf
dma-buf: Remove unneeded stubs around sync_debug interfaces
2018-05-07 15:58:07 +02:00
edac
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
eisa
…
extcon
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
firewire
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
firmware
Merge branch 'akpm' (patches from Andrew)
2018-06-15 08:51:42 +09:00
fmc
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
fpga
fpga: clarify that unregister functions also free
2018-05-25 18:23:56 +02:00
fsi
…
gpio
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
gpu
Merge tag 'docs-broken-links' of git://linuxtv.org/mchehab/experimental
2018-06-17 05:25:18 +09:00
hid
docs: fix broken references with multiple hints
2018-06-15 18:10:01 -03:00
hsi
…
hv
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
hwmon
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
hwspinlock
Merge tag 'hwlock-v4.18' of git://github.com/andersson/remoteproc
2018-06-11 12:09:19 -07:00
hwtracing
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
i2c
Merge branch 'i2c/for-4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
2018-06-14 16:21:46 +09:00
ide
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
idle
…
iio
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
infiniband
treewide: Use array_size() in kvzalloc_node()
2018-06-12 16:19:22 -07:00
input
docs: Fix some broken references
2018-06-15 18:10:01 -03:00
iommu
Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-06-12 18:28:00 -07:00
ipack
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
irqchip
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
isdn
treewide: Use array_size() in vmalloc()
2018-06-12 16:19:22 -07:00
leds
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
lightnvm
docs: Fix some broken references
2018-06-15 18:10:01 -03:00
macintosh
Merge tag 'powerpc-4.18-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
2018-06-07 10:23:33 -07:00
mailbox
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
mcb
…
md
docs: Fix some broken references
2018-06-15 18:10:01 -03:00
media
Merge tag 'docs-broken-links' of git://linuxtv.org/mchehab/experimental
2018-06-17 05:25:18 +09:00
memory
Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-06-12 18:28:00 -07:00
memstick
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
message
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
mfd
Merge branch 'i2c/for-4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
2018-06-14 16:21:46 +09:00
misc
Merge branch 'i2c/for-4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
2018-06-14 16:21:46 +09:00
mmc
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
mtd
Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-06-12 18:28:00 -07:00
mux
…
net
nfp: stop limiting VFs to 0
2018-06-29 15:09:00 -05:00
nfc
treewide: devm_kmalloc() -> devm_kmalloc_array()
2018-06-12 16:19:22 -07:00
ntb
Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-06-12 18:28:00 -07:00
nubus
Merge tag 'char-misc-4.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2018-06-05 16:20:22 -07:00
nvdimm
Merge branch 'for-4.18/mcsafe' into libnvdimm-for-next
2018-06-08 15:16:44 -07:00
nvme
Merge branch 'nvme-4.18' of git://git.infradead.org/nvme into for-linus
2018-06-15 08:11:05 -06:00
nvmem
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
of
Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-06-12 18:28:00 -07:00
opp
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
oprofile
treewide: Use array_size() in vmalloc()
2018-06-12 16:19:22 -07:00
parisc
Merge tag 'dma-mapping-4.18' of git://git.infradead.org/users/hch/dma-mapping
2018-06-04 10:58:12 -07:00
parport
docs: Fix some broken references
2018-06-15 18:10:01 -03:00
pci
PCI: designware: Fix I/O space page leak
2018-07-18 17:00:29 -05:00
pcmcia
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
perf
drivers/bus: arm-cci: fix build warnings
2018-05-29 16:38:16 +01:00
phy
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2018-06-06 18:39:49 -07:00
pinctrl
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
platform
fix a series of Documentation/ broken file name references
2018-06-15 18:10:01 -03:00
pnp
Merge tag 'media/v4.18-2' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
2018-06-07 12:34:37 -07:00
power
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
powercap
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
pps
…
ps3
…
ptp
ptp_qoriq: move some definitions to header file
2018-05-28 23:05:11 -04:00
pwm
Merge tag 'pwm/for-4.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm
2018-06-14 16:25:43 +09:00
rapidio
treewide: Use array_size() in vmalloc()
2018-06-12 16:19:22 -07:00
ras
…
regulator
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
remoteproc
treewide: use PHYS_ADDR_MAX to avoid type casting ULLONG_MAX
2018-06-15 07:55:25 +09:00
reset
Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-06-12 18:28:00 -07:00
rpmsg
rpmsg: smd: do not use mananged resources for endpoints and channels
2018-06-04 12:35:03 -07:00
rtc
Merge tag 'mfd-next-4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
2018-06-11 07:20:17 -07:00
s390
treewide: Use array_size() in vzalloc()
2018-06-12 16:19:22 -07:00
sbus
fix a series of Documentation/ broken file name references
2018-06-15 18:10:01 -03:00
scsi
Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
2018-06-14 16:35:32 +09:00
sfi
…
sh
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
siox
…
slimbus
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
sn
…
soc
treewide: use PHYS_ADDR_MAX to avoid type casting ULLONG_MAX
2018-06-15 07:55:25 +09:00
soundwire
docs: Fix more broken references
2018-06-15 18:11:26 -03:00
spi
treewide: devm_kzalloc() -> devm_kcalloc()
2018-06-12 16:19:22 -07:00
spmi
…
ssb
ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
2018-05-12 11:38:13 +03:00
staging
media: v4l: fix broken video4linux docs locations
2018-06-15 18:10:01 -03:00
target
treewide: Use array_size() in vzalloc()
2018-06-12 16:19:22 -07:00
tc
…
tee
tee: check shm references are consistent in offset/size
2018-05-07 11:51:03 +02:00
thermal
Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-06-12 18:28:00 -07:00
thunderbolt
thunderbolt: Handle NULL boot ACL entries properly
2018-05-15 18:02:00 +02:00
tty
Merge tag 'vfs-timespec64' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground
2018-06-15 07:31:07 +09:00
uio
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
usb
Merge tag 'vfs-timespec64' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground
2018-06-15 07:31:07 +09:00
uwb
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
vfio
Merge tag 'vfio-v4.18-rc1' of git://github.com/awilliam/linux-vfio
2018-06-12 13:11:26 -07:00
vhost
Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost
2018-06-16 06:35:02 +09:00
video
Merge tag 'docs-broken-links' of git://linuxtv.org/mchehab/experimental
2018-06-17 05:25:18 +09:00
virt
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
virtio
Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost
2018-06-16 06:35:02 +09:00
visorbus
…
vlynq
…
vme
…
w1
Merge tag 'char-misc-4.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2018-06-05 16:20:22 -07:00
watchdog
Merge tag 'mips_4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux
2018-06-12 12:56:02 -07:00
xen
treewide: kvmalloc() -> kvmalloc_array()
2018-06-12 16:19:22 -07:00
zorro
Merge tag 'overflow-v4.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-06-06 17:27:14 -07:00
Kconfig
…
Makefile
…