Files
linux/include/linux
Hugh Dickins fe19bd3dae mm, futex: fix shared futex pgoff on shmem huge page
If more than one futex is placed on a shmem huge page, it can happen
that waking the second wakes the first instead, and leaves the second
waiting: the key's shared.pgoff is wrong.

When 3.11 commit 13d60f4b6a ("futex: Take hugepages into account when
generating futex_key"), the only shared huge pages came from hugetlbfs,
and the code added to deal with its exceptional page->index was put into
hugetlb source.  Then that was missed when 4.8 added shmem huge pages.

page_to_pgoff() is what others use for this nowadays: except that, as
currently written, it gives the right answer on hugetlbfs head, but
nonsense on hugetlbfs tails.  Fix that by calling hugetlbfs-specific
hugetlb_basepage_index() on PageHuge tails as well as on head.

Yes, it's unconventional to declare hugetlb_basepage_index() there in
pagemap.h, rather than in hugetlb.h; but I do not expect anything but
page_to_pgoff() ever to need it.

[akpm@linux-foundation.org: give hugetlb_basepage_index() prototype the correct scope]

Link: https://lkml.kernel.org/r/b17d946b-d09-326e-b42a-52884c36df32@google.com
Fixes: 800d8c63b2 ("shmem: add huge pages support")
Reported-by: Neel Natu <neelnatu@google.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Zhang Yi <wetpzy@gmail.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2021-06-24 19:40:54 -07:00
..
2021-02-02 00:16:57 +01:00
2020-12-09 19:26:02 -06:00
2020-06-25 22:25:13 -07:00
2020-06-16 14:19:57 +02:00
2021-01-23 14:57:21 +01:00
2021-05-18 17:24:52 +01:00
2021-05-06 19:24:11 -07:00
2021-04-14 16:30:30 +03:00
2020-05-24 20:48:11 +02:00
2021-05-08 21:49:48 -06:00
2020-09-21 15:00:40 -07:00
2020-12-02 09:46:55 -07:00
2021-01-24 14:27:17 +01:00
2021-02-26 09:41:03 -08:00
2021-04-08 16:04:20 -07:00
2021-05-24 12:45:26 -04:00
2021-05-24 12:45:26 -04:00
2021-04-08 16:04:20 -07:00
2021-04-08 16:04:20 -07:00
2021-01-21 14:06:00 -07:00
2021-05-06 19:24:11 -07:00
2021-04-19 13:13:26 -04:00
2020-03-09 11:12:19 +01:00
2021-01-18 14:26:51 +01:00
2021-03-22 03:57:39 +01:00
2021-02-08 12:28:07 +01:00
2020-12-10 12:42:59 -06:00
2021-04-12 15:04:23 +02:00
2021-03-30 22:37:06 +02:00
2020-11-16 16:31:41 +01:00
2021-05-07 00:26:34 -07:00
2020-03-06 11:06:15 +01:00
2020-11-16 15:20:01 +01:00
2020-07-24 17:12:41 -07:00
2020-11-16 08:14:30 -07:00
2021-02-11 13:24:44 -08:00
2020-08-04 21:02:38 -04:00
2020-12-02 22:10:35 -08:00
2021-04-30 11:20:40 -07:00
2020-11-23 14:16:55 +00:00
2020-09-16 08:54:53 -05:00
2020-05-18 10:30:21 +01:00
2020-11-24 16:47:48 +01:00
2021-03-22 04:23:14 +01:00
2021-04-05 22:39:38 -04:00
2020-06-02 15:15:46 +01:00
2020-12-15 16:19:31 +01:00
2021-01-21 16:16:10 +00:00
2021-02-26 09:41:02 -08:00
2021-02-26 09:41:03 -08:00
2020-09-04 09:25:20 -07:00
2021-01-22 15:09:42 +01:00
2020-05-08 18:18:11 +01:00
2020-05-08 00:12:42 +02:00
2020-05-28 10:31:09 +02:00
2020-03-06 11:56:59 +01:00
2020-09-04 12:46:07 +01:00
2021-04-08 16:04:20 -07:00
2021-01-04 11:42:21 -05:00
2020-05-09 13:57:12 +02:00
2021-04-06 08:34:39 +02:00
2020-07-01 10:49:02 +02:00
2021-02-17 13:17:49 -08:00
2021-04-21 10:24:41 -05:00
2020-07-23 17:34:18 +10:00
2021-02-26 09:40:59 -08:00
2021-02-03 19:05:50 +01:00
2020-08-31 12:52:33 -07:00
2020-10-18 09:27:10 -07:00
2021-01-24 14:27:17 +01:00
2021-01-24 14:27:20 +01:00
2020-05-09 13:57:12 +02:00
2021-03-06 12:40:22 +01:00
2021-02-26 09:41:03 -08:00
2020-12-03 11:20:52 +01:00
2020-08-18 17:06:15 +02:00
2021-03-17 14:16:15 -05:00
2021-01-16 23:19:26 +01:00
2021-03-22 02:45:52 +01:00
2021-03-18 12:58:27 -04:00
2020-12-10 16:17:15 +01:00
2020-12-10 10:45:36 +01:00
2020-09-26 22:55:05 -04:00
2021-05-06 19:24:11 -07:00
2021-03-19 04:58:25 +00:00
2021-03-25 17:39:33 -07:00
2020-10-30 21:57:04 +01:00
2021-01-06 16:24:59 -08:00
2021-03-10 09:34:06 +01:00
2021-04-15 10:32:17 +02:00
2021-02-13 17:17:53 +01:00
2021-03-30 17:06:49 -07:00
2020-11-09 18:39:36 +01:00
2021-04-26 22:55:12 +01:00
2020-07-04 09:35:36 -05:00
2020-09-10 14:03:31 -07:00
2021-04-09 16:00:00 +02:00
2020-08-19 14:13:20 +02:00
2021-01-21 16:16:10 +00:00
2021-03-22 15:02:14 +01:00
2020-04-01 12:06:26 -04:00
2021-06-24 19:40:53 -07:00
2021-02-09 12:15:07 +01:00
2021-01-21 14:06:00 -07:00
2021-04-16 15:31:02 -07:00
2021-03-30 13:42:33 -04:00
2021-01-24 14:27:17 +01:00
2021-02-08 22:58:55 +01:00