shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-03-25 03:50:24 +09:00
Code Issues Packages Projects Releases Wiki Activity
Files
feb770cc00a8eb268c787d5195af9b9abdcd2226
linux/drivers
History
John Meneghini 00849de10f scsi: bnx2fc: Flush destroy_work queue before calling bnx2fc_interface_put() 
commit 847f9ea4c5 upstream.

The bnx2fc_destroy() functions are removing the interface before calling
destroy_work. This results multiple WARNings from sysfs_remove_group() as
the controller rport device attributes are removed too early.

Replace the fcoe_port's destroy_work queue. It's not needed.

The problem is easily reproducible with the following steps.

Example:

  $ dmesg -w &
  $ systemctl enable --now fcoe
  $ fipvlan -s -c ens2f1
  $ fcoeadm -d ens2f1.802
  [  583.464488] host2: libfc: Link down on port (7500a1)
  [  583.472651] bnx2fc: 7500a1 - rport not created Yet!!
  [  583.490468] ------------[ cut here ]------------
  [  583.538725] sysfs group 'power' not found for kobject 'rport-2:0-0'
  [  583.568814] WARNING: CPU: 3 PID: 192 at fs/sysfs/group.c:279 sysfs_remove_group+0x6f/0x80
  [  583.607130] Modules linked in: dm_service_time 8021q garp mrp stp llc bnx2fc cnic uio rpcsec_gss_krb5 auth_rpcgss nfsv4 ...
  [  583.942994] CPU: 3 PID: 192 Comm: kworker/3:2 Kdump: loaded Not tainted 5.14.0-39.el9.x86_64 #1
  [  583.984105] Hardware name: HP ProLiant DL120 G7, BIOS J01 07/01/2013
  [  584.016535] Workqueue: fc_wq_2 fc_rport_final_delete [scsi_transport_fc]
  [  584.050691] RIP: 0010:sysfs_remove_group+0x6f/0x80
  [  584.074725] Code: ff 5b 48 89 ef 5d 41 5c e9 ee c0 ff ff 48 89 ef e8 f6 b8 ff ff eb d1 49 8b 14 24 48 8b 33 48 c7 c7 ...
  [  584.162586] RSP: 0018:ffffb567c15afdc0 EFLAGS: 00010282
  [  584.188225] RAX: 0000000000000000 RBX: ffffffff8eec4220 RCX: 0000000000000000
  [  584.221053] RDX: ffff8c1586ce84c0 RSI: ffff8c1586cd7cc0 RDI: ffff8c1586cd7cc0
  [  584.255089] RBP: 0000000000000000 R08: 0000000000000000 R09: ffffb567c15afc00
  [  584.287954] R10: ffffb567c15afbf8 R11: ffffffff8fbe7f28 R12: ffff8c1486326400
  [  584.322356] R13: ffff8c1486326480 R14: ffff8c1483a4a000 R15: 0000000000000004
  [  584.355379] FS:  0000000000000000(0000) GS:ffff8c1586cc0000(0000) knlGS:0000000000000000
  [  584.394419] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  [  584.421123] CR2: 00007fe95a6f7840 CR3: 0000000107674002 CR4: 00000000000606e0
  [  584.454888] Call Trace:
  [  584.466108]  device_del+0xb2/0x3e0
  [  584.481701]  device_unregister+0x13/0x60
  [  584.501306]  bsg_unregister_queue+0x5b/0x80
  [  584.522029]  bsg_remove_queue+0x1c/0x40
  [  584.541884]  fc_rport_final_delete+0xf3/0x1d0 [scsi_transport_fc]
  [  584.573823]  process_one_work+0x1e3/0x3b0
  [  584.592396]  worker_thread+0x50/0x3b0
  [  584.609256]  ? rescuer_thread+0x370/0x370
  [  584.628877]  kthread+0x149/0x170
  [  584.643673]  ? set_kthread_struct+0x40/0x40
  [  584.662909]  ret_from_fork+0x22/0x30
  [  584.680002] ---[ end trace 53575ecefa942ece ]---

Link: https://lore.kernel.org/r/20220115040044.1013475-1-jmeneghi@redhat.com
Fixes: 0cbf32e168 ("[SCSI] bnx2fc: Avoid calling bnx2fc_if_destroy with unnecessary locks")
Tested-by: Guangwu Zhang <guazhang@redhat.com>
Co-developed-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-02-01 17:25:43 +01:00
..
accessibility
speakup: fix uninitialized flush_lock
2020-12-30 11:53:44 +01:00
acpi
ACPI: battery: Add the ThinkPad "Not Charging" quirk
2022-01-27 10:54:19 +01:00
amba
ARM: 9120/1: Revert "amba: make use of -1 IRQs warn"
2021-11-06 14:10:09 +01:00
android
binder: fix handling of error during copy
2022-01-27 10:54:06 +01:00
ata
libata: if T_LENGTH is zero, dma direction should be DMA_NONE
2021-12-22 09:30:58 +01:00
atm
atm: nicstar: register the interrupt handler in the right place
2021-07-19 09:44:52 +02:00
auxdisplay
auxdisplay: ht16k33: Fix frame buffer device blanking
2021-11-18 14:04:24 +01:00
base
device property: Fix fwnode_graph_devcon_match() fwnode leak
2022-01-27 10:54:25 +01:00
bcma
bcma: Fix memory leak for internally-handled cores
2021-09-15 09:50:45 +02:00
block
floppy: Add max size check for user space request
2022-01-27 10:54:14 +01:00
bluetooth
Bluetooth: vhci: Set HCI_QUIRK_VALID_LE_STATES
2022-01-27 10:54:18 +01:00
bus
bus: ti-sysc: Fix variable set but not used warning for reinit_modules
2021-12-22 09:30:59 +01:00
cdrom
cdrom: gdrom: initialize global variable at init time
2021-05-26 12:06:55 +02:00
char
tpm: fix NPE on probe for missing device
2022-01-27 10:54:24 +01:00
clk
clk: si5341: Fix clock HW provider cleanup
2022-01-27 10:54:31 +01:00
clocksource
clocksource/drivers/timer-ti-dm: Select TIMER_OF
2021-11-18 14:04:09 +01:00
connector
…
counter
counter: stm32-lptimer-cnt: remove iio counter abi
2022-01-27 10:54:08 +01:00
cpufreq
cpufreq: Fix initialization of min and max frequency QoS requests
2022-01-27 10:54:17 +01:00
cpuidle
cpuidle: Fix kobject memory leaks in error paths
2021-11-18 14:04:05 +01:00
crypto
crypto: caam - replace this_cpu_ptr with raw_cpu_ptr
2022-01-27 10:54:24 +01:00
dax
device-dax: Fix default return code of range_parse()
2021-03-04 11:38:15 +01:00
dca
…
devfreq
PM / devfreq: Add missing error code in devfreq_add_device()
2021-07-14 16:56:11 +02:00
dio
…
dma
dmaengine: at_xdmac: Fix at_xdmac_lld struct definition
2022-01-27 10:54:34 +01:00
dma-buf
dma_fence_array: Fix PENDING_ERROR leak in dma_fence_array_signaled()
2022-01-27 10:53:43 +01:00
edac
EDAC/synopsys: Use the quirk for version instead of ddr version
2022-01-27 10:54:11 +01:00
eisa
…
extcon
extcon: intel-mrfld: Sync hardware and software state on init
2021-07-19 09:45:00 +02:00
firewire
firewire: nosy: Fix a use-after-free bug in nosy_ioctl()
2021-04-07 15:00:11 +02:00
firmware
efi: runtime: avoid EFIv2 runtime services on Apple x86 machines
2022-02-01 17:25:39 +01:00
fpga
fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()
2021-09-30 10:11:04 +02:00
fsi
fsi: Add missing MODULE_DEVICE_TABLE
2021-07-20 16:05:42 +02:00
gnss
…
gpio
gpio: aspeed: Convert aspeed_gpio.lock to raw_spinlock
2022-01-27 10:54:15 +01:00
gpu
drm/etnaviv: relax submit size limits
2022-02-01 17:25:40 +01:00
greybus
…
hid
HID: vivaldi: fix handling devices not using numbered reports
2022-01-27 10:54:33 +01:00
hsi
HSI: core: Fix return freed object in hsi_new_client
2022-01-27 10:54:12 +01:00
hv
hyperv/vmbus: include linux/bitops.h
2021-11-18 14:03:42 +01:00
hwmon
hwmon: (mr75203) fix wrong power-up delay value
2022-01-27 10:54:00 +01:00
hwspinlock
…
hwtracing
coresight: cti: Correct the parameter for pm_runtime_put
2021-11-18 14:03:51 +01:00
i2c
i2c: designware-pci: Fix to change data types of hcnt and lcnt parameters
2022-01-27 10:54:23 +01:00
i3c
Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"
2021-05-14 09:50:05 +02:00
ide
ide/falconide: Fix module unload
2021-03-04 11:38:21 +01:00
idle
intel_idle: Build fix
2020-12-03 10:00:23 +01:00
iio
iio: adc: ti-adc081c: Partial revert of removal of ACPI IDs
2022-01-27 10:53:43 +01:00
infiniband
RDMA/rxe: Fix a typo in opcode name
2022-01-27 10:54:30 +01:00
input
Input: zinitix - make sure the IRQ is allocated before it gets enabled
2022-01-11 15:25:02 +01:00
interconnect
treewide: Change list_sort to use const pointers
2021-09-30 10:11:04 +02:00
iommu
iommu/iova: Fix race between FQ timeout and teardown
2022-01-27 10:54:08 +01:00
ipack
ipack: ipoctal: fix module reference leak
2021-10-06 15:56:01 +02:00
irqchip
irqchip/gic-v4: Disable redistributors' view of the VPE table at boot time
2022-01-27 10:54:23 +01:00
isdn
mISDN: change function names to avoid conflicts
2022-01-11 15:25:02 +01:00
leds
leds: trigger: audio: Add an activate callback to ensure the initial brightness is set
2021-09-15 09:50:36 +02:00
lightnvm
lightnvm: fix memory leak when submit fails
2021-01-27 11:55:22 +01:00
macintosh
macintosh/adb-iop: Use big-endian autopoll mask
2021-03-04 11:37:42 +01:00
mailbox
soc: mediatek: cmdq: add address shift in jump
2021-09-18 13:40:16 +02:00
mcb
mcb: fix error handling in mcb_alloc_bus()
2021-09-30 10:11:00 +02:00
md
dm: fix alloc_dax error handling in alloc_dev
2022-01-27 10:54:22 +01:00
media
media: venus: core: Drop second v4l2 device unregister
2022-02-01 17:25:38 +01:00
memory
memory: renesas-rpc-if: Return error in case devm_ioremap_resource() fails
2022-01-27 10:53:48 +01:00
memstick
memstick: jmb38x_ms: use appropriate free function in jmb38x_ms_alloc_host()
2021-11-18 14:04:07 +01:00
message
scsi: mptfusion: Fix null pointer dereferences in mptscsih_remove()
2020-10-26 16:57:18 -04:00
mfd
mfd: atmel-flexcom: Use .resume_noirq
2022-01-27 10:53:51 +01:00
misc
misc: lattice-ecp3-config: Fix task hung when firmware load failed
2022-01-27 10:54:08 +01:00
mmc
mmc: core: Fixup storing of OCR for MMC_QUIRK_NONSTD_SDIO
2022-01-27 10:54:16 +01:00
most
most: fix control-message timeouts
2021-11-18 14:03:51 +01:00
mtd
mtd: nand: bbt: Fix corner case in bad block table handling
2022-01-27 10:54:36 +01:00
mux
…
net
i40e: fix unsigned stat widths
2022-02-01 17:25:42 +01:00
nfc
NFC: st21nfca: Fix memory leak in device probe and remove
2022-01-05 12:40:31 +01:00
ntb
NTB: perf: Fix an error code in perf_setup_inbuf()
2021-09-22 12:28:02 +02:00
nubus
…
nvdimm
libnvdimm/pmem: Fix crash triggered when I/O in-flight during unbind
2021-09-18 13:40:36 +02:00
nvme
nvmet: use IOCB_NOWAIT only if the filesystem supports it
2021-12-01 09:19:07 +01:00
nvmem
nvmem: core: set size for sysfs bin file
2022-01-27 10:54:22 +01:00
of
of: base: Improve argument length mismatch error
2022-01-27 10:54:28 +01:00
opp
opp: Fix return in _opp_add_static_v2()
2021-11-18 14:04:22 +01:00
oprofile
…
parisc
parisc: pdc_stable: Fix memory leak in pdcs_register_pathentries
2022-01-27 10:54:31 +01:00
parport
parport: remove non-zero check on count
2021-09-18 13:40:34 +02:00
pci
PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device
2022-01-27 10:54:26 +01:00
pcmcia
pcmcia: fix setting of kthread task states
2022-01-27 10:54:03 +01:00
perf
perf/arm-cmn: Fix invalid pointer when access dtc object sharing the same IRQ number
2021-07-14 16:56:08 +02:00
phy
phy: uniphier-usb3ss: fix unintended writing zeros to PHY register
2022-01-27 10:54:08 +01:00
pinctrl
pinctrl: mediatek: fix global-out-of-bounds issue
2021-12-29 12:26:07 +01:00
platform
platform/x86: apple-gmux: use resource_size() with res
2022-01-05 12:40:29 +01:00
pnp
PNP: fix kernel-doc markups
2020-10-27 19:23:04 +01:00
power
power: reset: mt6397: Check for null res pointer
2022-01-27 10:54:00 +01:00
powercap
Merge branch 'turbostat' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux
2020-11-10 10:02:31 -08:00
pps
…
ps3
powerpc/ps3: use dma_mapping_error()
2020-12-30 11:53:53 +01:00
ptp
ptp_pch: Load module automatically if ID matches
2021-10-13 10:04:27 +02:00
pwm
pwm: stm32-lp: Don't modify HW state in .remove() callback
2021-09-26 14:09:01 +02:00
rapidio
rapidio: handle create_workqueue() failure
2021-05-26 12:06:52 +02:00
ras
RAS/CEC: Correct ce_add_elem()'s returned values
2021-04-14 08:42:12 +02:00
regulator
regulator: qcom_smd: Align probe function with rpmh-regulator
2022-01-27 10:54:20 +01:00
remoteproc
remoteproc: qcom: pil_info: Don't memcpy_toio more than is provided
2022-01-20 09:17:50 +01:00
reset
reset: socfpga: add empty driver allowing consumers to probe
2021-11-18 14:03:42 +01:00
rpmsg
rpmsg: char: Fix race between the release of rpmsg_eptdev and cdev
2022-02-01 17:25:43 +01:00
rtc
rtc: pxa: fix null pointer dereference
2022-01-27 10:54:33 +01:00
s390
scsi: zfcp: Fix failed recovery on gone remote port with non-NPIV FCP devices
2022-02-01 17:25:39 +01:00
sbus
…
scsi
scsi: bnx2fc: Flush destroy_work queue before calling bnx2fc_interface_put()
2022-02-01 17:25:43 +01:00
sfi
…
sh
maple: fix wrong return value of maple_bus_init().
2021-11-26 10:39:12 +01:00
siox
…
slimbus
slimbus: ngd: reset dma setup during runtime pm
2021-08-26 08:35:55 -04:00
soc
PM: AVS: qcom-cpr: Use div64_ul instead of do_div
2022-01-27 10:54:17 +01:00
soundwire
soundwire: debugfs: use controller id and link_id for debugfs
2021-11-18 14:04:16 +01:00
spi
spi: uniphier: Fix a bug that doesn't point to private data correctly
2022-01-27 10:54:24 +01:00
spmi
spmi: spmi-pmic-arb: Fix hw_irq overflow
2021-03-04 11:38:40 +01:00
ssb
ssb: Fix error return code in ssb_bus_scan()
2021-07-14 16:56:21 +02:00
staging
media: atomisp: handle errors at sh_css_create_isp_params()
2022-01-27 10:54:11 +01:00
target
scsi: target: Fix alua_tg_pt_gps_count tracking
2021-11-26 10:39:11 +01:00
tc
…
tee
tee: fix put order in teedev_close_context()
2022-01-27 10:53:49 +01:00
thermal
thermal/drivers/imx8mm: Enable ADC when enabling monitor
2022-01-27 10:53:52 +01:00
thunderbolt
thunderbolt: Runtime PM activate both ends of the device link
2022-01-27 10:54:14 +01:00
tty
tty: Add support for Brainboxes UC cards.
2022-02-01 17:25:40 +01:00
uio
uio_hv_generic: Fix a memory leak in error handling paths
2021-05-26 12:06:52 +02:00
usb
ucsi_ccg: Check DEV_INT bit only when starting CCG4
2022-02-01 17:25:41 +01:00
vdpa
vdpa/mlx5: Fix wrong configuration of virtio_version_1_0
2022-01-27 10:54:33 +01:00
vfio
vfio: Use config not menuconfig for VFIO_NOIOMMU
2021-09-18 13:40:12 +02:00
vhost
vdpa: check that offsets are within bounds
2021-12-22 09:30:51 +01:00
video
backlight: qcom-wled: Respect enabled-strings in set_brightness
2022-01-27 10:53:59 +01:00
virt
nitro_enclaves: Fix stale file descriptors on failed usercopy
2021-05-11 14:47:11 +02:00
virtio
virtio_ring: mark ring unused on error
2022-01-27 10:54:33 +01:00
visorbus
visorbus: fix error return code in visorchipset_init()
2021-07-14 16:56:41 +02:00
vlynq
…
vme
…
w1
w1: Misuse of get_user()/put_user() reported by sparse
2022-01-27 10:54:22 +01:00
watchdog
ar7: fix kernel builds for compiler test
2021-11-18 14:04:24 +01:00
xen
xen/gntdev: fix unmap notification order
2022-01-27 10:54:24 +01:00
zorro
…
Kconfig
…
Makefile
vdpa: mlx5: fix vdpa/vhost dependencies
2020-12-02 04:09:56 -05:00