John Pittman 120130a757 dm kcopyd: avoid softlockup in run_complete_job ...

[ Upstream commit 784c9a29e9 ]

It was reported that softlockups occur when using dm-snapshot ontop of
slow (rbd) storage.  E.g.:

[ 4047.990647] watchdog: BUG: soft lockup - CPU#10 stuck for 22s! [kworker/10:23:26177]
...
[ 4048.034151] Workqueue: kcopyd do_work [dm_mod]
[ 4048.034156] RIP: 0010:copy_callback+0x41/0x160 [dm_snapshot]
...
[ 4048.034190] Call Trace:
[ 4048.034196]  ? __chunk_is_tracked+0x70/0x70 [dm_snapshot]
[ 4048.034200]  run_complete_job+0x5f/0xb0 [dm_mod]
[ 4048.034205]  process_jobs+0x91/0x220 [dm_mod]
[ 4048.034210]  ? kcopyd_put_pages+0x40/0x40 [dm_mod]
[ 4048.034214]  do_work+0x46/0xa0 [dm_mod]
[ 4048.034219]  process_one_work+0x171/0x370
[ 4048.034221]  worker_thread+0x1fc/0x3f0
[ 4048.034224]  kthread+0xf8/0x130
[ 4048.034226]  ? max_active_store+0x80/0x80
[ 4048.034227]  ? kthread_bind+0x10/0x10
[ 4048.034231]  ret_from_fork+0x35/0x40
[ 4048.034233] Kernel panic - not syncing: softlockup: hung tasks

Fix this by calling cond_resched() after run_complete_job()'s callout to
the dm_kcopyd_notify_fn (which is dm-snap.c:copy_callback in the above
trace).

Signed-off-by: John Pittman <jpittman@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-09-15 09:45:31 +02:00

..

bcache

bcache: release dc->writeback_lock properly in bch_writeback_thread()

2018-09-09 19:56:01 +02:00

persistent-data

dm btree: fix serious bug in btree_split_beneath()

2018-01-23 19:58:18 +01:00

bitmap.c

md: free unused memory after bitmap resize

2017-12-17 15:08:00 +01:00

bitmap.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

dm-bio-prison-v1.c

dm bio prison: use rb_entry() rather than container_of()

2017-06-19 11:03:50 -04:00

dm-bio-prison-v1.h

block: switch bios to blk_status_t

2017-06-09 09:27:32 -06:00

dm-bio-prison-v2.c

dm bio prison: use rb_entry() rather than container_of()

2017-06-19 11:03:50 -04:00

dm-bio-prison-v2.h

dm bio prison v2: new interface for the bio prison

2017-03-07 11:30:16 -05:00

dm-bio-record.h

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

dm-bufio.c

dm bufio: avoid false-positive Wmaybe-uninitialized warning

2018-03-15 10:54:33 +01:00

dm-bufio.h

dm integrity: optimize writing dm-bufio buffers that are partially changed

2017-08-28 11:47:17 -04:00

dm-builtin.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

dm-cache-background-tracker.c

dm cache: handle kmalloc failure allocating background_tracker struct

2017-05-17 09:44:53 -04:00

dm-cache-background-tracker.h

dm cache: significant rework to leverage dm-bio-prison-v2

2017-03-07 13:28:31 -05:00

dm-cache-block-types.h

linux: drop __bitwise__ everywhere

2016-12-16 00:13:41 +02:00

dm-cache-metadata.c

dm cache metadata: set dirty on all cache blocks after a crash

2018-09-09 19:55:55 +02:00

dm-cache-metadata.h

dm cache: significant rework to leverage dm-bio-prison-v2

2017-03-07 13:28:31 -05:00

dm-cache-policy-internal.h

dm cache: significant rework to leverage dm-bio-prison-v2

2017-03-07 13:28:31 -05:00

dm-cache-policy-smq.c

dm cache policy smq: don't do any writebacks unless IDLE

2017-05-14 21:54:33 -04:00

dm-cache-policy.c

dm cache: add policy name to status output

2014-01-16 13:44:11 -05:00

dm-cache-policy.h

dm cache: significant rework to leverage dm-bio-prison-v2

2017-03-07 13:28:31 -05:00

dm-cache-target.c

dm: fix various targets to dm_register_target after module __init resources created

2017-12-20 10:10:21 +01:00

dm-core.h

dm: allocate struct mapped_device with kvzalloc

2017-11-30 08:40:43 +00:00

dm-crypt.c

dm crypt: don't decrease device limits

2018-09-09 19:55:55 +02:00

dm-delay.c

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

dm-era-target.c

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

dm-exception-store.c

Merge tag 'dm-4.4-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2015-11-04 21:19:53 -08:00

dm-exception-store.h

dm snapshot: fix hung bios when copy error occurs

2016-01-08 20:03:05 -05:00

dm-flakey.c

Merge tag 'for-4.14/dm-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2017-09-14 13:43:16 -07:00

dm-integrity.c

dm integrity: change 'suspending' variable from bool to int

2018-09-09 19:55:55 +02:00

dm-io.c

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

dm-ioctl.c

dm ioctl: fix alignment of event number in the device list

2017-09-25 11:18:29 -04:00

dm-kcopyd.c

dm kcopyd: avoid softlockup in run_complete_job

2018-09-15 09:45:31 +02:00

dm-linear.c

Merge tag 'for-4.14/dm-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2017-09-14 13:43:16 -07:00

dm-log-userspace-base.c

dm: drop NULL test before kmem_cache_destroy() and mempool_destroy()

2015-10-31 19:06:00 -04:00

dm-log-userspace-transfer.c

dm log userspace transfer: match wait_for_completion_timeout return type

2015-04-15 12:10:20 -04:00

dm-log-userspace-transfer.h

dm log: userspace add luid to distinguish between concurrent log instances

2009-09-04 20:40:34 +01:00

dm-log-writes.c

Merge tag 'for-4.14/dm-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2017-09-14 13:43:16 -07:00

dm-log.c

block,fs: use REQ_* flags directly

2016-11-01 09:43:26 -06:00

dm-mpath.c

dm mpath: return DM_MAPIO_REQUEUE on blk-mq rq allocation failure

2018-04-26 11:02:07 +02:00

dm-mpath.h

dm mpath: remove is_active from struct dm_path

2008-10-10 13:36:58 +01:00

dm-path-selector.c

md: Add module.h to all files using it implicitly

2011-10-31 19:31:18 -04:00

dm-path-selector.h

dm path selector: remove 'repeat_count' return from .select_path hook

2016-02-22 22:34:42 -05:00

dm-queue-length.c

dm path selector: remove 'repeat_count' return from .select_path hook

2016-02-22 22:34:42 -05:00

dm-raid1.c

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

dm-raid.c

md: always hold reconfig_mutex when calling mddev_suspend()

2018-07-08 15:30:49 +02:00

dm-region-hash.c

block: rename bio bi_rw to bi_opf

2016-08-07 14:41:02 -06:00

dm-round-robin.c

dm round robin: revert "use percpu 'repeat_count' and 'current_path'"

2017-02-17 00:54:09 -05:00

dm-rq.c

dm rq: do not update rq partially in each ending bio

2017-08-28 10:23:28 -04:00

dm-rq.h

dm rq: do not update rq partially in each ending bio

2017-08-28 10:23:28 -04:00

dm-service-time.c

dm path selector: remove 'repeat_count' return from .select_path hook

2016-02-22 22:34:42 -05:00

dm-snap-persistent.c

dm: make flush bios explicitly sync

2017-05-31 10:50:23 -04:00

dm-snap-transient.c

dm snapshot: fix hung bios when copy error occurs

2016-01-08 20:03:05 -05:00

dm-snap.c

dm: fix various targets to dm_register_target after module __init resources created

2017-12-20 10:10:21 +01:00

dm-stats.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

dm-stats.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

dm-stripe.c

Merge tag 'for-4.14/dm-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2017-09-14 13:43:16 -07:00

dm-switch.c

Merge tag 'for-4.14/dm-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2017-09-14 13:43:16 -07:00

dm-sysfs.c

dm: move request-based code out to dm-rq.[hc]

2016-06-10 15:15:44 -04:00

dm-table.c

dm: prevent DAX mounts if not supported

2018-07-11 16:29:23 +02:00

dm-target.c

dm: don't return errnos from ->map

2017-06-09 09:27:32 -06:00

dm-thin-metadata.c

dm thin metadata: THIN_MAX_CONCURRENT_LOCKS should be 6

2018-01-23 19:58:18 +01:00

dm-thin-metadata.h

dm thin: fix a race condition between discarding and provisioning a block

2016-07-20 12:43:35 -04:00

dm-thin.c

dm thin: stop no_space_timeout worker when switching to write-mode

2018-09-09 19:55:55 +02:00

dm-uevent.c

md: Add in export.h for files using EXPORT_SYMBOL

2011-10-31 19:31:19 -04:00

dm-uevent.h

dm: uevent generate events

2007-10-20 02:01:26 +01:00

dm-verity-fec.c

dm verity fec: fix GFP flags used with mempool_alloc()

2017-07-26 15:55:44 -04:00

dm-verity-fec.h

dm verity fec: limit error correction recursion

2017-03-16 09:37:31 -04:00

dm-verity-target.c

Merge tag 'for-4.14/dm-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2017-09-14 13:43:16 -07:00

dm-verity.h

dm verity: switch to using asynchronous hash crypto API

2017-04-24 15:37:04 -04:00

dm-zero.c

dm: don't return errnos from ->map

2017-06-09 09:27:32 -06:00

dm-zoned-metadata.c

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

dm-zoned-reclaim.c

dm zoned: use GFP_NOIO in I/O path

2017-07-26 15:55:43 -04:00

dm-zoned-target.c

dm zoned: avoid triggering reclaim from inside dmz_map()

2018-07-03 11:25:05 +02:00

dm-zoned.h

dm zoned: drive-managed zoned block device target

2017-06-19 11:05:20 -04:00

dm.c

dm: prevent DAX mounts if not supported

2018-07-11 16:29:23 +02:00

dm.h

dm: introduce enum dm_queue_mode to cleanup related code

2017-04-27 17:08:44 -04:00

faulty.c

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

Kconfig

dm zoned: drive-managed zoned block device target

2017-06-19 11:05:20 -04:00

linear.c

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

linear.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

md-cluster.c

md: remove special meaning of ->quiesce(.., 2)

2018-07-08 15:30:50 +02:00

md-cluster.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

md.c

md: fix NULL dereference of mddev->pers in remove_and_add_spares()

2018-08-03 07:50:33 +02:00

md.h

md: remove special meaning of ->quiesce(.., 2)

2018-07-08 15:30:50 +02:00

multipath.c

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

multipath.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

raid0.c

md: remove special meaning of ->quiesce(.., 2)

2018-07-08 15:30:50 +02:00

raid0.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

raid1-10.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

raid1.c

md/raid1: add error handling of read error from FailFast device

2018-08-03 07:50:33 +02:00

raid1.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

raid5-cache.c

md: remove special meaning of ->quiesce(.., 2)

2018-07-08 15:30:50 +02:00

raid5-log.h

md: remove special meaning of ->quiesce(.., 2)

2018-07-08 15:30:50 +02:00

raid5-ppl.c

raid5-ppl: check recovery_offset when performing ppl recovery

2017-12-20 10:10:36 +01:00

raid5.c

md: remove special meaning of ->quiesce(.., 2)

2018-07-08 15:30:50 +02:00

raid5.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

raid10.c

md/raid10: fix that replacement cannot complete recovery after reassemble

2018-08-24 13:09:08 +02:00

raid10.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00