Ritesh Harjani
8c472abaed
ext4: check for non-zero journal inum in ext4_calculate_overhead
commit f1eec3b0d0 upstream.
While calculating overhead for internal journal, also check
that j_inum shouldn't be 0. Otherwise we get below error with
xfstests generic/050 with external journal (XXX_LOGDEV config) enabled.
It could be simply reproduced with loop device with an external journal
and marking blockdev as RO before mounting.
[ 3337.146838] EXT4-fs error (device pmem1p2): ext4_get_journal_inode:4634: comm mount: inode #0: comm mount: iget: illegal inode #
------------[ cut here ]------------
generic_make_request: Trying to write to read-only block-device pmem1p2 (partno 2)
WARNING: CPU: 107 PID: 115347 at block/blk-core.c:788 generic_make_request_checks+0x6b4/0x7d0
CPU: 107 PID: 115347 Comm: mount Tainted: G L --------- -t - 4.18.0-167.el8.ppc64le #1
NIP: c0000000006f6d44 LR: c0000000006f6d40 CTR: 0000000030041dd4
<...>
NIP [c0000000006f6d44] generic_make_request_checks+0x6b4/0x7d0
LR [c0000000006f6d40] generic_make_request_checks+0x6b0/0x7d0
<...>
Call Trace:
generic_make_request_checks+0x6b0/0x7d0 (unreliable)
generic_make_request+0x3c/0x420
submit_bio+0xd8/0x200
submit_bh_wbc+0x1e8/0x250
__sync_dirty_buffer+0xd0/0x210
ext4_commit_super+0x310/0x420 [ext4]
__ext4_error+0xa4/0x1e0 [ext4]
__ext4_iget+0x388/0xe10 [ext4]
ext4_get_journal_inode+0x40/0x150 [ext4]
ext4_calculate_overhead+0x5a8/0x610 [ext4]
ext4_fill_super+0x3188/0x3260 [ext4]
mount_bdev+0x778/0x8f0
ext4_mount+0x28/0x50 [ext4]
mount_fs+0x74/0x230
vfs_kern_mount.part.6+0x6c/0x250
do_mount+0x2fc/0x1280
sys_mount+0x158/0x180
system_call+0x5c/0x70
EXT4-fs (pmem1p2): no journal found
EXT4-fs (pmem1p2): can't get journal size
EXT4-fs (pmem1p2): mounted filesystem without journal. Opts: dax,norecovery
Fixes: 3c816ded78 ("ext4: use journal inode to determine journal overhead")
Reported-by: Harish Sriram <harish@linux.ibm.com>
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20200316093038.25485-1-riteshh@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-05-02 08:49:01 +02:00
..
2019-09-27 15:10:34 -07:00
2019-07-19 11:33:22 -07:00
2020-01-17 19:48:50 +01:00
2020-05-02 08:48:55 +02:00
2019-10-25 00:03:11 -04:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2020-04-23 10:36:34 +02:00
2019-05-24 17:27:11 +02:00
2020-04-29 16:32:58 +02:00
2020-04-29 16:33:19 +02:00
2019-09-19 09:42:37 -07:00
2020-02-11 04:35:12 -08:00
2019-11-23 21:44:49 -05:00
2020-03-18 07:17:53 +01:00
2020-04-17 10:50:02 +02:00
2019-09-03 09:30:56 -04:00
2019-07-12 17:37:53 -07:00
2020-02-28 17:22:26 +01:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:17 -07:00
2020-04-17 10:50:16 +02:00
2019-11-10 11:56:05 -05:00
2020-04-23 10:36:41 +02:00
2020-05-02 08:49:01 +02:00
2020-04-29 16:32:55 +02:00
2020-03-12 13:00:19 +01:00
2019-08-30 07:27:17 -07:00
2019-07-10 18:43:43 -07:00
2020-03-18 07:17:52 +01:00
2020-04-17 10:50:03 +02:00
2019-05-21 10:50:46 +02:00
2020-04-17 10:50:22 +02:00
2019-05-12 17:52:13 -04:00
2019-08-30 08:11:25 -07:00
2020-01-04 19:19:19 +01:00
2020-01-04 19:17:31 +01:00
2019-09-19 09:42:37 -07:00
2020-04-21 09:04:52 +02:00
2019-12-04 22:31:06 +01:00
2019-09-19 09:42:37 -07:00
2019-12-13 08:42:53 +01:00
2019-07-03 17:52:09 -04:00
2019-08-30 07:27:17 -07:00
2020-04-23 10:36:38 +02:00
2019-05-21 10:50:46 +02:00
2020-05-02 08:48:46 +02:00
2019-07-01 08:25:34 -07:00
2019-05-21 10:50:46 +02:00
2020-01-12 12:21:38 +01:00
2020-02-11 04:35:12 -08:00
2020-04-17 10:50:21 +02:00
2019-08-30 08:11:25 -07:00
2019-07-19 10:42:02 -07:00
2020-02-24 08:37:02 +01:00
2020-04-21 09:04:50 +02:00
2020-04-29 16:33:14 +02:00
2020-04-17 10:50:12 +02:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2020-01-12 12:21:37 +01:00
2019-09-12 21:05:34 -04:00
2020-02-24 08:37:00 +01:00
2019-09-19 10:06:57 -07:00
2019-09-19 10:06:57 -07:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:18 -07:00
2019-10-12 20:49:07 -04:00
2020-05-02 08:48:42 +02:00
2020-02-24 08:36:44 +01:00
2019-09-19 09:42:37 -07:00
2019-09-17 11:48:24 -04:00
2019-08-12 19:33:50 -07:00
2020-05-02 08:48:56 +02:00
2020-02-11 04:35:37 -08:00
2019-07-19 10:42:02 -07:00
2020-02-11 04:35:12 -08:00
2019-05-21 10:50:45 +02:00
2019-05-30 11:26:32 -07:00
2019-10-06 13:53:27 -07:00
2019-05-21 10:50:45 +02:00
2019-07-16 19:23:22 -07:00
2019-07-19 10:42:02 -07:00
2019-05-21 10:50:45 +02:00
2020-04-23 10:36:34 +02:00
2020-04-23 10:36:15 +02:00
2020-01-14 20:08:18 +01:00
2019-05-30 11:29:21 -07:00
2020-01-09 10:20:05 +01:00
2019-06-19 17:09:55 +02:00
2020-04-29 16:33:14 +02:00
2019-08-30 19:31:09 -04:00
2020-03-05 16:43:36 +01:00
2019-07-20 09:15:51 -07:00
2019-05-21 10:50:45 +02:00
2019-10-14 15:04:01 -07:00
2020-01-12 12:21:37 +01:00
2020-02-11 04:35:37 -08:00
2020-03-25 08:25:57 +01:00
2020-04-17 10:50:12 +02:00
2019-08-07 21:51:47 -04:00
2019-08-19 11:00:39 -04:00
2020-04-17 10:50:21 +02:00
2019-09-06 21:28:49 +02:00
2019-09-12 21:06:14 -04:00
2019-07-16 22:52:37 -04:00
2019-05-21 10:50:45 +02:00
2020-02-11 04:35:11 -08:00
2019-07-19 10:42:02 -07:00
2020-03-25 08:25:58 +01:00
2020-01-17 19:48:21 +01:00
2020-04-17 10:50:16 +02:00
2019-12-17 19:55:30 +01:00
2019-09-18 16:59:14 -07:00
2019-06-24 09:16:47 +10:00
2020-04-01 11:02:17 +02:00
2020-03-25 08:25:41 +01:00
2019-09-18 16:59:14 -07:00
2019-05-21 10:50:45 +02:00
2019-07-16 22:52:37 -04:00
2020-01-17 19:48:21 +01:00
2020-03-05 16:43:48 +01:00
2019-10-16 23:15:09 -04:00
2019-05-30 11:26:32 -07:00
2019-05-25 18:00:06 -04:00
2020-03-18 07:17:51 +01:00
2019-05-25 18:00:07 -04:00
2020-05-02 08:48:44 +02:00
2019-05-30 11:29:53 -07:00
2019-05-21 10:50:45 +02:00
2019-09-06 21:28:49 +02:00
2020-02-11 04:35:23 -08:00
2020-01-29 16:45:31 +01:00
2019-07-16 19:23:25 -07:00
2019-08-13 16:06:52 -07:00
2019-12-17 19:56:52 +01:00
2019-05-21 10:50:45 +02:00
2019-10-03 14:21:35 -07:00
2020-01-12 12:21:38 +01:00
2019-05-14 09:47:50 -07:00
2019-08-01 20:51:23 +02:00
2020-01-04 19:18:32 +01:00
2020-02-11 04:35:12 -08:00
2019-05-21 10:50:45 +02:00