mirror of
https://github.com/hardkernel/linux.git
synced 2026-03-25 12:00:22 +09:00
997e954bb0
Ages ago Rob Clark noted, "Currently with fence-array, we have a potential deadlock situation. If we fence_add_callback() on an array-fence, the array-fence's lock is acquired first, and in it's ->enable_signaling() callback, it will install cbs on it's array-member fences, so the array-member's lock is acquired second. But in the signal path, the array-member's lock is acquired first, and the array-fence's lock acquired second." Rob proposed either extensive changes to dma-fence to unnest the fence-array signaling, or to defer the signaling onto a workqueue. This is a more refined version of the later, that should keep the latency of the fence signaling to a minimum by using an irq-work, which is executed asap. Reported-by: Rob Clark <robdclark@gmail.com> Suggested-by: Rob Clark <robdclark@gmail.com> References: 1476635975-21981-1-git-send-email-robdclark@gmail.com Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Rob Clark <robdclark@gmail.com> Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Christian König <christian.koenig@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20171114162719.30958-1-chris@chris-wilson.co.uk Signed-off-by: Jiyu Yang <Jiyu.Yang@amlogic.com> Change-Id: Ia08cb17615ff15b18c208cff2000d92344c9f399
87 lines
2.3 KiB
C
87 lines
2.3 KiB
C
/*
|
|
* fence-array: aggregates fence to be waited together
|
|
*
|
|
* Copyright (C) 2016 Collabora Ltd
|
|
* Copyright (C) 2016 Advanced Micro Devices, Inc.
|
|
* Authors:
|
|
* Gustavo Padovan <gustavo@padovan.org>
|
|
* Christian König <christian.koenig@amd.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License version 2 as published by
|
|
* the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*/
|
|
|
|
#ifndef __LINUX_FENCE_ARRAY_H
|
|
#define __LINUX_FENCE_ARRAY_H
|
|
|
|
#include <linux/fence.h>
|
|
#include <linux/irq_work.h>
|
|
|
|
/**
|
|
* struct fence_array_cb - callback helper for fence array
|
|
* @cb: fence callback structure for signaling
|
|
* @array: reference to the parent fence array object
|
|
*/
|
|
struct fence_array_cb {
|
|
struct fence_cb cb;
|
|
struct fence_array *array;
|
|
};
|
|
|
|
/**
|
|
* struct fence_array - fence to represent an array of fences
|
|
* @base: fence base class
|
|
* @lock: spinlock for fence handling
|
|
* @num_fences: number of fences in the array
|
|
* @num_pending: fences in the array still pending
|
|
* @fences: array of the fences
|
|
*/
|
|
struct fence_array {
|
|
struct fence base;
|
|
|
|
spinlock_t lock;
|
|
unsigned num_fences;
|
|
atomic_t num_pending;
|
|
struct fence **fences;
|
|
|
|
struct irq_work work;
|
|
};
|
|
|
|
extern const struct fence_ops fence_array_ops;
|
|
|
|
/**
|
|
* fence_is_array - check if a fence is from the array subsclass
|
|
*
|
|
* Return true if it is a fence_array and false otherwise.
|
|
*/
|
|
static inline bool fence_is_array(struct fence *fence)
|
|
{
|
|
return fence->ops == &fence_array_ops;
|
|
}
|
|
|
|
/**
|
|
* to_fence_array - cast a fence to a fence_array
|
|
* @fence: fence to cast to a fence_array
|
|
*
|
|
* Returns NULL if the fence is not a fence_array,
|
|
* or the fence_array otherwise.
|
|
*/
|
|
static inline struct fence_array *to_fence_array(struct fence *fence)
|
|
{
|
|
if (fence->ops != &fence_array_ops)
|
|
return NULL;
|
|
|
|
return container_of(fence, struct fence_array, base);
|
|
}
|
|
|
|
struct fence_array *fence_array_create(int num_fences, struct fence **fences,
|
|
u64 context, unsigned seqno,
|
|
bool signal_on_any);
|
|
|
|
#endif /* __LINUX_FENCE_ARRAY_H */
|