Ben Hutchings 13ffe47637 PCI: sysfs: Fix failure path for addition of "vpd" attribute ...

commit 0f12a4e293 upstream.

Commit 280c73d ("PCI: centralize the capabilities code in
pci-sysfs.c") changed the initialisation of the "rom" and "vpd"
attributes, and made the failure path for the "vpd" attribute
incorrect.  We must free the new attribute structure (attr), but
instead we currently free dev->vpd->attr.  That will normally be NULL,
resulting in a memory leak, but it might be a stale pointer, resulting
in a double-free.

Found by inspection; compile-tested only.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2011-03-23 13:16:50 -07:00

..

hotplug

PCI hotplug: check ioremap() return value in ibmphp_ebda.c

2010-03-15 08:49:35 -07:00

pcie

PCI: fix nested spinlock hang in aer_inject

2010-04-26 07:41:31 -07:00

.gitignore

…

access.c

PCI: Add pci_bus_set_ops

2009-06-16 14:29:33 -07:00

bus.c

PCI AER: support Multiple Error Received and no error source id

2009-06-16 14:30:13 -07:00

dmar.c

x86, vt-d: Handle previous faults after enabling fault handling

2011-01-07 14:43:11 -08:00

hotplug-pci.c

PCI: fix section mismatch warning in pci_scan_child_bus

2008-03-04 15:07:03 -08:00

hotplug.c

Driver core: change add_uevent_var to use a struct

2007-10-12 14:51:01 -07:00

htirq.c

Merge branch 'x86/apic' into irq/numa

2009-05-12 12:17:36 +02:00

intel-iommu.c

drivers/pci/intel-iommu.c: fix build with older gcc's

2010-09-26 17:21:26 -07:00

intr_remapping.c

Merge git://git.infradead.org/iommu-2.6

2009-09-23 10:06:10 -07:00

intr_remapping.h

Intel-IOMMU, intr-remap: source-id checking

2009-06-23 22:09:17 +01:00

iov.c

PCI SR-IOV: correct broken resource alignment calculations

2009-08-30 08:37:25 -07:00

iova.c

intel-iommu: Remove superfluous iova_alloc_lock from IOVA code

2009-07-15 08:17:02 +01:00

irq.c

PCI: struct device - replace bus_id with dev_name(), dev_set_name()

2009-01-07 11:12:23 -08:00

Kconfig

PCI: initialize and release SR-IOV capability

2009-03-20 10:48:22 -07:00

legacy.c

PCI: disable pci_find_device warnings when deprecated pci functions are enabled

2009-09-09 13:29:25 -07:00

Makefile

PCI: disable pci_find_device warnings when deprecated pci functions are enabled

2009-09-09 13:29:25 -07:00

msi.c

PCI: MSI: Restore read_msi_msg_desc(); add get_cached_msi_msg_desc()

2010-09-20 13:17:44 -07:00

msi.h

PCI MSI: shorten PCI_MSIX_ENTRY_* symbol names

2009-06-29 12:15:19 -07:00

pci-acpi.c

PCI / ACPI PM: Propagate wake-up enable for devices w/o ACPI support

2009-09-09 14:19:24 -07:00

pci-driver.c

Merge branch 'linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6

2009-09-16 07:49:54 -07:00

pci-stub.c

PCI: pci-stub: ignore zero-length id parameters

2011-02-17 15:37:01 -08:00

pci-sysfs.c

PCI: sysfs: Fix failure path for addition of "vpd" attribute

2011-03-23 13:16:50 -07:00

pci.c

virtio-pci: disable msi at startup

2010-08-02 10:20:42 -07:00

pci.h

PCI: fix size checks for mmap() on /proc/bus/pci files

2010-12-09 13:26:53 -08:00

probe.c

PCI: Clear saved_state after the state has been restored

2009-09-14 13:41:46 -07:00

proc.c

PCI: fix size checks for mmap() on /proc/bus/pci files

2010-12-09 13:26:53 -08:00

quirks.c

PCI: do not create quirk I/O regions below PCIBIOS_MIN_IO for ICH

2011-03-23 13:16:49 -07:00

remove.c

PCI: eliminate redundant pci_stop_dev() call from pci_destroy_dev()

2009-06-11 12:04:19 -07:00

rom.c

PCI: fix rom.c kernel-doc warning

2009-02-13 12:01:56 -08:00

search.c

PCI: disable pci_find_device warnings when deprecated pci functions are enabled

2009-09-09 13:29:25 -07:00

setup-bus.c

PCI: Always set prefetchable base/limit upper32 registers

2010-01-28 15:01:15 -08:00

setup-irq.c

PCI: use dev_printk when possible

2008-06-25 16:05:13 -07:00

setup-res.c

PCI: remove pci_assign_resource_fixed()

2009-10-06 09:42:04 -07:00

slot.c

PCI: fix kernel-doc warnings

2009-06-29 12:13:56 -07:00

syscall.c

headers: smp_lock.h redux

2009-07-12 12:22:34 -07:00