Eric Dumazet e033155d0b net: fix a potential rcu_read_lock() imbalance in rt6_fill_node() ...

[ Upstream commit 94f826b807 ]

Commit f2c31e32b3 (net: fix NULL dereferences in check_peer_redir() )
added a regression in rt6_fill_node(), leading to rcu_read_lock()
imbalance.

Thats because NLA_PUT() can make a jump to nla_put_failure label.

Fix this by using nla_put()

Many thanks to Ben Greear for his help

Reported-by: Ben Greear <greearb@candelatech.com>
Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2012-04-02 09:27:20 -07:00

..

netfilter

netfilter: fix looped (broad|multi)cast's MAC handling

2011-06-16 17:27:04 +02:00

addrconf_core.c

ipv6: Remove IPV6_ADDR_RESERVED

2010-02-26 03:59:07 -08:00

addrconf.c

IPv6: Fix not join all-router mcast group when forwarding set.

2012-03-19 08:57:46 -07:00

addrlabel.c

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

2010-09-27 01:03:03 -07:00

af_inet6.c

ipv6: make fragment identifications less predictable

2011-08-15 18:31:37 -07:00

ah6.c

ah: Don't return NET_XMIT_DROP on input.

2012-02-03 09:18:54 -08:00

anycast.c

inet: constify ip headers and in6_addr

2011-04-22 11:04:14 -07:00

datagram.c

net: Put fl6_* macros to struct flowi6 and use them again.

2011-03-12 15:08:55 -08:00

esp6.c

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

2011-05-05 14:59:02 -07:00

exthdrs_core.c

net: return operator cleanup

2010-09-23 14:33:39 -07:00

exthdrs.c

ipv6: Convert to use flowi6 where applicable.

2011-03-12 15:08:54 -08:00

fib6_rules.c

ipv6: Convert to use flowi6 where applicable.

2011-03-12 15:08:54 -08:00

icmp.c

inet: constify ip headers and in6_addr

2011-04-22 11:04:14 -07:00

inet6_connection_sock.c

inet: Pass flowi to ->queue_xmit().

2011-05-08 15:28:28 -07:00

inet6_hashtables.c

net: Compute protocol sequence numbers and fragment IDs using MD5.

2011-08-15 18:31:35 -07:00

ip6_fib.c

net: fix NULL dereferences in check_peer_redir()

2012-02-13 11:06:13 -08:00

ip6_flowlabel.c

ipv6: Convert to use flowi6 where applicable.

2011-03-12 15:08:54 -08:00

ip6_input.c

inet: constify ip headers and in6_addr

2011-04-22 11:04:14 -07:00

ip6_output.c

net: fix NULL dereferences in check_peer_redir()

2012-02-13 11:06:13 -08:00

ip6_tunnel.c

ip6_tunnel: copy parms.name after register_netdevice

2011-11-26 09:09:55 -08:00

ip6mr.c

ipv6-multicast: Fix memory leak in IPv6 multicast.

2012-02-29 16:33:51 -08:00

ipcomp6.c

inet: constify ip headers and in6_addr

2011-04-22 11:04:14 -07:00

ipv6_sockglue.c

ipv6: Fix ipv6_getsockopt for IPV6_2292PKTOPTIONS

2011-10-03 11:40:52 -07:00

Kconfig

ipv6: ip6mr: support multiple tables

2010-05-11 14:40:55 +02:00

Makefile

[IPV6] MROUTE: Support multicast forwarding.

2008-04-05 22:33:38 +09:00

mcast.c

ipv6: Don't dev_hold(dev) in ip6_mc_find_dev_rcu.

2012-03-23 11:20:52 -07:00

mip6.c

inet: constify ip headers and in6_addr

2011-04-22 11:04:14 -07:00

ndisc.c

net: fix NULL dereferences in check_peer_redir()

2012-02-13 11:06:13 -08:00

netfilter.c

inet: constify ip headers and in6_addr

2011-04-22 11:04:14 -07:00

proc.c

ipv6: reduce per device ICMP mib sizes

2011-05-19 16:21:22 -04:00

protocol.c

net: add __rcu annotations to protocol

2010-10-27 11:37:31 -07:00

raw.c

net: convert %p usage to %pK

2011-05-24 01:13:12 -04:00

reassembly.c

inet: constify ip headers and in6_addr

2011-04-22 11:04:14 -07:00

route.c

net: fix a potential rcu_read_lock() imbalance in rt6_fill_node()

2012-04-02 09:27:20 -07:00

sit.c

net: fix NULL dereferences in check_peer_redir()

2012-02-13 11:06:13 -08:00

syncookies.c

tcp: initialize variable ecn_ok in syncookies path

2011-10-03 11:40:54 -07:00

sysctl_net_ipv6.c

net ipv6: Fix duplicate /proc/sys/net/ipv6/neigh directory entries.

2011-03-21 18:23:34 -07:00

tcp_ipv6.c

tcp: md5: using remote adress for md5 lookup in rst packet

2012-02-03 09:19:04 -08:00

tunnel6.c

tunnels: add _rcu annotations

2010-10-25 13:09:45 -07:00

udp_impl.h

net: Make setsockopt() optlen be unsigned.

2009-09-30 16:12:20 -07:00

udp.c

ipv6: fix NULL dereference in udp6_ufo_fragment()

2011-10-16 14:14:54 -07:00

udplite.c

net: fix nulls list corruptions in sk_prot_alloc

2010-12-16 14:26:56 -08:00

xfrm6_input.c

netfilter: ipv6: use NFPROTO values for NF_HOOK invocation

2010-03-25 16:00:49 +01:00

xfrm6_mode_beet.c

ipsec: be careful of non existing mac headers

2012-03-19 08:57:45 -07:00

xfrm6_mode_ro.c

[IPSEC]: Make x->lastused an unsigned long

2008-01-28 14:53:52 -08:00

xfrm6_mode_transport.c

…

xfrm6_mode_tunnel.c

ipsec: be careful of non existing mac headers

2012-03-19 08:57:45 -07:00

xfrm6_output.c

xfrm: Assign the inner mode output function to the dst entry

2011-05-10 15:03:34 -07:00

xfrm6_policy.c

inet: constify ip headers and in6_addr

2011-04-22 11:04:14 -07:00

xfrm6_state.c

xfrm: Assign the inner mode output function to the dst entry

2011-05-10 15:03:34 -07:00

xfrm6_tunnel.c

ipv6: Fix return of xfrm6_tunnel_rcv()

2011-05-24 01:11:51 -04:00