Files
linux/fs/xfs
Mark Tinguely 1fe36ec491 xfs: fix node forward in xfs_node_toosmall
commit 997def25e4 upstream.

Commit f5ea1100 cleans up the disk to host conversions for
node directory entries, but because a variable is reused in
xfs_node_toosmall() the next node is not correctly found.
If the original node is small enough (<= 3/8 of the node size),
this change may incorrectly cause a node collapse when it should
not. That will cause an assert in xfstest generic/319:

   Assertion failed: first <= last && last < BBTOB(bp->b_length),
   file: /root/newest/xfs/fs/xfs/xfs_trans_buf.c, line: 569

Keep the original node header to get the correct forward node.

(When a node is considered for a merge with a sibling, it overwrites the
 sibling pointers of the original incore nodehdr with the sibling's
 pointers.  This leads to loop considering the original node as a merge
 candidate with itself in the second pass, and so it incorrectly
 determines a merge should occur.)

[v3: added Dave Chinner's (slightly modified) suggestion to the commit header,
	cleaned up whitespace.  -bpm]

Signed-off-by: Mark Tinguely <tinguely@sgi.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-13 16:08:34 -07:00
..
2013-05-07 18:45:36 -05:00
2013-04-27 12:49:32 -05:00
2013-05-07 18:45:36 -05:00
2011-08-12 16:21:35 -05:00
2011-08-12 16:21:35 -05:00
2012-11-19 20:11:24 -06:00
2013-04-21 14:57:43 -05:00
2013-05-30 17:26:31 -05:00
2013-05-30 17:26:31 -05:00
2013-05-07 18:45:36 -05:00
2013-05-30 17:26:31 -05:00
2012-11-19 20:11:24 -06:00
2011-07-13 13:43:48 +02:00
2011-08-12 16:21:35 -05:00
2011-08-12 16:21:35 -05:00
2013-06-06 10:50:35 -05:00
2011-03-07 10:09:35 +11:00
2011-08-12 16:21:35 -05:00
2013-05-07 20:16:25 -07:00
2012-05-14 16:20:54 -05:00
2011-08-12 16:21:35 -05:00
2011-08-12 16:21:35 -05:00
2010-12-16 16:05:51 -06:00
2011-08-12 16:21:35 -05:00
2013-05-07 18:45:36 -05:00
2013-05-07 18:45:36 -05:00
2013-05-07 18:45:36 -05:00
2013-06-06 10:50:35 -05:00
2013-04-21 14:58:22 -05:00
2013-06-06 10:50:35 -05:00
2012-09-18 01:01:39 -07:00
2013-04-27 13:05:18 -05:00
2012-10-17 12:01:25 -05:00
2013-05-07 18:45:36 -05:00
2012-01-03 22:55:00 -05:00
2011-08-12 16:21:35 -05:00
2013-05-07 18:45:36 -05:00