Files
linux/drivers/usb/gadget
Michal Nazarewicz 4882c04833 usb: gadget: f_fs: fix NULL pointer dereference when there are no strings
commit f0688c8b81 upstream.

If the descriptors do not need any strings and user space sends empty
set of strings, the ffs->stringtabs field remains NULL.  Thus
*ffs->stringtabs in functionfs_bind leads to a NULL pointer
dereferenece.

The bug was introduced by commit [fd7c9a007f: “use usb_string_ids_n()”].

While at it, remove double initialisation of lang local variable in
that function.

ffs->strings_count does not need to be checked in any way since in
the above scenario it will remain zero and usb_string_ids_n() is
a no-operation when colled with 0 argument.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09 11:14:00 -07:00
..
2013-05-05 00:16:11 -04:00
2013-05-05 00:16:11 -04:00
2012-11-21 13:27:17 -08:00
2013-04-03 21:02:47 +03:00
2013-02-22 23:31:31 -05:00
2013-04-09 14:13:32 -04:00