Files
odroid-linux/include/linux
Kefeng Wang 1027b96ec9 once: Fix panic when module unload
DO_ONCE
DEFINE_STATIC_KEY_TRUE(___once_key);
__do_once_done
  once_disable_jump(once_key);
    INIT_WORK(&w->work, once_deferred);
    struct once_work *w;
    w->key = key;
    schedule_work(&w->work);                     module unload
                                                   //*the key is
destroy*
process_one_work
  once_deferred
    BUG_ON(!static_key_enabled(work->key));
       static_key_count((struct static_key *)x)    //*access key, crash*

When module uses DO_ONCE mechanism, it could crash due to the above
concurrency problem, we could reproduce it with link[1].

Fix it by add/put module refcount in the once work process.

[1] https://lore.kernel.org/netdev/eaa6c371-465e-57eb-6be9-f4b16b9d7cbf@huawei.com/

Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Reported-by: Minmin chen <chenmingmin@huawei.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-08-08 13:00:20 +01:00
..
2021-02-02 00:16:57 +01:00
2021-07-06 20:14:42 -04:00
2021-06-03 18:40:15 +02:00
2021-06-03 14:04:18 -07:00
2021-01-23 14:57:21 +01:00
2021-05-06 19:24:11 -07:00
2021-04-14 16:30:30 +03:00
2021-05-24 21:13:05 -07:00
2020-12-02 09:46:55 -07:00
2021-01-24 14:27:17 +01:00
2021-02-26 09:41:03 -08:00
2021-04-08 16:04:20 -07:00
2021-01-21 14:06:00 -07:00
2021-06-30 19:45:42 +02:00
2021-01-18 14:26:51 +01:00
2021-03-22 03:57:39 +01:00
2020-12-10 12:42:59 -06:00
2021-04-12 15:04:23 +02:00
2020-11-16 16:31:41 +01:00
2021-06-25 19:57:01 -04:00
2020-11-16 15:20:01 +01:00
2021-02-11 13:24:44 -08:00
2020-12-02 22:10:35 -08:00
2021-04-30 11:20:40 -07:00
2020-11-23 14:16:55 +00:00
2021-06-29 10:53:48 -07:00
2020-11-24 16:47:48 +01:00
2021-05-17 20:01:35 +02:00
2021-07-15 10:13:49 -07:00
2020-12-15 16:19:31 +01:00
2021-01-21 16:16:10 +00:00
2021-02-26 09:41:02 -08:00
2021-06-01 10:29:21 +01:00
2021-02-26 09:41:03 -08:00
2021-05-12 20:11:17 +02:00
2021-06-17 13:09:27 -04:00
2021-06-15 17:46:57 +02:00
2021-07-01 11:06:02 -07:00
2021-08-03 11:14:03 +01:00
2021-06-29 10:53:53 -07:00
2021-07-01 11:06:05 -07:00
2021-08-08 13:00:20 +01:00
2021-02-26 09:40:59 -08:00
2021-02-03 19:05:50 +01:00
2021-07-06 10:37:46 -05:00
2021-06-16 17:20:40 -05:00
2021-07-06 10:37:46 -05:00
2021-07-06 10:37:46 -05:00
2021-07-06 10:37:46 -05:00
2021-06-12 13:08:57 -07:00
2020-10-18 09:27:10 -07:00
2021-06-07 14:11:47 -07:00
2021-01-24 14:27:17 +01:00
2021-01-24 14:27:20 +01:00
2021-03-06 12:40:22 +01:00
2021-02-26 09:41:03 -08:00
2021-06-30 19:12:19 +02:00
2020-12-03 11:20:52 +01:00
2021-03-17 14:16:15 -05:00
2021-01-16 23:19:26 +01:00
2021-03-22 02:45:52 +01:00
2021-03-18 12:58:27 -04:00
2020-12-10 16:17:15 +01:00
2020-12-10 10:45:36 +01:00
2021-05-10 16:03:35 -07:00
2021-06-24 15:49:32 +02:00
2021-07-01 11:06:03 -07:00
2021-07-01 11:06:03 -07:00
2021-03-19 04:58:25 +00:00
2021-03-25 17:39:33 -07:00
2021-05-21 22:13:13 +02:00
2020-10-30 21:57:04 +01:00
2021-05-13 18:29:11 +02:00
2021-05-13 16:57:17 +02:00
2021-02-13 17:17:53 +01:00
2021-03-30 17:06:49 -07:00
2020-11-09 18:39:36 +01:00
2021-01-21 16:16:10 +00:00
2021-03-22 15:02:14 +01:00
2021-02-09 12:15:07 +01:00
2021-01-21 14:06:00 -07:00
2021-03-30 13:42:33 -04:00
2021-01-24 14:27:17 +01:00
2021-02-08 22:58:55 +01:00