Files
odroid-linux/include/linux
Ingo Molnar 2055da9738 sched/wait: Disambiguate wq_entry->task_list and wq_head->task_list naming
So I've noticed a number of instances where it was not obvious from the
code whether ->task_list was for a wait-queue head or a wait-queue entry.

Furthermore, there's a number of wait-queue users where the lists are
not for 'tasks' but other entities (poll tables, etc.), in which case
the 'task_list' name is actively confusing.

To clear this all up, name the wait-queue head and entry list structure
fields unambiguously:

	struct wait_queue_head::task_list	=> ::head
	struct wait_queue_entry::task_list	=> ::entry

For example, this code:

	rqw->wait.task_list.next != &wait->task_list

... is was pretty unclear (to me) what it's doing, while now it's written this way:

	rqw->wait.head.next != &wait->entry

... which makes it pretty clear that we are iterating a list until we see the head.

Other examples are:

	list_for_each_entry_safe(pos, next, &x->task_list, task_list) {
	list_for_each_entry(wq, &fence->wait.task_list, task_list) {

... where it's unclear (to me) what we are iterating, and during review it's
hard to tell whether it's trying to walk a wait-queue entry (which would be
a bug), while now it's written as:

	list_for_each_entry_safe(pos, next, &x->head, entry) {
	list_for_each_entry(wq, &fence->wait.head, entry) {

Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-06-20 12:19:14 +02:00
..
2017-04-21 10:45:01 -04:00
2016-12-22 22:58:37 -05:00
2017-04-28 18:09:59 -04:00
2017-05-01 14:09:21 -07:00
2017-02-10 15:52:24 -05:00
2017-06-14 13:27:50 -06:00
2017-01-25 13:17:47 -05:00
2017-04-11 14:38:43 -04:00
2017-04-26 23:54:06 -04:00
2017-03-30 09:37:20 +02:00
2017-05-24 12:43:30 -04:00
2017-04-18 20:41:12 +02:00
2017-04-10 17:15:02 +02:00
2017-04-27 05:13:04 -04:00
2017-05-25 13:44:28 -04:00
2016-12-25 17:21:22 +01:00
2017-03-21 10:15:47 +02:00
2017-04-05 18:11:48 +02:00
2017-02-11 20:59:41 -05:00
2017-05-08 17:15:12 -07:00
2017-01-05 15:01:55 -06:00
2017-05-03 15:52:10 -07:00
2016-12-25 17:21:23 +01:00
2017-02-24 17:46:57 -08:00
2017-06-19 21:50:20 +08:00
2017-04-24 14:30:46 -04:00
2017-01-12 16:48:26 -05:00
2017-04-26 13:03:04 -04:00
2017-03-07 14:01:02 -08:00
2017-05-09 16:43:23 +03:00
2017-02-13 21:44:09 -05:00
2017-03-28 08:54:48 +02:00
2017-05-03 15:52:10 -07:00
2017-05-08 17:15:12 -07:00
2017-03-26 15:09:45 +02:00
2017-01-09 16:07:38 -05:00
2016-12-26 23:53:46 -05:00
2017-03-22 12:15:15 -07:00
2017-03-09 15:42:33 +01:00
2017-01-10 18:31:55 -08:00
2017-02-10 16:34:17 +00:00
2017-05-09 16:43:22 +03:00