Files
odroid-linux/include/linux
Konstantin Khlebnikov 2b8bd42361 block/diskstats: more accurate approximation of io_ticks for slow disks
Currently io_ticks is approximated by adding one at each start and end of
requests if jiffies counter has changed. This works perfectly for requests
shorter than a jiffy or if one of requests starts/ends at each jiffy.

If disk executes just one request at a time and they are longer than two
jiffies then only first and last jiffies will be accounted.

Fix is simple: at the end of request add up into io_ticks jiffies passed
since last update rather than just one jiffy.

Example: common HDD executes random read 4k requests around 12ms.

fio --name=test --filename=/dev/sdb --rw=randread --direct=1 --runtime=30 &
iostat -x 10 sdb

Note changes of iostat's "%util" 8,43% -> 99,99% before/after patch:

Before:

Device:         rrqm/s   wrqm/s     r/s     w/s    rkB/s    wkB/s avgrq-sz avgqu-sz   await r_await w_await  svctm  %util
sdb               0,00     0,00   82,60    0,00   330,40     0,00     8,00     0,96   12,09   12,09    0,00   1,02   8,43

After:

Device:         rrqm/s   wrqm/s     r/s     w/s    rkB/s    wkB/s avgrq-sz avgqu-sz   await r_await w_await  svctm  %util
sdb               0,00     0,00   82,50    0,00   330,00     0,00     8,00     1,00   12,10   12,10    0,00  12,12  99,99

Now io_ticks does not loose time between start and end of requests, but
for queue-depth > 1 some I/O time between adjacent starts might be lost.

For load estimation "%util" is not as useful as average queue length,
but it clearly shows how often disk queue is completely empty.

Fixes: 5b18b5a737 ("block: delete part_round_stats and switch to less precise counting")
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2020-03-25 08:49:08 -06:00
..
2019-08-09 09:15:05 +02:00
2019-09-16 09:56:27 -07:00
2019-12-11 09:12:38 +01:00
2019-11-12 11:43:29 -05:00
2020-01-27 14:35:32 +01:00
2020-01-23 12:37:18 +00:00
2019-05-14 19:52:50 -07:00
2020-02-04 03:05:26 +00:00
2020-02-04 03:05:26 +00:00
2019-06-12 20:27:13 +02:00
2019-11-26 10:26:26 +01:00
2020-01-23 00:35:50 +01:00
2020-03-04 13:46:03 +01:00
2019-10-09 19:33:43 -07:00
2019-12-03 11:20:37 +01:00
2019-09-05 19:52:33 -06:00
2019-02-28 03:28:53 -05:00
2020-01-27 11:09:31 +01:00
2020-01-17 16:48:07 -08:00
2020-01-18 09:19:18 -05:00
2020-01-13 21:48:42 +01:00
2020-03-24 07:57:07 -06:00
2019-11-20 09:40:10 +01:00
2019-12-01 12:59:06 -08:00
2019-09-05 11:40:54 +02:00
2019-07-05 21:34:50 +02:00
2019-06-26 13:19:46 -07:00
2019-10-04 12:31:46 -07:00
2019-10-15 13:34:25 +02:00
2019-11-11 09:02:56 +01:00
2019-06-10 13:00:24 +02:00
2019-12-04 19:44:14 -08:00
2020-01-31 17:33:54 +00:00
2019-12-11 09:12:38 +01:00
2019-09-02 11:43:54 +01:00
2019-10-15 20:40:06 -07:00
2019-03-07 18:32:03 -08:00
2019-09-05 12:32:05 +02:00
2019-12-09 10:55:03 +01:00
2019-08-14 15:30:35 +02:00
2019-08-08 09:09:25 +02:00
2019-11-14 19:06:47 -08:00
2020-01-15 10:54:33 -05:00
2020-01-14 12:20:48 +01:00
2019-06-13 09:02:33 -04:00
2019-12-11 16:37:02 +08:00
2019-11-13 19:09:47 +08:00
2020-01-16 17:09:18 +01:00
2020-01-15 16:30:28 +00:00
2020-01-29 17:00:02 -06:00
2019-07-16 19:23:25 -07:00
2019-12-06 10:47:28 +01:00
2019-06-15 12:25:49 +02:00
2019-05-14 19:52:48 -07:00
2020-01-13 18:16:43 -08:00
2020-01-10 14:00:58 -08:00
2020-01-24 10:24:31 -08:00
2020-01-24 10:24:31 -08:00
2019-11-14 13:07:48 +08:00
2019-10-10 14:55:24 -07:00
2020-02-16 19:50:02 -08:00
2019-05-16 15:51:55 -07:00
2020-02-04 03:05:24 +00:00
2019-11-13 12:15:34 -08:00
2020-01-13 18:31:48 -08:00
2020-02-04 03:05:26 +00:00
2019-11-13 00:33:21 +11:00
2019-08-30 07:27:17 -07:00
2019-08-01 20:51:22 +02:00
2019-07-31 19:03:35 +02:00
2020-02-21 11:22:15 -08:00
2020-01-14 12:20:48 +01:00
2019-11-14 12:20:02 +08:00
2019-05-15 17:35:54 +01:00
2020-01-17 22:33:37 -05:00