Glauber Costa 4e717f5c10
list_lru: remove special case function list_lru_dispose_all. ...
The list_lru implementation has one function, list_lru_dispose_all, with
only one user (the dentry code). At first, such function appears to make
sense because we are really not interested in the result of isolating each
dentry separately - all of them are going away anyway. However, it's
implementation is buggy in the following way:
When we call list_lru_dispose_all in fs/dcache.c, we scan all dentries
marking them with DCACHE_SHRINK_LIST. However, this is done without the
nlru->lock taken. The imediate result of that is that someone else may
add or remove the dentry from the LRU at the same time. When list_lru_del
happens in that scenario we will see an element that is not yet marked
with DCACHE_SHRINK_LIST (even though it will be in the future) and
obviously remove it from an lru where the element no longer is. Since
list_lru_dispose_all will in effect count down nlru's nr_items and
list_lru_del will do the same, this will lead to an imbalance.
The solution for this would not be so simple: we can obviously just keep
the lru_lock taken, but then we have no guarantees that we will be able to
acquire the dentry lock (dentry->d_lock). To properly solve this, we need
a communication mechanism between the lru and dentry code, so they can
coordinate this with each other.
Such mechanism already exists in the form of the list_lru_walk_cb
callback. So it is possible to construct a dcache-side prune function
that does the right thing only by calling list_lru_walk in a loop until no
more dentries are available.
With only one user, plus the fact that a sane solution for the problem
would involve boucing between dcache and list_lru anyway, I see little
justification to keep the special case list_lru_dispose_all in tree.
Signed-off-by: Glauber Costa <glommer@openvz.org >
Cc: Michal Hocko <mhocko@suse.cz >
Acked-by: Dave Chinner <dchinner@redhat.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2013-09-10 18:56:31 -04:00
2013-07-05 11:40:47 +05:30
2013-08-26 14:09:03 -04:00
2013-08-21 09:28:29 +02:00
2013-07-09 12:18:06 -07:00
2013-07-03 11:54:50 -07:00
2013-07-09 10:33:30 -07:00
2013-08-05 08:52:45 +09:00
2013-03-01 13:39:00 -08:00
2013-09-06 13:21:16 -07:00
2013-08-17 19:34:52 +01:00
2013-07-10 11:10:27 -07:00
2013-09-09 16:35:29 -07:00
2013-02-28 18:02:55 -08:00
2013-09-07 20:14:19 -07:00
2013-09-05 14:54:29 -07:00
2013-08-15 15:42:57 -07:00
2013-07-05 12:48:35 -04:00
2013-08-30 21:37:01 +01:00
2013-08-14 10:48:05 +02:00
2013-02-13 06:16:08 -08:00
2013-08-28 13:34:41 +02:00
2013-09-09 10:33:19 -07:00
2013-06-10 10:46:18 -07:00
2013-07-08 22:09:18 +01:00
2013-09-01 13:50:20 +01:00
2013-02-22 09:20:11 -08:00
2013-09-01 13:49:06 +01:00
2013-06-17 14:38:54 -04:00
2013-09-09 09:19:15 -07:00
2013-09-05 14:54:29 -07:00
2013-08-02 12:33:54 -07:00
2013-05-14 10:23:57 +05:30
2013-04-12 00:31:18 +02:00
2013-07-31 14:20:39 +02:00
2013-07-03 16:31:35 -07:00
2013-05-07 19:46:02 -07:00
2013-05-29 12:57:34 -07:00
2013-05-29 15:50:34 -04:00
2013-07-03 16:07:42 -07:00
2013-03-12 13:59:14 -07:00
2013-08-25 09:39:12 -04:00
2013-07-29 13:04:12 -07:00
2013-07-15 11:07:56 +01:00
2013-07-09 10:33:19 -07:00
2013-04-01 19:08:06 -07:00
2013-07-03 16:07:43 -07:00
2013-04-10 23:41:16 +02:00
2013-03-01 12:47:16 +01:00
2013-04-29 15:40:23 -04:00
2013-07-08 01:23:15 -07:00
2013-05-08 10:13:35 -07:00
2013-05-08 10:13:35 -07:00
2013-04-18 09:00:26 -07:00
2013-02-15 18:52:45 -08:00
2013-07-03 16:07:39 -07:00
2013-05-15 14:42:15 -07:00
2013-02-20 09:37:28 -05:00
2013-09-04 09:23:46 -04:00
2013-02-21 17:22:16 -08:00
2013-08-30 23:44:11 -07:00
2013-07-09 16:30:35 -07:00
2013-08-26 18:40:56 -04:00
2013-04-30 17:04:01 -07:00
2013-08-19 12:27:17 -07:00
2013-08-27 17:50:38 -07:00
2013-04-10 16:33:53 -07:00
2013-05-16 11:09:18 +02:00
2013-07-05 11:09:28 +02:00
2013-03-20 13:23:21 -04:00
2013-02-13 06:00:53 -08:00
2013-07-30 11:11:44 +02:00
2013-02-23 17:50:10 -08:00
2013-09-01 14:16:33 -07:00
2013-02-21 17:22:15 -08:00
2013-04-29 18:28:13 -07:00
2013-02-21 17:22:15 -08:00
2013-04-08 17:28:34 +02:00
2013-06-19 12:58:42 +02:00
2013-05-20 12:27:59 -07:00
2013-08-14 17:14:51 +02:00
2013-08-14 17:14:54 +02:00
2013-07-08 10:13:40 -04:00
2013-08-27 01:44:40 +02:00
2013-08-10 03:24:47 +02:00
2013-07-15 02:09:47 +02:00
2013-03-12 11:30:04 -07:00
2013-05-01 17:51:54 -07:00
2013-09-07 12:56:26 +10:00
2013-04-29 18:28:19 -07:00
2013-09-10 18:56:29 -04:00
2013-05-12 14:16:21 +02:00
2013-08-27 22:09:12 -07:00
2013-08-18 17:39:55 -07:00
2013-06-03 20:20:29 +09:00
2013-07-10 23:41:18 +01:00
2013-09-09 10:26:33 -07:00
2013-08-02 12:33:54 -07:00
2013-03-01 22:45:49 +00:00
2013-05-01 16:36:22 +05:30
2013-08-27 09:18:29 +02:00
2013-08-29 21:55:23 -04:00
2013-09-09 17:02:38 -07:00
2013-04-30 17:04:02 -07:00
2013-06-28 16:04:36 +02:00
2013-06-28 16:04:36 +02:00
2013-06-28 16:04:36 +02:00
2013-07-06 14:09:38 -07:00
2013-02-28 09:53:21 +05:30
2013-03-03 23:59:59 -08:00
2013-07-23 16:01:28 -07:00
2013-07-06 14:09:38 -07:00
2013-07-03 13:25:24 +02:00
2013-02-26 02:46:08 -05:00
2013-07-15 11:25:00 +09:30
2013-05-07 18:38:27 -07:00
2013-09-03 20:57:49 -04:00
2013-09-07 19:54:57 -04:00
2013-03-27 13:48:25 +01:00
2013-03-15 15:09:43 +10:30
2013-04-29 18:28:40 -07:00
2013-08-26 20:15:23 +09:00
2013-06-27 16:53:30 +08:00
2013-05-01 17:31:42 -04:00
2013-06-19 16:49:39 -07:00
2013-07-27 20:24:36 +02:00
2013-02-23 17:50:12 -08:00
2013-06-06 12:41:57 -07:00
2013-06-17 16:38:57 -07:00
2013-06-19 20:30:32 -07:00
2013-05-12 14:16:22 +02:00
2013-04-30 17:04:00 -07:00
2013-08-22 22:13:54 -07:00
2013-03-27 07:49:29 -07:00
2013-09-10 18:56:30 -04:00
2013-09-06 09:17:30 +01:00
2013-09-06 09:17:30 +01:00
2013-04-29 18:28:41 -07:00
2013-06-29 12:57:13 +04:00
2013-09-03 07:41:11 +02:00
2013-06-19 23:32:07 -04:00
2013-04-29 18:28:13 -07:00
2013-02-26 03:10:52 +11:00
2013-07-09 10:33:21 -07:00
2013-04-11 10:00:05 +08:00
2013-04-16 18:47:14 +09:00
2013-08-14 17:14:52 +02:00
2013-03-18 10:21:23 +01:00
2013-02-27 19:10:24 -08:00
2013-08-30 08:42:01 +10:00
2013-04-30 10:09:06 +02:00
2013-08-26 13:46:11 +02:00
2013-08-26 13:46:11 +02:00
2013-09-06 11:58:37 +02:00
2013-08-26 21:40:24 +02:00
2013-02-23 17:50:16 -08:00
2013-03-22 16:19:59 -07:00
2013-07-04 10:29:23 -07:00
2013-07-03 16:07:32 -07:00
2013-08-02 11:34:30 +08:00
2013-04-02 07:07:32 +02:00
2013-08-23 10:22:29 +02:00
2013-08-26 09:30:03 -07:00
2013-04-29 13:54:36 -04:00
2013-05-08 11:51:05 -07:00
2013-08-29 14:08:24 -04:00
2013-03-26 12:32:13 -04:00
2013-06-05 12:00:27 -07:00
2013-06-13 17:51:04 -07:00
2013-06-25 16:44:56 -07:00
2013-07-23 16:52:47 -07:00
2013-07-18 13:05:23 -07:00
2013-07-23 16:52:47 -07:00
2013-03-27 13:48:25 +01:00
2013-02-11 14:16:26 -05:00
2013-08-22 20:30:15 -07:00
2013-02-19 08:06:01 +01:00
2013-06-26 12:13:18 -04:00
2013-03-27 13:48:25 +01:00
2013-05-31 13:02:52 +10:00
2013-05-02 12:10:19 +02:00
2013-04-29 15:54:37 -07:00
2013-03-15 12:23:09 -07:00
2013-05-01 08:12:58 -07:00
2013-06-17 16:38:57 -07:00
2013-02-27 19:10:21 -08:00
2013-08-29 15:32:08 -04:00
2013-03-22 16:41:19 -07:00
2013-06-25 11:48:24 +02:00
2013-06-06 10:23:58 +09:00
2013-06-24 14:02:41 +01:00
2013-07-01 08:12:41 -04:00
2013-06-12 23:02:35 -04:00
2013-08-09 10:49:00 +02:00
2013-08-20 11:46:54 -07:00
2013-05-13 09:45:01 -04:00
2013-08-09 07:53:54 -07:00
2013-08-09 07:53:54 -07:00
2013-07-26 16:19:48 -07:00
2013-04-29 15:42:02 -04:00
2013-08-02 22:38:10 -04:00
2013-04-17 12:35:33 -07:00
2013-04-30 17:04:06 -07:00
2013-08-28 21:35:14 -07:00
2013-07-25 15:39:04 -07:00
2013-04-08 17:28:34 +02:00
2013-05-16 07:55:07 -07:00
2013-02-23 17:50:19 -08:00
2013-04-30 17:04:02 -07:00
2013-07-25 12:35:39 +02:00
2013-07-29 09:03:53 +02:00
2013-04-07 13:05:35 +03:00
2013-07-03 16:07:43 -07:00
2013-04-01 11:04:50 -07:00
2013-08-25 09:39:12 -04:00
2013-05-05 10:58:06 -07:00
2013-03-12 14:07:41 -07:00
2013-09-10 18:56:31 -04:00
2013-07-16 22:00:14 -07:00
2013-07-23 16:47:08 -07:00
2013-07-12 13:51:18 +02:00
2013-09-07 15:49:18 -07:00
2013-03-22 22:17:36 -06:00
2013-07-09 10:33:30 -07:00
2013-02-20 19:36:01 +01:00
2013-05-31 00:48:22 -07:00
2013-06-12 16:29:47 -07:00
2013-08-06 14:10:45 +00:00
2013-04-08 16:57:15 -07:00
2013-03-02 09:34:39 -08:00
2013-08-08 20:11:24 -04:00
2013-06-01 22:24:07 +02:00
2013-08-21 11:52:20 -07:00
2013-08-22 23:20:54 +08:00
2013-02-23 17:50:19 -08:00
2013-08-22 10:19:35 -07:00
2013-08-12 17:54:05 +02:00
2013-07-03 16:07:32 -07:00
2013-07-09 10:33:22 -07:00
2013-09-07 09:48:41 -07:00
2013-09-03 16:35:47 +09:30
2013-08-20 15:37:42 +09:30
2013-07-24 09:14:46 -07:00
2013-08-12 15:27:01 +00:00
2013-06-26 12:10:56 +02:00
2013-07-12 12:07:46 +02:00
2013-08-02 12:33:54 -07:00
2013-09-08 20:20:23 -04:00
2013-07-03 16:08:05 -07:00
2013-06-04 15:17:38 -07:00
2013-05-27 22:50:59 -07:00
2013-09-06 14:43:49 -04:00
2013-05-23 11:58:55 +02:00
2013-08-28 00:26:48 +02:00
2013-06-27 22:44:16 -07:00
2013-05-27 23:18:50 -07:00
2013-06-08 16:20:14 -04:00
2013-09-06 14:49:16 -04:00
2013-09-03 15:26:29 -04:00
2013-02-13 06:15:29 -08:00
2013-09-05 10:40:45 -04:00
2013-06-20 15:41:18 +02:00
2013-07-25 21:54:01 +02:00
2013-04-29 15:54:36 -07:00
2013-08-27 13:52:52 -04:00
2013-05-04 14:47:26 -04:00
2013-09-03 16:40:32 -04:00
2013-05-19 20:29:55 +00:00
2013-08-21 10:29:51 +01:00
2013-06-12 07:49:19 +05:30
2013-08-27 09:18:32 +02:00
2013-02-13 10:11:53 +00:00
2013-04-02 16:43:09 -04:00
2013-08-12 15:27:01 +00:00
2013-06-12 12:37:30 +01:00
2013-08-27 10:53:44 +02:00
2013-09-03 15:59:39 -07:00
2013-08-15 17:22:27 -07:00
2013-06-11 11:41:51 -05:00
2013-03-29 17:54:33 -07:00
2013-02-23 00:30:08 +01:00
2013-09-03 22:52:48 -04:00
2013-02-23 17:50:17 -08:00
2013-02-14 15:55:23 +01:00
2013-02-23 17:50:15 -08:00
2013-07-03 16:07:32 -07:00
2013-04-29 15:54:28 -07:00
2013-07-03 16:07:31 -07:00
2013-04-19 22:25:51 +02:00
2013-03-01 23:51:07 -05:00
2013-09-05 14:54:29 -07:00
2013-09-04 11:07:04 -07:00
2013-07-23 03:58:42 +02:00
2013-04-17 10:21:17 -06:00
2013-04-17 10:21:17 -06:00
2013-09-06 13:30:06 -07:00
2013-04-17 10:21:17 -06:00
2013-08-23 16:08:27 -04:00
2013-06-16 16:12:26 -07:00
2013-09-04 11:55:10 -07:00
2013-05-31 17:19:05 -07:00
2013-05-07 20:16:25 -07:00
2013-07-03 16:08:03 -07:00
2013-04-09 14:13:02 -04:00
2013-07-04 15:51:45 -07:00
2013-03-07 12:35:51 +08:00
2013-06-03 21:49:52 +02:00
2013-07-15 01:31:37 +02:00
2013-03-19 09:47:30 +01:00
2013-07-03 16:16:20 +02:00
2013-06-28 18:20:52 -07:00
2013-08-19 21:22:34 -07:00
2013-08-14 17:14:52 +02:00
2013-06-19 12:55:10 +02:00
2013-08-06 14:21:01 -07:00
2013-05-01 17:29:47 -04:00
2013-05-01 17:29:39 -04:00
2013-04-09 14:13:35 -04:00
2013-04-03 21:50:00 -07:00
2013-08-19 10:18:11 -07:00
2013-07-09 10:33:26 -07:00
2013-06-28 23:15:06 +02:00
2013-06-21 11:32:51 +02:00
2013-08-14 19:54:30 +01:00
2013-08-20 16:53:58 -05:00
2013-08-17 09:32:32 -04:00
2013-04-29 15:54:28 -07:00
2013-05-07 18:38:27 -07:00
2013-03-12 14:07:41 -07:00
2013-06-02 20:53:59 -07:00
2013-08-18 17:40:16 -07:00
2013-08-31 14:43:50 -07:00
2013-06-10 13:45:52 -07:00
2013-06-10 13:45:52 -07:00
2013-07-09 10:33:29 -07:00
2013-09-03 10:07:40 -07:00
2013-04-30 17:04:09 -07:00
2013-04-07 14:06:17 +03:00
2013-04-29 19:14:20 -07:00
2013-07-12 12:07:46 +02:00
2013-04-12 10:26:23 +02:00
2013-04-12 10:26:23 +02:00
2013-03-15 00:34:50 -04:00
2013-05-24 16:22:50 -07:00
2013-07-03 16:08:05 -07:00
2013-07-03 16:08:05 -07:00
2013-02-23 17:50:17 -08:00
2013-04-29 18:28:22 -07:00
2013-03-07 15:29:45 -05:00
2013-03-23 15:53:52 -07:00
2013-07-09 10:33:30 -07:00
2013-06-12 14:02:13 -07:00
2013-09-04 18:15:06 -07:00
2013-04-09 13:19:39 -04:00
2013-06-17 16:38:57 -07:00
2013-07-25 19:30:03 +10:00
2013-07-09 10:33:28 -07:00
2013-07-08 13:36:41 +04:00
2013-02-19 08:43:34 +01:00
2013-05-20 11:47:21 -07:00
2013-04-11 13:14:36 -07:00
2013-06-17 18:09:53 +09:00
2013-07-05 11:40:59 +05:30
2013-08-20 17:10:41 -07:00
2013-07-22 19:40:01 -07:00
2013-09-10 18:56:30 -04:00
2013-09-01 14:16:33 -07:00
2013-09-04 00:27:25 -04:00
2013-05-06 09:24:16 +03:00
2013-07-07 19:02:59 +03:00
2013-07-07 19:02:59 +03:00
2013-07-03 16:07:22 -07:00
2013-02-26 22:25:17 +01:00
2013-08-02 12:33:54 -07:00
2013-04-29 13:21:30 -04:00
2013-08-07 16:52:33 -07:00
2013-06-19 23:34:50 +02:00
2013-06-19 12:58:42 +02:00
2013-08-13 08:19:26 -07:00
2013-06-20 19:02:45 +04:00
2013-06-10 13:45:25 -07:00
2013-03-25 10:39:40 -07:00
2013-08-30 17:26:09 -04:00
2013-03-01 12:40:36 +01:00
2013-04-30 17:04:03 -07:00
2013-04-30 15:50:12 +05:30
2013-02-13 12:15:50 -08:00
2013-06-21 00:35:12 +02:00
2013-07-03 16:07:32 -07:00
2013-08-13 17:57:47 -07:00
2013-04-17 12:35:32 -07:00
2013-08-13 17:57:48 -07:00
2013-08-28 09:51:41 -07:00
2013-06-12 16:29:44 -07:00
2013-07-31 12:16:45 -07:00
2013-08-29 13:54:34 -07:00
2013-03-29 18:10:22 -06:00
2013-05-09 09:40:49 -07:00
2013-08-14 17:58:56 +02:00
2013-06-24 17:47:21 -07:00
2013-05-14 20:54:06 +02:00
2013-04-04 13:18:31 -07:00
2013-04-25 21:01:45 +08:00
2013-04-04 13:18:14 -07:00
2013-05-21 12:25:02 -05:00
2013-03-15 00:36:09 -04:00
2013-06-20 22:24:32 -07:00
2013-07-23 16:47:10 -07:00
2013-07-23 16:42:59 -07:00
2013-07-24 15:12:53 -07:00
2013-04-19 00:40:07 +02:00
2013-04-15 21:23:03 +01:00
2013-03-20 12:10:38 -04:00
2013-05-20 10:24:22 +09:30
2013-04-13 15:31:58 +02:00
2013-08-12 11:56:16 -07:00
2013-09-07 14:35:32 -07:00
2013-07-09 10:33:29 -07:00
2013-08-05 10:52:36 -06:00
2013-08-29 13:30:21 +10:00
2013-03-20 14:06:06 +10:30
2013-07-09 10:47:53 +09:30
2013-07-09 18:24:39 -07:00
2013-02-23 17:50:15 -08:00
2013-03-08 12:24:48 -05:00
2013-07-09 10:33:21 -07:00
2013-09-03 18:25:03 -07:00
2013-04-29 15:54:37 -07:00
2013-03-20 14:06:05 +10:30
2013-05-27 10:57:53 +09:00
2013-08-14 17:14:54 +02:00
2013-08-22 08:53:30 -07:00
2013-03-01 12:48:36 +01:00
2013-02-08 10:05:02 +02:00
2013-07-30 08:30:16 -04:00
2013-07-09 10:33:22 -07:00
2013-07-12 12:07:46 +02:00
2013-07-25 19:30:03 +10:00
2013-07-10 18:11:34 -07:00
Glauber Costa
4e717f5c10