Files
odroid-linux/include/linux
Boqun Feng 52fa5bc5cb locking/lockdep: Explicitly initialize wq_barrier::done::map
With the new lockdep crossrelease feature, which checks completions usage,
a false positive is reported in the workqueue code:

> Worker A : acquired of wfc.work -> wait for cpu_hotplug_lock to be released
> Task   B : acquired of cpu_hotplug_lock -> wait for lock#3 to be released
> Task   C : acquired of lock#3 -> wait for completion of barr->done
> (Task C is in lru_add_drain_all_cpuslocked())
> Worker D : wait for wfc.work to be released -> will complete barr->done

Such a dead lock can not happen because Task C's barr->done and Worker D's
barr->done can not be the same instance.

The reason of this false positive is we initialize all wq_barrier::done
at insert_wq_barrier() via init_completion(), which makes them belong to
the same lock class, therefore, impossible circles are reported.

To fix this, explicitly initialize the lockdep map for wq_barrier::done
in insert_wq_barrier(), so that the lock class key of wq_barrier::done
is a subkey of the corresponding work_struct, as a result we won't build
a dependency between a wq_barrier with a unrelated work, and we can
differ wq barriers based on the related works, so the false positive
above is avoided.

Also define the empty lockdep_init_map_crosslock() for !CROSSRELEASE
to make the code simple and away from unnecessary #ifdefs.

Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Cc: Byungchul Park <byungchul.park@lge.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170817094622.12915-1-boqun.feng@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-08-17 12:12:33 +02:00
..
2017-06-03 19:29:26 +09:00
2017-07-03 01:43:45 -07:00
2016-07-08 16:23:11 +02:00
2016-12-22 22:58:37 -05:00
2017-06-08 18:52:36 -07:00
2017-07-03 17:00:59 -06:00
2017-02-10 15:52:24 -05:00
2017-07-06 16:24:33 -07:00
2017-01-25 13:17:47 -05:00
2017-07-01 16:15:13 -07:00
2017-07-03 02:22:52 -07:00
2017-07-03 16:56:28 -06:00
2017-05-24 12:43:30 -04:00
2017-06-05 16:59:12 +02:00
2017-04-18 20:41:12 +02:00
2017-06-22 15:43:47 +01:00
2017-08-10 12:28:57 +02:00
2017-06-09 11:52:07 +02:00
2016-12-05 19:01:16 -05:00
2016-10-28 08:48:16 -06:00
2017-04-10 17:15:02 +02:00
2016-05-17 15:48:12 -04:00
2017-04-27 05:13:04 -04:00
2016-12-05 19:01:16 -05:00
2017-07-07 20:09:10 -04:00
2017-06-05 16:59:10 +02:00
2017-03-21 10:15:47 +02:00
2017-05-18 10:07:41 -04:00
2017-05-18 10:07:40 -04:00
2017-06-21 14:37:12 -04:00
2017-07-10 16:32:34 -07:00
2016-09-14 09:18:09 -06:00
2017-01-05 15:01:55 -06:00
2017-07-31 22:01:21 -07:00
2016-05-11 22:37:54 +02:00
2017-05-03 15:52:10 -07:00
2017-07-10 13:41:04 -04:00
2017-02-24 17:46:57 -08:00
2016-09-27 12:33:47 +02:00
2016-12-06 11:05:46 +01:00
2017-04-24 14:30:46 -04:00
2017-01-12 16:48:26 -05:00
2017-07-13 16:00:15 -04:00
2016-04-25 15:09:11 -04:00
2017-07-12 16:26:02 -07:00
2017-07-06 11:30:07 -04:00
2017-07-25 18:05:25 +02:00
2017-05-26 10:10:37 +02:00
2016-12-06 10:17:03 +02:00
2017-08-01 20:11:02 -05:00
2016-10-31 16:18:30 -04:00
2016-10-14 11:36:59 -07:00
2016-09-27 21:52:00 -04:00
2017-05-18 10:07:40 -04:00
2017-02-13 21:44:09 -05:00
2017-06-29 10:48:57 +01:00
2016-07-06 10:51:14 +01:00
2017-05-03 15:52:10 -07:00
2017-07-12 23:11:23 +02:00
2017-06-08 10:35:49 +02:00
2016-06-14 10:54:40 -07:00
2017-07-06 16:24:30 -07:00
2017-03-26 15:09:45 +02:00
2017-06-15 12:12:40 -04:00
2016-12-26 23:53:46 -05:00
2017-06-08 18:52:42 -07:00
2017-06-01 14:53:04 -04:00
2017-03-09 15:42:33 +01:00
2017-01-10 18:31:55 -08:00
2017-07-24 17:50:37 +02:00
2017-05-09 16:43:22 +03:00
2017-06-09 11:54:54 +02:00