Files
odroid-linux/include/linux
Yonghong Song b910eaaaa4 bpf: Fix NULL pointer dereference in bpf_get_local_storage() helper
Jiri Olsa reported a bug ([1]) in kernel where cgroup local
storage pointer may be NULL in bpf_get_local_storage() helper.
There are two issues uncovered by this bug:
  (1). kprobe or tracepoint prog incorrectly sets cgroup local storage
       before prog run,
  (2). due to change from preempt_disable to migrate_disable,
       preemption is possible and percpu storage might be overwritten
       by other tasks.

This issue (1) is fixed in [2]. This patch tried to address issue (2).
The following shows how things can go wrong:
  task 1:   bpf_cgroup_storage_set() for percpu local storage
         preemption happens
  task 2:   bpf_cgroup_storage_set() for percpu local storage
         preemption happens
  task 1:   run bpf program

task 1 will effectively use the percpu local storage setting by task 2
which will be either NULL or incorrect ones.

Instead of just one common local storage per cpu, this patch fixed
the issue by permitting 8 local storages per cpu and each local
storage is identified by a task_struct pointer. This way, we
allow at most 8 nested preemption between bpf_cgroup_storage_set()
and bpf_cgroup_storage_unset(). The percpu local storage slot
is released (calling bpf_cgroup_storage_unset()) by the same task
after bpf program finished running.
bpf_test_run() is also fixed to use the new bpf_cgroup_storage_set()
interface.

The patch is tested on top of [2] with reproducer in [1].
Without this patch, kernel will emit error in 2-3 minutes.
With this patch, after one hour, still no error.

 [1] https://lore.kernel.org/bpf/CAKH8qBuXCfUz=w8L+Fj74OaUpbosO29niYwTki7e3Ag044_aww@mail.gmail.com/T
 [2] https://lore.kernel.org/bpf/20210309185028.3763817-1-yhs@fb.com

Signed-off-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Roman Gushchin <guro@fb.com>
Link: https://lore.kernel.org/bpf/20210323055146.3334476-1-yhs@fb.com
2021-03-25 18:31:36 -07:00
..
2021-03-22 11:32:12 -07:00
2021-02-02 00:16:57 +01:00
2020-12-09 19:26:02 -06:00
2020-06-25 22:25:13 -07:00
2020-06-16 14:19:57 +02:00
2021-01-23 14:57:21 +01:00
2020-05-24 20:48:11 +02:00
2020-07-08 10:48:35 -07:00
2020-09-21 15:00:40 -07:00
2020-12-02 09:46:55 -07:00
2021-01-24 14:27:17 +01:00
2021-02-26 09:41:03 -08:00
2021-02-17 14:07:48 +01:00
2020-12-19 11:18:38 -08:00
2021-01-21 14:06:00 -07:00
2020-10-16 17:21:51 +02:00
2021-01-16 15:12:06 -05:00
2021-01-18 14:26:51 +01:00
2021-02-08 12:28:07 +01:00
2020-08-12 20:42:08 +02:00
2020-12-10 12:42:59 -06:00
2020-11-16 16:31:41 +01:00
2020-11-16 15:20:01 +01:00
2020-07-24 17:12:41 -07:00
2020-11-16 08:14:30 -07:00
2021-02-11 13:24:44 -08:00
2020-08-04 21:02:38 -04:00
2020-12-02 22:10:35 -08:00
2020-11-23 14:16:55 +00:00
2021-01-27 12:27:36 +01:00
2020-09-16 08:54:53 -05:00
2020-05-18 10:30:21 +01:00
2020-11-24 16:47:48 +01:00
2020-12-15 16:19:31 +01:00
2021-02-26 09:41:03 -08:00
2020-06-02 15:15:46 +01:00
2020-12-15 16:19:31 +01:00
2021-02-17 14:12:42 +01:00
2021-01-21 16:16:10 +00:00
2021-02-26 09:41:02 -08:00
2021-02-26 09:41:03 -08:00
2020-09-04 09:25:20 -07:00
2021-01-22 15:09:42 +01:00
2020-05-08 18:18:11 +01:00
2020-05-08 00:12:42 +02:00
2020-05-28 10:31:09 +02:00
2021-01-14 11:20:17 +01:00
2021-02-26 09:41:03 -08:00
2021-03-13 11:27:30 -08:00
2020-09-04 12:46:07 +01:00
2021-01-04 11:42:21 -05:00
2021-02-16 16:11:14 -05:00
2020-05-09 13:57:12 +02:00
2021-02-02 10:26:12 +01:00
2020-07-01 10:49:02 +02:00
2021-02-17 13:17:49 -08:00
2020-07-23 17:34:18 +10:00
2021-02-26 09:40:59 -08:00
2021-01-21 14:06:00 -07:00
2021-02-03 19:05:50 +01:00
2020-08-31 12:52:33 -07:00
2021-03-24 15:20:07 -07:00
2020-10-18 09:27:10 -07:00
2021-01-24 14:27:17 +01:00
2021-01-24 14:27:20 +01:00
2020-05-09 13:57:12 +02:00
2021-02-26 09:41:03 -08:00
2020-12-03 11:20:52 +01:00
2020-08-18 17:06:15 +02:00
2021-01-16 23:19:26 +01:00
2020-12-07 17:12:49 -07:00
2020-11-06 10:05:18 -08:00
2020-12-10 16:17:15 +01:00
2020-11-24 16:47:49 +01:00
2020-12-10 10:45:36 +01:00
2020-09-26 22:55:05 -04:00
2021-03-02 17:25:46 -07:00
2021-02-20 10:13:32 -05:00
2020-10-30 21:57:04 +01:00
2021-01-06 16:24:59 -08:00
2021-02-09 12:27:29 -05:00
2020-12-04 16:54:35 +01:00
2021-02-13 17:17:53 +01:00
2020-11-09 18:39:36 +01:00
2020-07-04 09:35:36 -05:00
2020-09-10 14:03:31 -07:00
2020-08-19 14:13:20 +02:00
2021-01-21 16:16:10 +00:00
2021-02-01 13:20:07 -07:00
2021-01-18 10:52:41 +01:00
2020-04-01 12:06:26 -04:00
2021-02-09 12:15:07 +01:00
2021-01-21 14:06:00 -07:00
2021-01-24 14:27:17 +01:00
2021-02-08 22:58:55 +01:00