Files
odroid-linux/include/linux
Josh Poimboeuf f80ac98a64 bitops: always inline sign extension helpers
With CONFIG_CC_OPTIMIZE_FOR_SIZE, objtool reports:

  drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: i915_gem_execbuffer2_ioctl()+0x5b7: call to gen8_canonical_addr() with UACCESS enabled

This means i915_gem_execbuffer2_ioctl() is calling gen8_canonical_addr()
from the user_access_begin/end critical region (i.e, with SMAP disabled).

While it's probably harmless in this case, in general we like to avoid
extra function calls in SMAP-disabled regions because it can open up
inadvertent security holes.

Fix the warning by changing the sign extension helpers to __always_inline.
This convinces GCC to inline gen8_canonical_addr().

The sign extension functions are trivial anyway, so it makes sense to
always inline them.  With my test optimize-for-size-based config, this
actually shrinks the text size of i915_gem_execbuffer.o by 45 bytes -- and
no change for vmlinux.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://lkml.kernel.org/r/740179324b2b18b750b16295c48357f00b5fa9ed.1582982020.git.jpoimboe@redhat.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2020-04-07 10:43:42 -07:00
..
2020-03-31 21:29:04 +02:00
2019-09-16 09:56:27 -07:00
2019-12-11 09:12:38 +01:00
2019-11-12 11:43:29 -05:00
2020-03-17 20:48:41 +01:00
2020-03-27 12:04:34 -06:00
2020-03-30 01:34:00 +02:00
2020-01-23 00:35:50 +01:00
2019-10-09 19:33:43 -07:00
2020-03-09 11:12:19 +01:00
2020-02-27 14:58:01 +01:00
2019-12-03 11:20:37 +01:00
2020-02-17 13:37:00 +01:00
2019-09-05 19:52:33 -06:00
2020-01-27 11:09:31 +01:00
2020-01-17 16:48:07 -08:00
2020-01-18 09:19:18 -05:00
2020-03-13 12:49:51 -07:00
2020-03-06 11:06:15 +01:00
2020-03-27 20:19:24 -03:00
2019-10-04 12:31:46 -07:00
2019-10-15 13:34:25 +02:00
2020-03-21 16:00:24 +01:00
2019-12-04 19:44:14 -08:00
2020-01-31 17:33:54 +00:00
2020-02-20 21:17:24 +01:00
2019-12-11 09:12:38 +01:00
2020-03-06 11:56:59 +01:00
2020-04-07 10:43:38 -07:00
2020-04-07 10:43:39 -07:00
2019-12-09 10:55:03 +01:00
2020-03-21 16:00:24 +01:00
2019-11-14 19:06:47 -08:00
2020-01-15 10:54:33 -05:00
2020-01-14 12:20:48 +01:00
2019-12-11 16:37:02 +08:00
2020-04-02 09:35:27 -07:00
2020-04-07 10:43:38 -07:00
2019-11-13 19:09:47 +08:00
2020-01-15 16:30:28 +00:00
2020-03-17 18:31:05 +01:00
2019-12-06 10:47:28 +01:00
2020-01-13 18:16:43 -08:00
2019-11-14 13:07:48 +08:00
2020-03-21 16:00:24 +01:00
2020-02-21 10:31:18 +01:00
2020-04-07 10:43:42 -07:00
2020-03-29 21:53:18 -07:00
2020-02-04 03:05:24 +00:00
2020-03-21 16:00:24 +01:00
2020-03-02 14:04:31 -07:00
2019-11-13 12:15:34 -08:00
2020-02-04 03:05:26 +00:00
2020-03-23 13:41:55 +01:00
2020-04-02 09:35:27 -07:00
2020-02-21 11:22:15 -08:00
2020-01-14 12:20:48 +01:00
2020-03-23 17:01:47 +01:00
2020-03-21 18:56:06 -07:00
2019-11-14 12:20:02 +08:00