shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-04 12:20:42 +09:00
Code Issues Packages Projects Releases Wiki Activity

kex: Avoid always-false comparisons as reported by csbuild

Browse Source 
/builds/jjelen/libssh-mirror/src/kex.c:360:17: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] <--[cc]
  360 |         if (len < 0) {
      |                 ^
/builds/jjelen/libssh-mirror/src/kex.c:372:17: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] <--[cc]
  372 |         if (len < 0) {
      |                 ^

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
(cherry picked from commit e2841908fb)
This commit is contained in:
Jakub Jelen
2019-12-11 11:28:33 +01:00
committed by Andreas Schneider
parent 93bf0ab6a3
commit 393cd36c01
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/kex.c
View File

@@ -356,8 +356,8 @@ SSH_PACKET_CALLBACK(ssh_packet_kexinit)
goto error;
}
len = ssh_hashbufin_add_cookie(session, session->next_crypto->client_kex.cookie);
if (len < 0) {
ok = ssh_hashbufin_add_cookie(session, session->next_crypto->client_kex.cookie);
if (ok < 0) {
ssh_set_error(session, SSH_FATAL, "ssh_packet_kexinit: adding cookie failed");
goto error;
}
@@ -368,8 +368,8 @@ SSH_PACKET_CALLBACK(ssh_packet_kexinit)
goto error;
}
len = ssh_hashbufin_add_cookie(session, session->next_crypto->server_kex.cookie);
if (len < 0) {
ok = ssh_hashbufin_add_cookie(session, session->next_crypto->server_kex.cookie);
if (ok < 0) {
ssh_set_error(session, SSH_FATAL, "ssh_packet_kexinit: adding cookie failed");
goto error;
}