shinys000114/libssh
1
0
Fork 0
mirror of https://git.libssh.org/projects/libssh.git synced 2026-02-04 20:30:38 +09:00
Code Issues Packages Projects Releases Wiki Activity

tests: Add frees to avoid memory leak errors

Browse Source 
The added frees are unnecessary, but the static analyser does not know.

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Anderson Toshiyuki Sasaki
2018-09-25 13:24:27 +02:00
committed by Andreas Schneider
parent 79e907402e
commit 6eef4b4a3c
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unittests/torture_keyfiles.c
View File

@@ -119,11 +119,17 @@ static void torture_pubkey_from_file(void **state) {
rc = ssh_try_publickey_from_file(session, LIBSSH_RSA_TESTKEY, &pubkey, &type);
assert_true(rc == 1);
/* This free is unnecessary, but the static analyser does not know */
SSH_STRING_FREE(pubkey);
/* test if it returns -1 if privkey doesn't exist */
unlink(LIBSSH_RSA_TESTKEY);
rc = ssh_try_publickey_from_file(session, LIBSSH_RSA_TESTKEY, &pubkey, &type);
assert_true(rc == -1);
/* This free is unnecessary, but the static analyser does not know */
SSH_STRING_FREE(pubkey);
}
static int torture_read_one_line(const char *filename, char *buffer, size_t len) {

6
tests/unittests/torture_pki_dsa.c
View File

@@ -335,6 +335,9 @@ torture_pki_dsa_import_openssh_privkey_base64_passphrase(void **state)
&key);
assert_true(rc == -1);
/* This free is unnecessary, but the static analyser does not know */
SSH_KEY_FREE(key);
/* test if it returns -1 if passphrase is NULL */
rc = ssh_pki_import_privkey_base64(keystring,
NULL,
@@ -342,6 +345,9 @@ torture_pki_dsa_import_openssh_privkey_base64_passphrase(void **state)
NULL,
&key);
assert_true(rc == -1);
/* This free is unnecessary, but the static analyser does not know */
SSH_KEY_FREE(key);
}