Andreas Schneider
123e8448e6
pki_mbedcrypto: Use SSH_STRING_FREE()
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 42547772df )
2019-12-09 16:38:36 +01:00
Andreas Schneider
ba563611ee
ecdh_crypto: Use SSH_STRING_FREE()
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 288bbd5bd0 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
69b4860404
pki_crypto: Use SSH_BUFFER_FREE()
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 8525b4bb01 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
564e298989
pki_crypto: Use SSH_STRING_FREE()
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit d97770b025 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
5a41514d8d
pki: Use SSH_BUFFER_FREE()
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit f89cf79c49 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
8f0ab53b7b
pki: Use SSH_STRING_FREE()
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 189fd76589 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
0016888942
ecdh_gcrypt: Use SSH_STRING_FREE()
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 2786a3e96a )
2019-12-09 16:38:36 +01:00
Andreas Schneider
ce045cf5ed
libcrypto: Use SSH_STRING_FREE()
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 09dfda8489 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
5ae2a05ca1
pki_gcrypt: Use SSH_BUFFER_FREE()
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 9a112f1548 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
8dcaf4bfa3
pki_gcrypt: Use SSS_STRING_FREE()
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 4e2d85745f )
2019-12-09 16:38:36 +01:00
Andreas Schneider
6c392befcc
SSH-01-007: Fix possible double free of ssh strings
...
Fixes T183
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 032f25aab3 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
5b55eefb96
gssapi: Make sure buffer is initialized
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit da81b99df1 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
9fc8e095ce
SSH-01-006: Add missing NULL check in sftp_open()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit af2aeba838 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
65918ec38a
SSH-01-006: Add missing NULL check in server_set_kex()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 9ae81c5ceb )
2019-12-09 16:38:36 +01:00
Andreas Schneider
2caedc0d0d
SSH-01-006: Add missing NULL check in ssh_scp_push_directory()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 8aa2bbd0dc )
2019-12-09 16:38:36 +01:00
Andreas Schneider
0187b71912
SSH-01-006: Add missing NULL checks in ssh_scp_push_file64()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit fff4120cbf )
2019-12-09 16:38:36 +01:00
Andreas Schneider
053a23b50d
SSH-01-006: Add missing NULL checks in pki_signature_from_rsa_blob()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 7b9cbcebe5 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
2b52a8df4d
SSH-01-006: Add missing NULL check in ssh_pki_do_sign_agent()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 56d571ab81 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
fa33b61102
SSH-01-006: Add missing NULL check in ssh_packet_hmac_verify()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 69daa602b8 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
563e1fc821
SSH-01-006: Add missing NULL check in gzip_decompress()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 924dc5aed8 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
f6c8e87c3e
SSH-01-006: Add missing NULL check in ssh_gssapi_handle_userauth()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 6b8ab4bcd2 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
0ff2cfe0e6
SSH-01-006: Add missing NULL check in ssh_gssapi_handle_userauth()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit af2ea417da )
2019-12-09 16:38:36 +01:00
Andreas Schneider
828f8dd106
SSH-01-006: Add missing NULL check in ssh_gssapi_build_mic()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit c7172c183f )
2019-12-09 16:38:36 +01:00
Andreas Schneider
5f5a6e15b3
SSH-01-006: Add missing NULL check in ssh_gssapi_oid_from_string()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 33cca875c2 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
e5b403f83a
SSH-01-006: Add missing NULL check for ssh_packet_get_current_crypto()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit b55d7f3b73 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
11cb618c75
SSH-01-006: Add missing ENOMEM check in ssh_gssapi_auth_mic()
...
Fixes T193
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 7588979977 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
338e6cece5
cmake: Add -Wsign-compare to CFLAGS
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit ab26db203e )
2019-12-09 16:38:36 +01:00
Andreas Schneider
4603105e0b
socket: Pass port as uint16_t to ssh_socket_connect()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit d60640cd0e )
2019-12-09 16:38:36 +01:00
Andreas Schneider
ee1f8512a4
bignum: Print ssh_make_string_bn() using SSH_LOG()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 64155b4f97 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
278ed59501
bignum: Fix integer types for ssh_make_bignum_string()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 64cd7e7ce2 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
9e9d35164b
base64: Fix size types of bin_to_base64()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit f5bc5147b9 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
a011f853ed
base64: Reformat bin_to_base64()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit b5160ce9e0 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
c98d024b9a
base64: Make alphabet and const uint8_t
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit fdb7cb8f17 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
d5b10f569d
base64: Reformat _bin_to_base64()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit fe9991b3c6 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
31f65d1ffb
auth: Cast echo to char in ssh_userauth_kbdint_getprompt()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 159d95c26c )
2019-12-09 16:38:36 +01:00
Andreas Schneider
44e37c2546
include: Mark SSH_AUTH flags as unsigned
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 5ef416fd35 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
35188b3843
agent: Return uint32_t for ssh_agent_get_ident_count()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 1be68139bb )
2019-12-09 16:38:36 +01:00
Andreas Schneider
76aeedad1b
agent: Reformat ssh_agent_get_ident_count()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit c820d2a2dc )
2019-12-09 16:38:36 +01:00
Andreas Schneider
66419896f7
sftpserver: Fix integer type in sftp_reply_data()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit b18acbdc7e )
2019-12-09 16:38:36 +01:00
Andreas Schneider
0cb50ef31a
sftp: Avoid comparison of integers of different sizes
...
This casts ssize_t len to size_t.
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit d672b1d7c4 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
88e40516c9
sftp: Cast sftp version to int
...
This is a public struct and the version should be unsigned there.
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit d40f33c400 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
f45aa46322
sftp: Use uint32_t for sftp extension count
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit c29840060b )
2019-12-09 16:38:36 +01:00
Andreas Schneider
dbf757e3e8
sftp: Fix integer types in sftp_extension_supported()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 98824d6e11 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
0a404349bc
sftp: Fix integer types in sftp_read()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 839fab6df4 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
e9b74b5cb7
sftp: Fix integer types in sftp_write() and sftp_packet_write()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 6b105624bf )
2019-12-09 16:38:36 +01:00
Andreas Schneider
6a0cbc73bd
sftp: Remove internal function from sftp.h
...
Those are not marked as LIBSSH_API so not part of the public API and the
symbols aren't exported!
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit db4345fb36 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
40ee7d2b38
server: Cast auth_methods to uint32_t
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 6cef3e10bf )
2019-12-09 16:38:36 +01:00
Andreas Schneider
7db565601d
server: Make sure methods is a valid value before casting
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 442d22da60 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
95faeb498f
pki_crypto: Cast return value of EVP_PKEY_size() to size_t
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 3cca9994d4 )
2019-12-09 16:38:36 +01:00
Andreas Schneider
db97435a41
packet: Fix size types in ssh_packet_need_rekey()
...
Fixes T188
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
Reviewed-by: Jakub Jelen <jjelen@redhat.com >
(cherry picked from commit 53635dff7e )
2019-12-09 16:38:36 +01:00