mirror of
https://github.com/hardkernel/linux.git
synced 2026-04-19 12:00:46 +09:00
drm/i915: Call uncore_suspend before platform suspend handlers
Quoting Ville: "the forcewake timer might still be active until the uncore suspend, and having active forcewakes while we've already told the GT wake stuff to stop acting normally doesn't seem quite right to me." Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Suggested-by: Imre Deak <imre.deak@intel.com> Reviewed-by: Imre Deak <imre.deak@intel.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171114135518.15981-3-hdegoede@redhat.com
This commit is contained in:
committed by
Hans de Goede
parent
bedf4d79c3
commit
01c799c995
@@ -2526,6 +2526,8 @@ static int intel_runtime_suspend(struct device *kdev)
|
||||
|
||||
intel_runtime_pm_disable_interrupts(dev_priv);
|
||||
|
||||
intel_uncore_suspend(dev_priv);
|
||||
|
||||
ret = 0;
|
||||
if (IS_GEN9_LP(dev_priv)) {
|
||||
bxt_display_core_uninit(dev_priv);
|
||||
@@ -2538,6 +2540,8 @@ static int intel_runtime_suspend(struct device *kdev)
|
||||
|
||||
if (ret) {
|
||||
DRM_ERROR("Runtime suspend failed, disabling it (%d)\n", ret);
|
||||
intel_uncore_runtime_resume(dev_priv);
|
||||
|
||||
intel_runtime_pm_enable_interrupts(dev_priv);
|
||||
|
||||
enable_rpm_wakeref_asserts(dev_priv);
|
||||
@@ -2545,8 +2549,6 @@ static int intel_runtime_suspend(struct device *kdev)
|
||||
return ret;
|
||||
}
|
||||
|
||||
intel_uncore_suspend(dev_priv);
|
||||
|
||||
enable_rpm_wakeref_asserts(dev_priv);
|
||||
WARN_ON_ONCE(atomic_read(&dev_priv->runtime_pm.wakeref_count));
|
||||
|
||||
|
||||
Reference in New Issue
Block a user