mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-09 04:10:18 +09:00
ASoC: fix a memory-leak in wm8903
commit 40aa7030e5 upstream.
Remember to free the temporary register-cache.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
2cdc2dc3bd
commit
09e4d0f1f6
@@ -1506,7 +1506,7 @@ static int wm8903_resume(struct platform_device *pdev)
|
||||
struct i2c_client *i2c = codec->control_data;
|
||||
int i;
|
||||
u16 *reg_cache = codec->reg_cache;
|
||||
u16 *tmp_cache = kmemdup(codec->reg_cache, sizeof(wm8903_reg_defaults),
|
||||
u16 *tmp_cache = kmemdup(reg_cache, sizeof(wm8903_reg_defaults),
|
||||
GFP_KERNEL);
|
||||
|
||||
/* Bring the codec back up to standby first to minimise pop/clicks */
|
||||
@@ -1518,6 +1518,7 @@ static int wm8903_resume(struct platform_device *pdev)
|
||||
for (i = 2; i < ARRAY_SIZE(wm8903_reg_defaults); i++)
|
||||
if (tmp_cache[i] != reg_cache[i])
|
||||
snd_soc_write(codec, i, tmp_cache[i]);
|
||||
kfree(tmp_cache);
|
||||
} else {
|
||||
dev_err(&i2c->dev, "Failed to allocate temporary cache\n");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user