shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 18:41:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

MALI: bifrost: Fix a null pointer exception when event tracing is enabled

Browse Source 
The issue was reported in https://redmine.rock-chips.com/issues/442097.
The kernel crash log:
[   10.737137][ T1028] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010
...
[   10.747955][ T1028] pc : __pi_strlen+0x60/0x84
[   10.748673][ T1028] lr : trace_event_raw_event_dma_fence+0xe0/0x1e8
...
[   10.761907][ T1028] Call trace:
[   10.762198][ T1028]  __pi_strlen+0x60/0x84
[   10.762561][ T1028]  dma_fence_init+0xd4/0xfc
[   10.762951][ T1028]  kbasep_kcpu_fence_signal_init+0x6c/0x1b0
[   10.763454][ T1028]  kbase_kcpu_fence_signal_prepare+0x6c/0x134
[   10.763980][ T1028]  kbase_csf_kcpu_queue_enqueue+0x1d0/0x10ec
[   10.764499][ T1028]  kbase_ioctl+0xa80/0xf78
[   10.764890][ T1028]  __arm64_sys_ioctl+0x90/0xc8
[   10.765296][ T1028]  el0_svc_common+0xac/0x1ac
[   10.765691][ T1028]  do_el0_svc+0x1c/0x28
[   10.766058][ T1028]  el0_svc+0x10/0x1c
[   10.766389][ T1028]  el0_sync_handler+0x68/0xac
[   10.766796][ T1028]  el0_sync+0x160/0x180

Change-Id: I68739107dd9486b3a964746583c526a51f68e1ae
Signed-off-by: Zhen Chen <chenzhen@rock-chips.com>
This commit is contained in:
Zhen Chen
2023-10-13 15:37:30 +08:00
committed by Tao Huang
parent 7c27dbc54d
commit 194a7d5a75
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/arm/bifrost/csf/mali_kbase_csf_kcpu.c
View File

@@ -1604,6 +1604,10 @@ static int kbasep_kcpu_fence_signal_init(struct kbase_kcpu_command_queue *kcpu_q
if (!kcpu_fence)
return -ENOMEM;
/* Set reference to KCPU metadata and increment refcount */
kcpu_fence->metadata = kcpu_queue->metadata;
WARN_ON(!kbase_refcount_inc_not_zero(&kcpu_fence->metadata->refcount));
#if (KERNEL_VERSION(4, 10, 0) > LINUX_VERSION_CODE)
fence_out = (struct fence *)kcpu_fence;
#else
@@ -1625,10 +1629,6 @@ static int kbasep_kcpu_fence_signal_init(struct kbase_kcpu_command_queue *kcpu_q
dma_fence_get(fence_out);
#endif
/* Set reference to KCPU metadata and increment refcount */
kcpu_fence->metadata = kcpu_queue->metadata;
WARN_ON(!kbase_refcount_inc_not_zero(&kcpu_fence->metadata->refcount));
/* create a sync_file fd representing the fence */
*sync_file = sync_file_create(fence_out);
if (!(*sync_file)) {