mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-04 18:19:28 +09:00
ACPI, APEI: Fixup common access width firmware bug
commit f712c71f7b upstream.
Many firmwares have a common register definition bug where 8-bit
access width is specified for a 32-bit register. Ideally this should
be fixed in the BIOS, but earlier versions of the kernel did not
complain, so fix that up silently.
This closes kernel bug #43282:
https://bugzilla.kernel.org/show_bug.cgi?id=43282
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Acked-by: Huang Ying <ying.huang@intel.com>
Acked-by: Gary Hade <garyhade@us.ibm.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
20e2d5cef0
commit
1cd9be20fd
@@ -586,6 +586,11 @@ static int apei_check_gar(struct acpi_generic_address *reg, u64 *paddr,
|
||||
}
|
||||
*access_bit_width = 1UL << (access_size_code + 2);
|
||||
|
||||
/* Fixup common BIOS bug */
|
||||
if (bit_width == 32 && bit_offset == 0 && (*paddr & 0x03) == 0 &&
|
||||
*access_bit_width < 32)
|
||||
*access_bit_width = 32;
|
||||
|
||||
if ((bit_width + bit_offset) > *access_bit_width) {
|
||||
pr_warning(FW_BUG APEI_PFX
|
||||
"Invalid bit width + offset in GAR [0x%llx/%u/%u/%u/%u]\n",
|
||||
|
||||
Reference in New Issue
Block a user