shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-08 20:07:46 +09:00
Code Issues Packages Projects Releases Wiki Activity

touchscreen: goodix_gt1x: fix coverity warning

Browse Source 
PD#172714: touchscreen: goodix_gt1x: fix coverity warning

There is no judgment about whether it is null before
using the pointer.
This causes "Untrusted value as argument".

Change-Id: I147b89e9a96cddf4bdc3c42753bd165b6b802065
Signed-off-by: Yingyuan Zhu <yingyuan.zhu@amlogic.com>
This commit is contained in:
Yingyuan Zhu
2018-08-29 18:51:32 +08:00
committed by Jianxin Pan
parent 35a6b7fa1d
commit 2bc5fc8909
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/amlogic/input/touchscreen/goodix_gt1x/gt1x_extents.c
View File

@@ -665,7 +665,7 @@ static long gt1x_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
u32 value = 0;
s32 ret = 0; //the initial value must be 0
u8 *data = NULL;
int cnt = 30;
int cnt = 30;
/* Blocking when firmwaer updating */
while (cnt-- && update_info.status) {
@@ -696,6 +696,8 @@ static long gt1x_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
} else {
value = (u32) arg;
}
if (!data)
return -1;
switch (cmd & NEGLECT_SIZE_MASK) {
case IO_GET_VERISON: