shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-07 03:15:31 +09:00
Code Issues Packages Projects Releases Wiki Activity

ANDROID: dm-bow: Synchronize destruction

Browse Source 
Stop the workqueue and bufio client before cleaning range data
that is used by the workq. The workq is running bow_write and
can still be active when the dtr is called. Compare to dm-snap that
also doing synchronize within the destruction.

Bug: 181138982
Signed-off-by: Peter Enderborg <peter.enderborg@sony.com>
Signed-off-by: Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>
Signed-off-by: Paul Lawrence <paullawrence@google.com>
Change-Id: I413fdcb316ab1e6de6ecabad26022bd76e435d88
This commit is contained in:
Peter Enderborg
2021-02-23 16:20:26 +01:00
committed by Paul Lawrence
parent 4e77c99cd7
commit 2eeb8df83d
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/md/dm-bow.c
View File

@@ -599,13 +599,6 @@ static void dm_bow_dtr(struct dm_target *ti)
struct bow_context *bc = (struct bow_context *) ti->private;
struct kobject *kobj;
while (rb_first(&bc->ranges)) {
struct bow_range *br = container_of(rb_first(&bc->ranges),
struct bow_range, node);
rb_erase(&br->node, &bc->ranges);
kfree(br);
}
if (bc->workqueue)
destroy_workqueue(bc->workqueue);
if (bc->bufio)
@@ -617,6 +610,15 @@ static void dm_bow_dtr(struct dm_target *ti)
wait_for_completion(dm_get_completion_from_kobject(kobj));
}
while (rb_first(&bc->ranges)) {
struct bow_range *br = container_of(rb_first(&bc->ranges),
struct bow_range, node);
rb_erase(&br->node, &bc->ranges);
kfree(br);
}
mutex_destroy(&bc->ranges_lock);
kfree(bc->log_sector);
kfree(bc);
}