shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-05 18:41:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

drm/rockchip: vop: move devm_request_irq to the end of vop_bind

Browse Source 
At MOS environment, the irq handle may be triggered immediately
after request irq, the irq handle maybe access vop memory, e.g.,
vop_isr() -> vop_wb_handler() access vop->wb->regs, so move
devm_request_irq() to the end of this function to make sure vop is
initialized.

Change-Id: Ie124576bf2333f63ec3985c321a3c368e28b34be
Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
This commit is contained in:
Chaoyi Chen
2025-02-11 01:37:32 +00:00
committed by Tao Huang
parent cab48d65f1
commit 3301ea2fe9
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/gpu/drm/rockchip/rockchip_drm_vop.c
View File

@@ -5399,10 +5399,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
spin_lock_init(&vop->irq_lock);
mutex_init(&vop->vop_lock);
ret = devm_request_irq(dev, vop->irq, vop_isr,
IRQF_SHARED, dev_name(dev), vop);
if (ret)
return ret;
ret = vop_create_crtc(vop);
if (ret)
return ret;
@@ -5466,7 +5462,21 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
rockchip_drm_dma_init_device(drm_dev, dev);
ret = devm_request_irq(dev, vop->irq, vop_isr,
IRQF_SHARED, dev_name(dev), vop);
if (ret)
goto err_pm_detach;
return 0;
err_pm_detach:
if (vop->genpd_dev1)
dev_pm_domain_detach(vop->genpd_dev1, true);
if (vop->genpd_dev0)
dev_pm_domain_detach(vop->genpd_dev0, true);
pm_runtime_disable(dev);
vop_destroy_crtc(vop);
return ret;
}
static void vop_unbind(struct device *dev, struct device *master, void *data)