mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-09 04:10:18 +09:00
[PATCH v4 1/5] pstore: use snprintf
No guarantees that the names will not exceed the name buffer with future adjustments. Signed-off-by: Mark Salyzyn <salyzyn@android.com> Acked-by: Joe Perches <joe@perches.com> v2: switch from snprintf to scnprintf v3: remove embedded space v4: renumber pmsg series dependencies Change-Id: I161fe8cadc967d74e18cc09b7d60b5b398c92c86
This commit is contained in:
@@ -313,22 +313,24 @@ int pstore_mkfile(enum pstore_type_id type, char *psname, u64 id, int count,
|
||||
|
||||
switch (type) {
|
||||
case PSTORE_TYPE_DMESG:
|
||||
sprintf(name, "dmesg-%s-%lld", psname, id);
|
||||
scnprintf(name, sizeof(name), "dmesg-%s-%lld",
|
||||
psname, id);
|
||||
break;
|
||||
case PSTORE_TYPE_CONSOLE:
|
||||
sprintf(name, "console-%s", psname);
|
||||
scnprintf(name, sizeof(name), "console-%s", psname);
|
||||
break;
|
||||
case PSTORE_TYPE_FTRACE:
|
||||
sprintf(name, "ftrace-%s", psname);
|
||||
scnprintf(name, sizeof(name), "ftrace-%s", psname);
|
||||
break;
|
||||
case PSTORE_TYPE_MCE:
|
||||
sprintf(name, "mce-%s-%lld", psname, id);
|
||||
scnprintf(name, sizeof(name), "mce-%s-%lld", psname, id);
|
||||
break;
|
||||
case PSTORE_TYPE_UNKNOWN:
|
||||
sprintf(name, "unknown-%s-%lld", psname, id);
|
||||
scnprintf(name, sizeof(name), "unknown-%s-%lld", psname, id);
|
||||
break;
|
||||
default:
|
||||
sprintf(name, "type%d-%s-%lld", type, psname, id);
|
||||
scnprintf(name, sizeof(name), "type%d-%s-%lld",
|
||||
type, psname, id);
|
||||
break;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user