mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-10 21:07:02 +09:00
staging: pi433: remove coding style item from the TODO file
After several patches sent by the community along the last couple of years, it's possible to remove the coding style item from the TODO file in the driver's folder. This patch addresses the last code formatting inconsistences and remove the coding style item from the TODO file. Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com> Link: https://lore.kernel.org/r/YfYdVokxsQ+Adl+T@mail.google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
1245e7b64b
commit
52f11ec9b9
@@ -1,4 +1,3 @@
|
||||
* coding style does not fully comply with the kernel style guide.
|
||||
* still TODOs, annotated in the code
|
||||
* currently the code introduces new IOCTLs. I'm afraid this is a bad idea.
|
||||
-> Replace this with another interface, hints are welcome!
|
||||
|
||||
@@ -362,8 +362,7 @@ rf69_set_tx_cfg(struct pi433_device *dev, struct pi433_tx_cfg *tx_cfg)
|
||||
|
||||
/*-------------------------------------------------------------------------*/
|
||||
|
||||
static int
|
||||
pi433_start_rx(struct pi433_device *dev)
|
||||
static int pi433_start_rx(struct pi433_device *dev)
|
||||
{
|
||||
int retval;
|
||||
|
||||
@@ -403,8 +402,7 @@ pi433_start_rx(struct pi433_device *dev)
|
||||
|
||||
/*-------------------------------------------------------------------------*/
|
||||
|
||||
static int
|
||||
pi433_receive(void *data)
|
||||
static int pi433_receive(void *data)
|
||||
{
|
||||
struct pi433_device *dev = data;
|
||||
struct spi_device *spi = dev->spi;
|
||||
@@ -555,8 +553,7 @@ abort:
|
||||
return bytes_total;
|
||||
}
|
||||
|
||||
static int
|
||||
pi433_tx_thread(void *data)
|
||||
static int pi433_tx_thread(void *data)
|
||||
{
|
||||
struct pi433_device *device = data;
|
||||
struct spi_device *spi = device->spi;
|
||||
@@ -881,8 +878,7 @@ abort:
|
||||
return -EAGAIN;
|
||||
}
|
||||
|
||||
static long
|
||||
pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
|
||||
static long pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
|
||||
{
|
||||
struct pi433_instance *instance;
|
||||
struct pi433_device *device;
|
||||
|
||||
@@ -654,7 +654,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
|
||||
return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_CRC_OK);
|
||||
case battery_low:
|
||||
return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_LOW_BAT);
|
||||
default: return false;
|
||||
default:
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user