shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-10 21:07:02 +09:00
Code Issues Packages Projects Releases Wiki Activity

staging: r8188eu: Use memdup_user instead of kmalloc/copy_from_user

Browse Source 
Fix following coccicheck warning:
./drivers/staging/r8188eu/os_dep/ioctl_linux.c:1986:8-15: WARNING
opportunity for memdup_user.

Use memdup_user rather than duplicating its implementation, which
makes code simple and easy to understand.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211021122015.6974-1-wanjiabing@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wan Jiabing
2021-10-21 08:20:02 -04:00
committed by Greg Kroah-Hartman
parent 9da4b50c38
commit 5c0480deda
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/staging/r8188eu/os_dep/ioctl_linux.c
View File

@@ -1984,14 +1984,9 @@ static int rtw_wx_read32(struct net_device *dev,
padapter = (struct adapter *)rtw_netdev_priv(dev);
p = &wrqu->data;
len = p->length;
ptmp = kmalloc(len, GFP_KERNEL);
if (!ptmp)
return -ENOMEM;
if (copy_from_user(ptmp, p->pointer, len)) {
kfree(ptmp);
return -EFAULT;
}
ptmp = memdup_user(p->pointer, len);
if (IS_ERR(ptmp))
return PTR_ERR(ptmp);
bytes = 0;
addr = 0;