mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-09 04:10:18 +09:00
stm class: Support devices with multiple instances
[ Upstream commit 59be422e4c ]
By convention, the name of the stm policy directory in configfs consists of
the device name to which it applies and the actual policy name, separated
by a dot. Now, some devices already have dots in their names that separate
name of the actual device from its instance identifier. Such devices will
result in two (or more, who can tell) dots in the policy directory name.
Existing policy code, however, will treat the first dot as the one that
separates device name from policy name, therefore failing the above case.
This patch makes the last dot in the directory name be the separator, thus
prohibiting dots from being used in policy names.
Suggested-by: Chunyan Zhang <zhang.chunyan@linaro.org>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
ffb2f3f86b
commit
65b52bbc35
@@ -332,10 +332,11 @@ stp_policies_make(struct config_group *group, const char *name)
|
||||
|
||||
/*
|
||||
* node must look like <device_name>.<policy_name>, where
|
||||
* <device_name> is the name of an existing stm device and
|
||||
* <policy_name> is an arbitrary string
|
||||
* <device_name> is the name of an existing stm device; may
|
||||
* contain dots;
|
||||
* <policy_name> is an arbitrary string; may not contain dots
|
||||
*/
|
||||
p = strchr(devname, '.');
|
||||
p = strrchr(devname, '.');
|
||||
if (!p) {
|
||||
kfree(devname);
|
||||
return ERR_PTR(-EINVAL);
|
||||
|
||||
Reference in New Issue
Block a user